Re: [VOTE] Release Apache Tomcat 10.0.0-M9

2020-10-07 Thread Raymond Auge
On Tue, Oct 6, 2020 at 9:38 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M9 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications

Re: [VOTE] Release Apache Tomcat 8.5.59

2020-10-07 Thread Raymond Auge
On Tue, Oct 6, 2020 at 1:34 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.59 release is now available for voting. > > The notable changes compared to the 8.5.58 release are: > > - Refactor the handling of closed HTTP/2 streams to reduce the heap > usage associated with used streams

Re: [VOTE] Release Apache Tomcat 9.0.39

2020-10-07 Thread Raymond Auge
On Tue, Oct 6, 2020 at 10:49 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.39 release is now available for voting. > > The notable changes compared to the 9.0.38 release are: > > - Refactor the handling of closed HTTP/2 streams to reduce the heap > usage associated with used streams

Re: [tomcat] 01/03: Fix 64751 - Correct JPMS descriptor for embedded

2020-09-29 Thread Raymond Auge
Nice fix @markt! This was in my stack of changes from earlier work when we got blocked on finalizing module naming. - Ray On Fri, Sep 18, 2020 at 4:14 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository

Re: [VOTE] Release Apache Tomcat 9.0.38

2020-09-14 Thread Raymond Auge
> > [x] Stable - go ahead and release as 9.0.38 > +1 - Ray

Re: [VOTE] Release Apache Tomcat 10.0.0-M8

2020-09-14 Thread Raymond Auge
> [x] Alpha - go ahead and release as 10.0.0-M8 +1 - Ray

Re: security.txt

2020-09-01 Thread Raymond Auge
On Tue, Sep 1, 2020 at 2:38 PM Mark Thomas wrote: > On 01/09/2020 18:01, Christopher Schultz wrote: > > All, > > > > I'd like to propose that we publish a security.txt[1] file on our web > > site under /.well-known/security.txt and /security.txt > > > > This file contains information we all

Re: Jakarta EE APIs

2020-07-25 Thread Raymond Auge
+1 - Ray On Wed., Jul. 22, 2020, 5:29 p.m. Martin Grigorov, wrote: > > > On Wed, Jul 22, 2020, 18:10 Mark Thomas wrote: > >> Hi all, >> >> We currently have implementations for all of the Jakarta APIs that ship >> with Tomcat and partial implementations for 5 additional Jakarta APIs that >>

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

2020-07-21 Thread Raymond Auge
Hey all, Thanks for looking into this. I made sure using a binary comparison tool that the jars did in fact contained the correct bits before and after all my changes. But Mark is correct that some of the previously private packages are actually used externally and I had some changes coming to

Re: Native Image - Reflectionless Concept

2020-07-20 Thread Raymond Auge
Xml-less Tomcat would also be very useful for OSGi http whiteboard implementation which I'd like to work on in the coming months. So I +1 more programmatic API. Just let's not forget about tear down. So many APIs completely ignore a tear down lifecycle. - Ray On Mon, Jul 20, 2020, 12:16 Romain

Re: [tomcat] branch 9.0.x updated: Fix BZ 64548 - generate JPMS metadata

2020-07-14 Thread Raymond Auge
I'll make the change today. Thanks all, - Ray On Mon, Jul 13, 2020, 07:37 Martin Grigorov, wrote: > > > On Mon, Jul 13, 2020 at 1:02 PM Mark Thomas wrote: > >> There are some Java EE / Jakarta EE issues here. >> >> Tomcat 10 is Jakarta EE. >> Tomcat 9 is Java EE. >> >> There should not be any

Re: [ANN] New committer: Raymond Augé

2020-07-02 Thread Raymond Auge
Thank you all. Sincerely, - Ray On Thu, Jul 2, 2020, 11:45 Romain Manni-Bucau, wrote: > Congrats Ray, well deserved! > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog > | Github >

Re: Release tagging

2020-06-30 Thread Raymond Auge
Hey Mark, I'm sorry I got sidetracked with other things but would it be possible to wait for the final JPMS/OSGi PRs if I promise to have them by the end of this week? I would love for that to be part of the 10.0.x tag but I understand if that's not possible. - Ray On Tue, Jun 30, 2020 at

Re: flaky HTTP2 test

2020-06-25 Thread Raymond Auge
Understood, sorry for the noise. - Ray On Thu, Jun 25, 2020, 02:27 Rémy Maucherat, wrote: > On Thu, Jun 25, 2020 at 3:28 AM Raymond Auge > wrote: > >> Sorry folks, but here are two more intermittent Http2 test failures: >> >> 2020-06-25T01:09:24.3494270Z[con

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
, Jun 24, 2020 at 11:56 AM Raymond Auge wrote: > Sorry about that. I've copied the entire build log here > > https://gist.github.com/rotty3000/475d92ece3f41123e7092ab31ce30f53 > > Hopefully you can see that one? > > - Ray > > On Wed, Jun 24, 2020 at 11:35 AM Eduard

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
{"count":11,"value":"Uri expired"} > > Eduardo Quintanilla > Software Developer > > From: Raymond Auge > Sent: miércoles, 24 de junio de 2020 10:29 a. m. > To: Tomcat Developers List > Subject: Re: flaky HTTP2 test > > You'll not

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
You'll notice that in the same run that test passed on JDK 14 and 15-ea. - Ray On Wed, Jun 24, 2020 at 11:26 AM Raymond Auge wrote: > See > https://pipelines.actions.githubusercontent.com/hQhYuytC86T1GsTs7qTvThq2ESqStTSskvOzwdA12PGOh7ZWVy/_apis/pipelines/1/runs/14/signedlogcontent/7?urlE

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
http2.TestHttp2Limits" - Ray On Wed, Jun 24, 2020 at 11:15 AM Mark Thomas wrote: > On 24/06/2020 15:56, Raymond Auge wrote: > > Hey all, > > > > The test > > org.apache.coyote.http2.TestHttp2Limits > > seems to be flaky. > > Haven'

flaky HTTP2 test

2020-06-24 Thread Raymond Auge
Hey all, The test org.apache.coyote.http2.TestHttp2Limits seems to be flaky. I'm playing with github actions as per https://github.com/apache/tomcat/pull/307 and I've observed that this test arbitrarily passes or fails. For now I will filter it out of my POC but I figured it might be relevant

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
Oh thank goodness! I was worried! Sincerely, - Ray On Tue, Jun 23, 2020 at 5:19 PM Filip Hanik wrote: > > On 6/23/20 1:58 PM, Raymond Auge wrote: > > Further review of your error seems to indicate you are not using the > specified version of bnd. Have you overridd

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?` - Ray On Tue, Jun 23, 2020 at 4:05 PM Raymond Auge wrote: > > > > On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik wrote: >>> >>>> cd res/maven >>>> >>> ant -f mvn-pub.xml generic-install >>>> >

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
pment/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd: >>> bnd failed >>> [bnd] at >>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240) >>> [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119) >>> [bn

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:57 PM Raymond Auge wrote: > > > On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik wrote: > >> >> On 6/23/20 12:38 PM, Raymond Auge wrote: >> >> `ant test` transitively invokes `deploy` target which builds the >> artifacts. >&

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik wrote: > > On 6/23/20 12:38 PM, Raymond Auge wrote: > > `ant test` transitively invokes `deploy` target which builds the artifacts. > > You'll want to run the following commands that are currently failing for me > > ant clean

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
`ant test` transitively invokes `deploy` target which builds the artifacts. - Ray On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik wrote: > > > > > *From:* Raymond Auge > *Sent:* Tuesday, June 23, 2020 12:17 PM > *To:* Tomcat Developers List > *Subject:* Re: [tomcat] bra

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
k, so travis config is borked.. I should add github actions. - Ray On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge wrote: > > > On Tue, Jun 23, 2020 at 3:09 PM Raymond Auge > wrote: > >> Also, at the root of 9.0.x I hard coded the value of: >>

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:09 PM Raymond Auge wrote: > Also, at the root of 9.0.x I hard coded the value of: > of course I meant HEAD (caed3194b48ccbbac0572417b0e60807683a8690) I'm not sure what you're missing. But it builds in CI does it not? - Ray > > Bundle-Version: ${ver

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
Also, at the root of 9.0.x I hard coded the value of: Bundle-Version: ${version_cleanup;9.0.0-native-image-dev} and the result was no error and bundles have: Bundle-Version: 9.0.0.native-image-dev - Ray On Tue, Jun 23, 2020 at 3:02 PM Raymond Auge wrote: > See https://bz.apache.org/bugzi

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
See https://bz.apache.org/bugzilla/show_bug.cgi?id=64498 On Tue, Jun 23, 2020 at 2:57 PM Raymond Auge wrote: > This is not a good fix. This is the same problem we had before with > incompatible version syntax in OSGi. > > - Ray > > On Tue, Jun 23, 2020

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
This is not a good fix. This is the same problem we had before with incompatible version syntax in OSGi. - Ray On Tue, Jun 23, 2020 at 2:54 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > fhanik pushed a commit to branch 9.0.x > in repository

Re: smoke tests for the runtime

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 10:54 AM Mark Thomas wrote: > On 23/06/2020 14:04, Raymond Auge wrote: > > Hey all, > > > > Is there a set of tests that run against a real tomcat runtime anywhere > > in the project already? I haven't found any and I'd like to put > >

smoke tests for the runtime

2020-06-23 Thread Raymond Auge
Hey all, Is there a set of tests that run against a real tomcat runtime anywhere in the project already? I haven't found any and I'd like to put something together that would run against base configurations of Tomcat running in JPMS and OSGi modes. -- *Raymond Augé*

Re: JPMS module names

2020-06-16 Thread Raymond Auge
On Tue, Jun 16, 2020 at 10:43 AM Mark Thomas wrote: > On 16/06/2020 15:00, Raymond Auge wrote: > > Hey folks, > > > > I've extrapolated what I found as basis for a rule to create module > > names and this is what I've come up with: > > > > module.name <h

JPMS module names

2020-06-16 Thread Raymond Auge
Hey folks, I've extrapolated what I found as basis for a rule to create module names and this is what I've come up with: module.name: org.apache.${replace;${Bundle-Name};-;.} that is: - take the `Bundle-Name` value (which appears to have a consistent format) - replace dashes with dots - prefix

Re: Changing the name of the default branch in our git repos

2020-06-16 Thread Raymond Auge
+1 for main On Tue, Jun 16, 2020 at 8:00 AM Coty Sutherland wrote: > > On Tue, Jun 16, 2020 at 4:02 AM Mark Thomas wrote: > >> All, >> >> You may have seen the recent discussions both inside and outside the ASF >> about the user of "master" as the name of the default git branch. If you >>

Re: Tomcat running fully on JPMS

2020-06-15 Thread Raymond Auge
And just now got it running fully on OSGi (with a small bootup shim, a.k.a. bundle). - Ray On Mon, Jun 15, 2020 at 9:58 AM Raymond Auge wrote: > There's a slew of changes still needed, but at least it's not a > pie-in-the-sky-like effort. > > - Ray > > On Mon, Jun 15, 20

Re: Tomcat running fully on JPMS

2020-06-15 Thread Raymond Auge
There's a slew of changes still needed, but at least it's not a pie-in-the-sky-like effort. - Ray On Mon, Jun 15, 2020 at 9:33 AM Mark Thomas wrote: > On 15/06/2020 01:56, Raymond Auge wrote: > > Hey all, > > > > I couldn't resist but to let you know that today

Tomcat running fully on JPMS

2020-06-14 Thread Raymond Auge
Hey all, I couldn't resist but to let you know that today I run tomcat 10 fully on JPMS (and the webapp examples seemed to all work fine): bin]$ /usr/lib/jvm/zulu-11-amd64/bin/java \ > -Djava.protocol.handler.pkgs=org.apache.catalina.webresources \ > -p .:../lib/ \ > --add-modules

Re: Bootstrap classloader hierarchy and split packages

2020-06-13 Thread Raymond Auge
Ok, I guess you can ignore this question because I think the conclusion is that bootstrap cannot be used in JPMS at all. I have figured out a boot process-ish and I can see things a little more clearly now. - Ray On Sat, Jun 13, 2020 at 9:12 PM Raymond Auge wrote: > Forgive

Re: Bootstrap classloader hierarchy and split packages

2020-06-13 Thread Raymond Auge
Forgive me if this is a well worn topic. - Ray On Sat, Jun 13, 2020 at 8:58 PM Raymond Auge wrote: > Hello Tomcat Devs, > > Is it expected that when Bootstrap.init() invokes > "org.apache.catalina.startup.Catalina"'s constructor (which it finds in > catalina.ja

Bootstrap classloader hierarchy and split packages

2020-06-13 Thread Raymond Auge
Hello Tomcat Devs, Is it expected that when Bootstrap.init() invokes "org.apache.catalina.startup.Catalina"'s constructor (which it finds in catalina.jar) via reflection through catalinaLoader that some of the classes in the package org.apache.catalina.startup, originating in bootstrap.jar, are

Re: Bootstrap and modules

2020-06-13 Thread Raymond Auge
Please see updated https://github.com/apache/tomcat/pull/296 - Ray On Sat, Jun 13, 2020 at 3:35 PM Raymond Auge wrote: > Hey Mark, I tested those changes and they solve the packaging issue for > both jpms and OSGi. > > I'll update the pr to reflect the change later today I hop

Re: Bootstrap and modules

2020-06-13 Thread Raymond Auge
. - Ray On Sat, Jun 13, 2020, 12:49 Mark Thomas, wrote: > On 13/06/2020 03:53, Raymond Auge wrote: > > Actually Bootstrap has a comment > > > > // Copied from ExceptionUtils since that class is not visible during > start > > > > So it seems like perhaps the change sh

Re: Bootstrap and modules

2020-06-12 Thread Raymond Auge
Actually Bootstrap has a comment // Copied from ExceptionUtils since that class is not visible during start So it seems like perhaps the change should be ported. - Ray On Fri, Jun 12, 2020 at 10:45 PM Raymond Auge wrote: > There is one difference betw

Re: Bootstrap and modules

2020-06-12 Thread Raymond Auge
or is it a deal breaker? An option would be to add an additional method to Bootstrap that behaves like ExceptionUtils. - Ray On Fri, Jun 12, 2020 at 9:27 AM Mark Thomas wrote: > On 12/06/2020 14:15, Raymond Auge wrote: > > Hey Mark, > > > > I'll have to get back to this convo in a da

Re: Bootstrap and modules

2020-06-12 Thread Raymond Auge
Hey Mark, I'll have to get back to this convo in a day or so. I'll test your theory but at first glance it sounds like going in the right direction. - Ray On Thu, Jun 11, 2020 at 5:08 PM Mark Thomas wrote: > On 11/06/2020 21:59, Mark Thomas wrote: > > On 11/06/2020 21:24, Raymond A

Re: Bootstrap and modules

2020-06-11 Thread Raymond Auge
This can totally be fixed in configuration. There is no problem. I just wanted to make sure that in doing so we wouldn't just be pushing some dirt under the rug so to speak. :) - Ray On Thu, Jun 11, 2020 at 3:25 PM Raymond Auge wrote: > To be clear, it's not necessarily having _

Re: Bootstrap and modules

2020-06-11 Thread Raymond Auge
To be clear, it's not necessarily having _all of a package_. It's more about all the reachable class references. For instance jdeps looks at classes and finds any reachable references. So does bnd for calculating OSGi metadata. So the issue is not really about packages, it's about having missing

Re: Improving OSGi/bnd build and much more...

2020-06-10 Thread Raymond Auge
at 2:54 PM Mark Thomas wrote: > On 09/06/2020 18:37, Raymond Auge wrote: > > Hey All (particularly Markt whom I spoke with about this months and > > months ago), > > > > Noting that bnd was already added to the build I took a crack at making > > better use of

Improving OSGi/bnd build and much more...

2020-06-09 Thread Raymond Auge
Hey All (particularly Markt whom I spoke with about this months and months ago), Noting that bnd was already added to the build I took a crack at making better use of it. Here are a few items and some questions in no particular order: - you don't use bndlib, can we remove that? bnd is fully

Re: [Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread Raymond Auge
On Fri, Jul 26, 2019 at 11:33 AM Mark Thomas wrote: > On 26/07/2019 16:27, Raymond Auge wrote: > > .. maybe I can play with it over the next months. > > Thanks. Much appreciated. We'll at least need to wait for a bnd 4.3.0 > release. Although I suspect that will happen befor

Re: [Bug 63555] embedded jar manifests missing automatic module names

2019-07-26 Thread Raymond Auge
.. maybe I can play with it over the next months. - Ray On Fri, Jul 26, 2019 at 11:24 AM wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=63555 > > --- Comment #3 from Raymond Augé --- > When you get back to this let me know if I can help with bnd. > > -- > You are receiving this mail

Re: Constants.IS_SECURITY_ENABLED

2013-08-19 Thread Raymond Auge
On Sun, Aug 18, 2013 at 3:36 PM, Mark Thomas ma...@apache.org wrote: On 18/08/2013 20:06, Raymond Auge wrote: On Sun, Aug 18, 2013 at 1:59 PM, Mark Thomas ma...@apache.org wrote: First of all this is a container concern, not an application concern. Secondly, a security manager applies JVM

Re: Constants.IS_SECURITY_ENABLED

2013-08-19 Thread Raymond Auge
Fair enough! Thank you On Mon, Aug 19, 2013 at 4:49 PM, Mark Thomas ma...@apache.org wrote: On 19/08/2013 21:11, Raymond Auge wrote: On Sun, Aug 18, 2013 at 3:36 PM, Mark Thomas ma...@apache.org wrote: On 18/08/2013 20:06, Raymond Auge wrote: On Sun, Aug 18, 2013 at 1:59 PM, Mark

Re: Constants.IS_SECURITY_ENABLED

2013-08-18 Thread Raymond Auge
I've filed a bugs: https://java.net/jira/browse/JSP-37 https://issues.apache.org/bugzilla/show_bug.cgi?id=55446 On Sun, Aug 18, 2013 at 12:15 PM, Raymond Auge raymond.a...@liferay.comwrote: Hello everyone, My name is Raymond Auge and this is my first message to the list. Hopefully I follow

Re: Constants.IS_SECURITY_ENABLED

2013-08-18 Thread Raymond Auge
On Sun, Aug 18, 2013 at 1:59 PM, Mark Thomas ma...@apache.org wrote: On 18/08/2013 17:34, Raymond Auge wrote: I've filed a bugs: https://java.net/jira/browse/JSP-37 https://issues.apache.org/bugzilla/show_bug.cgi?id=55446 And I have closed the Tomcat one as invalid. On Sun, Aug 18