Re: Drop module-info from tomcat*.jar?

2021-09-15 Thread Romain Manni-Bucau
Le mer. 15 sept. 2021 à 13:13, Mark Thomas a écrit : > On 15/09/2021 11:07, Romain Manni-Bucau wrote: > > I think the last option is maybe the target: modularize tomcat properly. > > "Properly" is a highly subjective judgement. There are going to be > wildly differi

Re: Drop module-info from tomcat*.jar?

2021-09-15 Thread Romain Manni-Bucau
regarding JPMS I think it is either being really modular or not being modular since the in between state leads to unsatisfied people and the biggest constraints come from JPMS. Is it something targettable or do you think it is too much work? side note: fine for me if it targets only 10.1. Romain M

Drop module-info from tomcat*.jar?

2021-09-15 Thread Romain Manni-Bucau
but happy with other solutions not requiring to fork. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <ht

Re: Graal now supports JMX?

2021-07-08 Thread Romain Manni-Bucau
Le jeu. 8 juil. 2021 à 15:36, Rémy Maucherat a écrit : > On Thu, Jul 8, 2021 at 1:21 PM Romain Manni-Bucau > wrote: > > > > Hi Mark, > > > > My understanding of the issue is that the isGraal test is not sufficient > > and should be precised to be

Re: Graal now supports JMX?

2021-07-08 Thread Romain Manni-Bucau
is not precise enough but that the disabling should stay by default for native-image. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rm

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Romain Manni-Bucau
+1 to move forward even if jakarta is not yet adopted (there is a single time direction - at least at our scale ;)) -0 to break all clones and related toolings/automotion for hypothetical reasons, didn't pay in all projects which did AFAIK Romain Manni-Bucau @rmannibucau <https://twitter.

Re: [VOTE] Release Apache Tomcat 10.0.6

2021-05-10 Thread Romain Manni-Bucau
+1, new instance manager usage for websocket layer works perfectly! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

server.json?

2021-05-08 Thread Romain Manni-Bucau
ruby, python and more recently typescript where XML is not so lovely to use so think JSON can help automotion there. Wdyt? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com&g

Re: Implementing web.xml default-context-path

2021-05-05 Thread Romain Manni-Bucau
Le mer. 5 mai 2021 à 11:19, Mark Thomas a écrit : > On 05/05/2021 09:58, Rémy Maucherat wrote: > > On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO > > wrote: > > > >> Hi, > >> > >> Still working on getting TomEE certified for Jakarta EE 9.1 > >> We are using latest Tomcat 10.x and we indeed

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

2021-05-04 Thread Romain Manni-Bucau
+1, xml fix is helping Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: mod_headers as a Filter

2021-04-27 Thread Romain Manni-Bucau
Isnt the response buffer size giving a sufficient hint or callback like (dont rewrite before it is reached or body starts to be read)? Guess filter must force some size if not set but sounds like something to check, no? Le mar. 27 avr. 2021 à 21:32, Raymond Augé a écrit : > Couldn't you add a

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-27 Thread Romain Manni-Bucau
"glue" to compensate a drop or is it still "too much" to maintain in your opinion? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-26 Thread Romain Manni-Bucau
n > > in another jar usable when not relying on tomcat-ws-api. Both options > work > > too even if first one would be simpler probably. > > > > Le jeu. 22 avr. 2021 à 18:29, Raymond Augé .invalid> > > a écrit : > > > >> Romain are yo

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-26 Thread Romain Manni-Bucau
Le lun. 26 avr. 2021 à 18:57, Mark Thomas a écrit : > On 26/04/2021 17:38, Romain Manni-Bucau wrote: > > JAASRealm is quite commonly used whereas JASPIC is almost never used > > References? > Sadly not public but all project not using a custom valve/auth where using jaas

Re: Clarify what Tomcat means with "Jakarta EE 9 "mention

2021-04-26 Thread Romain Manni-Bucau
Thanks a lot! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> |

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-26 Thread Romain Manni-Bucau
are not so it means you easily find a JAAS login module implementation and you don't find integrations for others so think it makes sense to keep JAAS integration more than others in default delivery. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog

Re: Clarify what Tomcat means with "Jakarta EE 9 "mention

2021-04-26 Thread Romain Manni-Bucau
In the spirit yes, exactly, in practise Tomcat is far to be web profile (far as it misses ~10 specs from memory which even includes JPA/JAX-RS for example) so the word/profile for Tomcat does not exist yet AFAIK. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog

Clarify what Tomcat means with "Jakarta EE 9 "mention

2021-04-26 Thread Romain Manni-Bucau
concerns a few specs and avoid this misunderstanding (guess a link to a reference page can work without being too heavy)? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> |

Re: [websocket] proper SPI for encoder/decoder instantiation?

2021-04-23 Thread Romain Manni-Bucau
Here it is https://bz.apache.org/bugzilla/show_bug.cgi?id=65262 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
ing a service descriptor in this case is > wrong? > > On Thu., Apr. 22, 2021, 11:47 a.m. Mark Thomas, wrote: > > > On 22/04/2021 16:18, Romain Manni-Bucau wrote: > > > I am not in JPMS Ray. > > > > > > About I think the issue is a "double bug" (

Re: [websocket] proper SPI for encoder/decoder instantiation?

2021-04-22 Thread Romain Manni-Bucau
Le jeu. 22 avr. 2021 à 17:32, Mark Thomas a écrit : > On 22/04/2021 16:24, Romain Manni-Bucau wrote: > > Hi, > > > > Is it possible to reuse/add/have a SPI to create ws coders/decoders? > > > > Currently it is a hardcoded factory doing a "new" > &

[websocket] proper SPI for encoder/decoder instantiation?

2021-04-22 Thread Romain Manni-Bucau
management (destroyInstance). Wdyt? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linke

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
gt;> > > > > To be clear, there is no runtime behavior associated with > @ServiceProvider > > _unless_ you are running tomcat in OSGi, which would bring in the Service > > Loader Mediator to handle the SPI call, BUT still would not change to > logic > > around

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
l good and we can drop https://github.com/apache/tomcat/blob/master/res/META-INF/tomcat-websocket.jar/services/jakarta.websocket.server.ServerEndpointConfig$Configurator all good for me > > Ray > > On Thu., Apr. 22, 2021, 9:29 a.m. Romain Manni-Bucau, < > rmannibu...@gmail.com>

Websocket server configurator as @ServiceProvider: a bug?

2021-04-22 Thread Romain Manni-Bucau
basis? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> |

Re: TCK Signature for EL API

2021-04-02 Thread Romain Manni-Bucau
Isn't it stable enough to use bcel or asm to write it? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Re: TCK Signature for EL API

2021-04-01 Thread Romain Manni-Bucau
for the impl but here bnd is fine). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: [VOTE] Release Apache Tomcat 9.0.45

2021-03-31 Thread Romain Manni-Bucau
+1 (non binding), tested on a few projects Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.

Re: Refactoring the HTTP/2 API

2021-03-11 Thread Romain Manni-Bucau
+1, just wonder if in 8.5 both cant stay somehow (like just adding) by delegating the new method to the "old" ones? Would mitigate the breaking changes and enable the API to stay most likely compatible. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau>

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

2021-02-15 Thread Romain Manni-Bucau
+1 (non binding) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Fail if web.xml resource not linked?

2021-02-14 Thread Romain Manni-Bucau
ance which does not make sense for applications in 100% of cases. Is it something already discussed? Goal is really to identify the configuration is incomplete faster (at startup) and not have a working smoke test (lookup returns something) and broken runtime (getConnection for ex). Romain M

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 17:15, Emmanuel Bourg a écrit : > Le 2021-02-10 16:36, Rémy Maucherat a écrit : > > > After reading everything, I'd say it's worth adding a second integrated > > option, and think I'm now swaying towards the runtime option. The main > > problem would be the detection of

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 16:37, Rémy Maucherat a écrit : > On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways to do

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 09:32, Martin Grigorov a écrit : > Hi, > > On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
ince often webapps are dropped or undesired except the app webapps in real or dev deployments. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com

Re: Applications setting connection specific HTTP headers

2021-02-04 Thread Romain Manni-Bucau
+1, out of curiosity, cant rewrite valve help somehow? Le jeu. 4 févr. 2021 à 19:11, Mark Thomas a écrit : > On 04/02/2021 17:56, Romain Manni-Bucau wrote: > > I always fixed it by a filter until now. > > What about adding a filter in tomcat and if users complain move to > an

Re: Applications setting connection specific HTTP headers

2021-02-04 Thread Romain Manni-Bucau
I always fixed it by a filter until now. What about adding a filter in tomcat and if users complain move to another solution? Can even be marked @Alpha for a few I guess. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: Applications setting connection specific HTTP headers

2021-02-04 Thread Romain Manni-Bucau
;)) but nothing a filter can't fix trivially. So helping is clearly interesting, I'm not 100% sure it belongs to tomcat but a configurable filter wouldnt hurt or impact other users while not active by default I think and it will help for these cases. Romain Manni-Bucau @rmannibucau <ht

Re: Applications setting connection specific HTTP headers

2021-02-04 Thread Romain Manni-Bucau
sort of functionality we are > discussing here won't want to / be able to deploy custom code and would > prefer a configuration only solution. We could address that by providing > some custom implementations. > > > On Wed, Feb 3, 2021 at 11:15 AM Romain Manni-Bucau < > rmanni

Re: Applications setting connection specific HTTP headers

2021-02-03 Thread Romain Manni-Bucau
Le mer. 3 févr. 2021 à 17:10, Mark Thomas a écrit : > On 03/02/2021 16:06, Romain Manni-Bucau wrote: > > Hi, > > > > Why not just adding a tomcat-application-fixer module (a more ugly name > can > > be relevant ;)) application could add in their WEB-INF/lib throu

Re: Applications setting connection specific HTTP headers

2021-02-03 Thread Romain Manni-Bucau
wrap the response to do the fixes you want for these apps but it wouldnt be seen in the most common case at all (or if there is only this small fix it can be a default filter of tomcat, depends the number of fixes and related code IMHO). Romain Manni-Bucau @rmannibucau <https://twitter.

Re: [VOTE] Release Apache Tomcat 9.0.43

2021-02-01 Thread Romain Manni-Bucau
[ X ] Stable - go ahead and release as 9.0.43 (non binding) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Re: [VOTE] Release Apache Tomcat 9.0.42

2021-01-28 Thread Romain Manni-Bucau
+1 (non binding) - tested with meecrowave Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.

Re: [PATCH] AbstractAccessLogValve: Add pre/post add log element extension points

2021-01-21 Thread Romain Manni-Bucau
custom dependency if it helps. Le jeu. 21 janv. 2021 à 16:03, Thomas Meyer a écrit : > On Thu, Jan 21, 2021 at 03:28:12PM +0100, Romain Manni-Bucau wrote: > > Hi > > Hi, > > > Why cant it be added as element earlier at pattern parsing time? Would > > avoid to have

Re: [PATCH] AbstractAccessLogValve: Add pre/post add log element extension points

2021-01-21 Thread Romain Manni-Bucau
Hi Why cant it be added as element earlier at pattern parsing time? Would avoid to have two particular cases and keep current pattern/impl. A %java or so sounds more natural no? Le jeu. 21 janv. 2021 à 13:59, Thomas Meyer a écrit : > a sub class can extend before and after the addElement loop

Re: "Missing" break in listenerStart?

2021-01-13 Thread Romain Manni-Bucau
Le mer. 13 janv. 2021 à 15:42, Konstantin Kolinko a écrit : > Hi! > > ср, 13 янв. 2021 г. в 17:04, Romain Manni-Bucau : > > > > Drafted https://github.com/apache/tomcat/pull/400 in regards of that > topic. > > > > Looks good thus far. > Several notes: &g

Idea setup not functional for community edition

2021-01-13 Thread Romain Manni-Bucau
but thought it was worth mentionning it can not work after running the ant task. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

Re: "Missing" break in listenerStart?

2021-01-13 Thread Romain Manni-Bucau
Drafted https://github.com/apache/tomcat/pull/400 in regards of that topic. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

"Missing" break in listenerStart?

2021-01-12 Thread Romain Manni-Bucau
thought on it? [1] https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/core/StandardContext.java#L4669 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com&g

Re: channelSendOptions default may cause problems

2021-01-06 Thread Romain Manni-Bucau
fits his app and explicitly configure it. Don't think we can find the good default for this trade off (between perf and reliability) for prod but we should stay working OOTB in dev and "first" env (like functional, dev, test ones) IMHO. Romain Manni-Bucau @rmannibucau <https://twitter.co

Re: Tomcat 10 digester warnings

2021-01-04 Thread Romain Manni-Bucau
Le lun. 4 janv. 2021 à 15:04, Mark Thomas a écrit : > On 04/01/2021 11:54, Romain Manni-Bucau wrote: > > > > > Well it also depends the classpath. I fully agree with a plain tomcat not > > customized you don't get much - just have a more consistent usage of > > r

Re: Tomcat 10 digester warnings

2021-01-04 Thread Romain Manni-Bucau
Le lun. 4 janv. 2021 à 12:41, Mark Thomas a écrit : > On 04/01/2021 08:59, Romain Manni-Bucau wrote: > > Hi Mark, > > > > The proposal is to move the locationFor to a Supplier instead of > > eagerly loading the URL (means the maps passed to the resolver override &g

Re: Tomcat 10 digester warnings

2021-01-04 Thread Romain Manni-Bucau
and does not change at all the runtime for them). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.

Re: Tomcat 10 digester warnings

2021-01-03 Thread Romain Manni-Bucau
all these lookups lazily (in a concurrent hash map or so)? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Tomcat 10 digester warnings

2021-01-03 Thread Romain Manni-Bucau
Hi all Digester prefetches most ee schemas but ee 9 bundle does miss most of them leading to a lot of warnings at startup. Should log level be reduced or fetching be done lazily?

Re: Tomcat 10 startup time and JMX as an opt in fature?

2020-12-28 Thread Romain Manni-Bucau
Le lun. 28 déc. 2020 à 13:48, Rémy Maucherat a écrit : > On Sun, Dec 27, 2020 at 4:16 PM Romain Manni-Bucau > wrote: > > > Hi everyone, > > > > wonder if there is some work planned in tomcat 10 to 1. makes it start > > faster and 2. make jmx optional. >

Tomcat 10 startup time and JMX as an opt in fature?

2020-12-27 Thread Romain Manni-Bucau
8ms startHost: 19ms startEngine: 7ms startHttp11Nio2Protocol: 25ms startService:39ms startServer: 12ms startContext:26ms actualStart: 200ms Wdyt? Anyone had a look before? PS: if curious the registry patch i did was: https://gist

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
Le mer. 23 déc. 2020 à 22:23, Mladen Adamović a écrit : > On Wed, Dec 23, 2020 at 9:13 PM Romain Manni-Bucau > wrote: > > > I am for it, dependency free is key as soon as you modify tomcat/lib - > and > > since it is a transversal extension it will often be

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
h enables to match the letsencript challenge whatever is deployed as app. > > > > > > > > > > > On Wed, Dec 23, 2020 at 7:02 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > > Mladen, > > > > On 12/23/20 11:24, Mladen Adamović wro

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
Le mer. 23 déc. 2020 à 17:24, Mladen Adamović a écrit : > On Wed, Dec 23, 2020 at 4:44 PM Romain Manni-Bucau > wrote: > > > 1. Usage, typically if you run in kubernetes or any managed instance env > > then you don't care and will restart the instance (with graceful > s

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
Le mer. 23 déc. 2020 à 15:36, Mladen Adamović a écrit : > On Wed, Dec 23, 2020 at 3:17 PM Romain Manni-Bucau > wrote: > > > I'm tempted to say either provide a default tomcat-letsencrypt module > > "ready to activate" - and I would support you in that wor

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
t already so guess this adjustment work is already done. > > > On Wed, Dec 23, 2020 at 2:01 PM Romain Manni-Bucau > wrote: > > > Le mer. 23 déc. 2020 à 12:50, Mladen Adamović > > > a > > écrit : > > > > > On Wed, Dec 23, 2020 at 12:12 PM Romain M

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
Le mer. 23 déc. 2020 à 12:50, Mladen Adamović a écrit : > On Wed, Dec 23, 2020 at 12:12 PM Romain Manni-Bucau > > wrote: > > > I don't think so, this connector auth is only used in very particular > cases > > (= never ;)): HTTP2 - we don't care, AJP - we don't care mu

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
- are valves. In other words: no code change required in tomcat internals. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-23 Thread Romain Manni-Bucau
Side note: using a servlet generally does not work if you have any security on the webapp + requires a webapp whereas using a valve solves these two issues. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-19 Thread Romain Manni-Bucau
Le sam. 19 déc. 2020 à 17:34, Mladen Adamović a écrit : > On Sat, Dec 19, 2020 at 5:06 PM Romain Manni-Bucau > wrote: > > > Code can likely be simplified but high level it is just about enabling > > letsencrypt http dance thanks a valve and reloading the cert on update. &

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-19 Thread Romain Manni-Bucau
Le sam. 19 déc. 2020 à 16:43, Mladen Adamović a écrit : > On Sat, Dec 19, 2020 at 4:25 PM Romain Manni-Bucau > wrote: > > > It sounds saner than a random reload N days since it can reload when the > > cert changes. > > > > Hi Romain, > BTW, Letsencr

Re: feature request: reload SSL certificate automatically after X days (configuration option)

2020-12-19 Thread Romain Manni-Bucau
https://github.com/apache/openwebbeans-meecrowave/tree/master/meecrowave-letsencrypt/src/main/java/org/apache/meecrowave/letencrypt should be reusable just dropping the few references to meeceowave and replacing it by valve or listener config in server.xml. It sounds saner than a random reload N

Re: Compat versions

2020-12-18 Thread Romain Manni-Bucau
nce cost for tomcat itself. Hope it makes sense. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.l

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-11 Thread Romain Manni-Bucau
Le ven. 11 déc. 2020 à 10:59, Rémy Maucherat a écrit : > On Thu, Dec 10, 2020 at 5:14 PM Mark Thomas wrote: > > > On 10/12/2020 14:52, Romain Manni-Bucau wrote: > > > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat a > écrit : > > >> On Thu, Dec 10

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-10 Thread Romain Manni-Bucau
Le jeu. 10 déc. 2020 à 17:14, Mark Thomas a écrit : > On 10/12/2020 14:52, Romain Manni-Bucau wrote: > > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat a écrit : > >> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas wrote: > >>> On 10/12/2020 13:58, Christopher Schu

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-10 Thread Romain Manni-Bucau
Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat a écrit : > On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas wrote: > > > On 10/12/2020 13:58, Christopher Schultz wrote: > > > Mark, > > > > > > On 12/10/20 06:39, Mark Thomas wrote: > > >> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0

Re: EE 8 / 9 TCK status

2020-11-17 Thread Romain Manni-Bucau
Hi JL, did you check https://cwiki.apache.org/confluence/display/TOMCAT/Jakarta+EE+TCKs out? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://g

Re: Application-accesible Executors

2020-09-22 Thread Romain Manni-Bucau
Le mar. 22 sept. 2020 à 08:54, Martin Grigorov a écrit : > Hi Chris, > > On Fri, Sep 18, 2020 at 7:10 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > > All, > > > > I've recently been thinking about application uses of servlet-async and > > Websocket for long-running

Re: WsFilter is missing destroy method

2020-09-21 Thread Romain Manni-Bucau
Hi Ralph, Did you check your api jar was matching tomcat impl version? destroy is in the interface (default method): https://github.com/apache/tomcat/blob/9.0.x/java/javax/servlet/Filter.java#L119 So without more details it sounds you have a dependency conflict or outdated import. Romain Manni

Re: Application-accesible Executors

2020-09-18 Thread Romain Manni-Bucau
, then it is just a matter of defining it as resources in tomcat and do a lookup in any init method to get it I think, we can. Code is trivially extractable from tomee if it is what you have in mind and Apache Geronimo can be a "shared" home for such lib by "design". Hope it makes sense.

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-23 Thread Romain Manni-Bucau
nually). Do I miss something? Le jeu. 23 juil. 2020 à 03:02, Filip Hanik a écrit : > Hi Romain, > > > -Original Message- > > From: Romain Manni-Bucau > > Sent: Wednesday, July 22, 2020 12:48 PM > > To: Tomcat Developers List > > Subject: Re: [

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Romain Manni-Bucau
Thinking out loud: cant you substitute it to be hardcoded to true in native mode? This way you get the best of both. Le mer. 22 juil. 2020 à 20:17, Filip Hanik a écrit : > Thanks Remy, > > > > I ran into some failures when running the test suite using the substrate > VM, but it makes more sense

Re: Jakarta EE APIs

2020-07-22 Thread Romain Manni-Bucau
Le mer. 22 juil. 2020 à 18:29, Mark Thomas a écrit : > On 22/07/2020 17:11, Romain Manni-Bucau wrote: > > Hi Mark, > > > > Another option is to use Apache Geronimo specs (and update/create > > missing ones - think new mail one is not yet there for ex). > > This i

Re: Jakarta EE APIs

2020-07-22 Thread Romain Manni-Bucau
cleans up the legal work for Tomcat as a small side bonus. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Re: JAX-RPC and Tomcat 10

2020-07-21 Thread Romain Manni-Bucau
Yes, was thinking to tomee in particular since it does not use tomcat as a lib but really as the container so if the container fails then it can become hard if not "disabl-able" somehow (at least with subclassing or something programmatic). Romain Manni-Bucau @rmannibucau <https:

Re: JAX-RPC and Tomcat 10

2020-07-21 Thread Romain Manni-Bucau
Hi Mark, e) c as default + add a toggle to behave as a? (thinking to container extending tomcat where this shouldn't fail probably) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpres

Re: Native Image - Reflectionless Concept

2020-07-20 Thread Romain Manni-Bucau
:47 AM, Romain Manni-Bucau wrote: > > > > Le lun. 20 juil. 2020 à 17:41, Filip Hanik a écrit : > >> Thanks for chiming in: >> On 7/16/20 6:46 AM, Romain Manni-Bucau wrote: >> >> Hi everyone, >> >> I think the generation is the sanest option since c

Re: Native Image - Reflectionless Concept

2020-07-20 Thread Romain Manni-Bucau
Le lun. 20 juil. 2020 à 17:41, Filip Hanik a écrit : > Thanks for chiming in: > On 7/16/20 6:46 AM, Romain Manni-Bucau wrote: > > Hi everyone, > > I think the generation is the sanest option since code stay clean but it > shouldn't be done in tomcat IMHO but in user code an

Re: Native Image - Reflectionless Concept

2020-07-16 Thread Romain Manni-Bucau
em and use plain java instead (with a good naming convention, it can be generated as well). Keeps the duplication but at least the main code stays clean and optimizations stays together. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net

Re: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-07-14 Thread Romain Manni-Bucau
Le mar. 14 juil. 2020 à 15:50, Merlin Beedell a écrit : > Thank you for the responses. > I can confirm that changing the certificate by replacing the file(s) with > the ones with the same name & password but with an updated certificate > inside does indeed work. The reason I thought otherwise

Re: [ANN] New committer: Raymond Augé

2020-07-02 Thread Romain Manni-Bucau
Congrats Ray, well deserved! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: Changing the name of the default branch in our git repos

2020-06-16 Thread Romain Manni-Bucau
erior thought people can have as with master or main and it sounds more modern than trunk ;). Indeed, just my 2 cents ;). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> |

Re: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-06-11 Thread Romain Manni-Bucau
This one was more intended to System.exit but it got aligned with mw impl so it is quite close. Le jeu. 11 juin 2020 à 19:40, Christopher Schultz < ch...@christopherschultz.net> a écrit : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Romain, > > On 6/11/20 1

Re: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-06-11 Thread Romain Manni-Bucau
not. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <htt

Re: Support for LetsEncrypt certs, and update process, in Tomcat without restart.

2020-06-08 Thread Romain Manni-Bucau
/meecrowave-letsencrypt/src/main/java/org/apache/meecrowave/letencrypt/LetsEncryptReloadLifecycle.java#L155 for an impl. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github &

Re: API Change - Connector.java Constructor

2020-04-16 Thread Romain Manni-Bucau
Doesn't the same applies? It is a finite product (and not too big). The only choice to do is how to expose it I guess. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com&g

Re: API Change - Connector.java Constructor

2020-04-16 Thread Romain Manni-Bucau
hen you can be fully reflection free using the generated classes instead of the standard one. Hope it makes sense and it is not too late. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannib

Re: [tomcat-jakartaee-migration] branch master updated: Add javax.(decorator|enterprise|inject) as ones which should be migrated

2020-03-13 Thread Romain Manni-Bucau
Hi everyone, Shouldnt tomcat tool stay aligned on tomcat stack? Maven shade or gradle fatjar plugins solve this issue with relocation for all users and all namespaces so not a big deal to not handle more than tomcat IMO, otherwise all hybrid cases (between ~servlet and ee) will be broken IMHO.

Re: Enabling http to https redirects for tomcat.apache.org

2020-02-25 Thread Romain Manni-Bucau
+1 with some light (1 month?) notice time in case anyone uses http directly intentionally, will avoid some security breaches http can get, in particular on subdomains. Le mar. 25 févr. 2020 à 21:45, Christopher Schultz < ch...@christopherschultz.net> a écrit : > -BEGIN PGP SIGNED

Re: [VOTE] Release Apache Tomcat 10.0.0.0-M1

2020-02-06 Thread Romain Manni-Bucau
+1 (non binding) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: javax -> jakarta rename

2019-12-25 Thread Romain Manni-Bucau
I see a lot of value to the runtime solution cause it is the only one enabling an ops only migration so for all the softwares in "run only" phase it is the only option. However the agent or transformer is the least invasive solution cause it does not require to patch core libs and will avoid app

Re: javax -> jakarta rename

2019-12-21 Thread Romain Manni-Bucau
Hi Adam, Did you evaluate a class transformer added to tomcat classloader? This can stay quite light and enables the same while not using app loader - standard tomcat mode. For app loader case integrations can do the work easily (spring and friends) since they all have asm or equivalent. Hope it

Re: [VOTE] Release Apache Tomcat 9.0.30

2019-12-09 Thread Romain Manni-Bucau
+1 (non binding) Le lun. 9 déc. 2019 à 16:18, Coty Sutherland a écrit : > On Sat, Dec 7, 2019 at 12:24 PM Mark Thomas wrote: > >> The proposed Apache Tomcat 9.0.30 release is now available for voting. >> >> The major changes compared to the 9.0.29 release are: >> >> - Correct multiple

Re: Embedded and default MIME types

2019-12-04 Thread Romain Manni-Bucau
+1 to align both, really reduces diff in tests and prod Le mer. 4 déc. 2019 à 19:23, Mark Thomas a écrit : > On 04/12/2019 18:11, Christopher Schultz wrote: > > Mark, > > > > On 12/4/19 13:02, Mark Thomas wrote: > >> Hi all, > > > >> I was looking at this as an off-shoot of looking at BZ 63985.

  1   2   3   4   >