[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Github user katya-stoycheva commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/69#discussion_r126873704
--- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java ---
@@ -0,0 +1,59 @@
+package org.apache.juli;
+
+import static org.junit.Assert.assertTrue;
+
+import java.io.File;
+
+import org.apache.catalina.startup.LoggingBaseTest;
+import org.junit.After;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class TestFileHandlerNonRotatable extends LoggingBaseTest {
+private FileHandler testHandler;
+
+@BeforeClass
+public static void setUpPerTestClass() throws Exception {
+System.setProperty("java.util.logging.manager",
+"org.apache.juli.ClassLoaderLogManager");
+System.setProperty("java.util.logging.config.file",
+TestFileHandlerNonRotatable.class
+.getResource("logging-non-rotatable.properties")
+.getFile());
+}
--- End diff --
added a line to decode URL path but this behavior is different in IDE
(Eclipse in my case) and command line so please test both to be sure everything
works
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Github user katya-stoycheva commented on a diff in the pull request: https://github.com/apache/tomcat/pull/69#discussion_r126873614 --- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java --- @@ -0,0 +1,59 @@ +package org.apache.juli; --- End diff -- Added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/69 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61232 Checks for one char separator only, not specifically for "." You can merge this pull request into a Git repository by running: $ git pull https://github.com/katya-stoycheva/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #62: Fix config context.xml documentation about jndiExce...
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/62 Fix config context.xml documentation about jndiExceptionOnFailedWrite You can merge this pull request into a Git repository by running: $ git pull https://github.com/katya-stoycheva/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 97cd679036dc0b6ec68ebcc10a569bfaf0cef08a Author: Katya Todorova Date: 2017-06-09T20:39:16Z Fix config context.xml documentation about jndiExceptionOnFailedWrite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #61: [Bug 61134] remove [] around text substitutes for d...
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/61 [Bug 61134] remove [] around text substitutes for default error pages partial revert of https://svn.apache.org/viewvc?view=revision&revision=1792132 You can merge this pull request into a Git repository by running: $ git pull https://github.com/katya-stoycheva/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit ae80ca599c220145f336e2836ee35d8299fb2902 Author: Katya Todorova Date: 2017-06-09T14:46:39Z [Bug 61134] remove [] around text substitutes for default error pages (partial revert of r1792132) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #57: Remove final modifiers from TagLibraryInfo uri and ...
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/57 Remove final modifiers from TagLibraryInfo uri and prefix Remove final modifiers from TagLibraryInfo uri and prefix fields to match the spec You can merge this pull request into a Git repository by running: $ git pull https://github.com/katya-stoycheva/tomcat trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit a333f9e1bfcddd4fceed534941b7a23c3c64d434 Author: Katya Todorova Date: 2017-06-01T08:09:19Z Remove final modifiers from uri and prefix fields so they match the specification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #49: Fix parser to fail if leading zeros in IPv4 part of...
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/49 Fix parser to fail if leading zeros in IPv4 part of IPv6 address Leading zeros are not causing failure if in IPv4 addresses though. You can merge this pull request into a Git repository by running: $ git pull https://github.com/katya-stoycheva/tomcat leading-zeros-ipv4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit 071ab90eecda2ff1dc751f0557dca6ead93c41f4 Author: Katya Todorova Date: 2017-03-31T08:28:00Z Fix parser to fail if leading zeros are presented in IPv4 part of IPv6 address. Leading zeros are not causing failure if in IPv4 addresses though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #48: Fix http parser
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/48 Fix http parser Fix IPv6/IPv4 parsing for host header: - chars other than : should not be allowed in IPv6 address after ] - ::: should not present in IPv6 address - IPv4 part of IPv6 address was not correctly parsed (1 symbol of IPv4 part was ignored) - tests added to cover IPv4/6 parsing - parsed test class fixed not to throw NPE when an exception is expected but not thrown You can merge this pull request into a Git repository by running: $ git pull https://github.com/katya-stoycheva/tomcat fix-http-parser Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit 9d1787b8c7cac6e1448f5446b6e766a8efa82ec5 Author: Todorova, Katya Date: 2017-03-30T13:25:08Z Check no additional symbols after ] in IPv6 hosts commit f14d497d9e36dfc4e3c8a904e5608341f44e7f15 Author: Katya Todorova Date: 2017-03-30T13:48:46Z Check ::: is not presented in IPv6 host commit a3e64260605d0e7eb967638c3621e639d39fb33e Author: Katya Todorova Date: 2017-03-30T13:59:33Z Fix parser read position when reading IPv4 part of IPv6 host commit 775e3ad85f1c12708250c9f16930bbe6e6b3cfe9 Author: Katya Todorova Date: 2017-03-30T14:26:05Z Add more test cases to increase code coverage commit da5a06c67beb9cbb2b72b04ff991b82623654c82 Author: Katya Todorova Date: 2017-03-30T14:26:54Z Fix NPE in test class when an exception is expected but not thrown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
