[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-20 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/134 @ljader, why? This is a static change, not a dynamic one. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-19 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/134 > How I can get the "Date" header without reloading the page when the DevTools are closed (by default)? As far as I can see, you can't > Doesn't the "Modifi

[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/134 I agree with @rmaucher, I see little benefit here. This not static content, but dynamic. We have browser info and the {{Date}} header. For those who want to checksum the response, this change

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 Please have a look what @ChristopherSchultz has proposed on the ticket. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 I'd really like to go with listeners as proposed just like the Spring Secutiry framework does. You will be able to do whatever your want with that information

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 Oh hell, this will break the public API in a patch release. Especially for custom components. They won't retrain backward compat. Isn't there a better way

[GitHub] tomcat pull request #:

2018-07-20 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/tomcat/commit/eb195bebac8239b994fa921aeedb136a93e4ccaf#commitcomment-29778594 In java/org/apache/catalina/core/ApplicationContext.java: In java/org/apache/catalina/core/ApplicationContext.java on line

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 @rainerjung My question simply was that if `Expires: 0` denotes a value in the past (expired already), why should I explicitly use a valid header in the past which requires more code to create

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-20 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 Here is the reference commit: https://github.com/apache/httpd/commit/60087a708b051c3c987b80abdfdc3f2e046ebc4d @rainerjung How is `APR_DATE_BAD` defined? Unparsable? Or before Unix epoch

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-16 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 Thanks for the explanation. I hardly believe that Chrome does not implement `Expires: 0`. At best, we inquire with the Chromium project

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-16 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 @pandareen, how do you know that Chrome does not understand it? --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-16 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 I'd rather use `0` according to the spec. Moreover, it has less bytes to transfer. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] tomcat pull request #98: Fix for BZ62048

2018-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/tomcat/pull/98#discussion_r195838254 --- Diff: java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java --- @@ -173,6 +177,36 @@ protected String add(HttpServletRequest request,String

[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123

2018-06-15 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 The format is described here: https://tools.ietf.org/html/rfc7231#section-7.1.1.1 Why not the stuff altogether and store the preformatted string in a static final? We can also use the value

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2017-12-31 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 Alright, did not notice that. Mark has to tell wether he is willing to change this in 9.0. The other version likely won't change

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2017-12-30 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 @kdombeck Correct. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2017-12-28 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 Why is `POST` not part of the writable commands? --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...

2017-12-14 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 @markt-asf I'd second the 405 instead of 403. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

[GitHub] tomcat pull request #:

2017-03-29 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/tomcat/commit/d46012cb159c3384303eeceffc54eb78e6a62671#commitcomment-21548024 In java/org/apache/el/Messages.properties: In java/org/apache/el/Messages.properties on line 32: Shall it really output

Re: [Bug 54559] [PATCH] 1.1.27 needs APR = 1.3.0

2013-02-14 Thread Michael-O
Am 2013-02-14 00:43, schrieb bugzi...@apache.org: https://issues.apache.org/bugzilla/show_bug.cgi?id=54559 Rainer Jung rainer.j...@kippdata.de changed: What|Removed |Added

Re: RTC: Synchronize Tomcat 6 conf/web.xml mime mapping with Tomcat 7 [bug 54527]

2013-02-13 Thread Michael-O
Am 2013-02-12 20:32, schrieb Mark Thomas: On 12/02/2013 19:27, Michael-O wrote: Hi dev, by Konstantin's request I am asking the devs to consider synchronizing Tomcat 6 conf/web.xml mime mappings with Tomcat 7. In my opinion it would be very benificial for the entire user base when both mime

RTC: Synchronize Tomcat 6 conf/web.xml mime mapping with Tomcat 7 [bug 54527]

2013-02-12 Thread Michael-O
Hi dev, by Konstantin's request I am asking the devs to consider synchronizing Tomcat 6 conf/web.xml mime mappings with Tomcat 7. In my opinion it would be very benificial for the entire user base when both mime mappings sections would be in sync inspite the growth in size. I recently had