[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Mark Thomas  ---
Thanks for the test case. It made it much easier to be sure that the issue was
fixed.

Fixed in:
- master for 9.0.25 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

Carlos Hager  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

--- Comment #6 from Carlos Hager  ---
Created attachment 36763
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36763=edit
stacktrace of the example project

stacktrace of the example project

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

--- Comment #5 from Carlos Hager  ---
(In reply to Mark Thomas from comment #1)
> Please provide the simplest possible example (which is probably going to be
> a WAR file) - including source - that demonstrates this issue.

Hi Mark, thank for the quick reply. I have attached the source code of the
project (war had 4mb and was being blocked) and 2 prints while debugging.

On the method JspUtil().makeJavaPackage, the split method used to not
considerate the first "/" of the String. But the new refactor it does take this
situation in count, causing the make a java package with "..", how you can see
in the stacktrace.

Stacktrace:

An error occurred at line: [1] in the generated java file:
[/Users/carloshager/Library/Caches/IntelliJIdea2019.2/tomcat/Unnamed_error-example/work/Catalina/localhost/error_example/org/apache/jsp/tag/meta//WEB_002dINF/customTldResource_tld/main/jsPerformanceLog_tag.java]
The declared package "" does not match the expected package
"org.apache.jsp.tag.meta.WEB_002dINF.customTldResource_tld.main"

An error occurred at line: [9] in the generated java file:
[/Users/carloshager/Library/Caches/IntelliJIdea2019.2/tomcat/Unnamed_error-example/work/Catalina/localhost/error_example/org/apache/jsp/tag/meta//WEB_002dINF/customTldResource_tld/main/jsPerformanceLog_tag.java]
Syntax error on token ".", delete this token

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

--- Comment #4 from Carlos Hager  ---
Created attachment 36762
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36762=edit
print of debug showing how it was when used to work

the local split method wasn't considering the the first "/" and the package
name was being build properly

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

--- Comment #3 from Carlos Hager  ---
Created attachment 36761
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36761=edit
print of debug showing why it fails

print of debug showing why it fails, when new split method is considering the
first "/" and adding and extra "." to the package name causing the fail

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

--- Comment #2 from Carlos Hager  ---
Created attachment 36760
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36760=edit
source code of the project to be tested

simple project which works till version 9.0.20 and fail with the higher
versions 

using gradle 4.10.X to generate the war to be deployed run: $ gradle clean
build war

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63724] Compile JSP to class when using Tiles and custom tag fails

2019-09-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63724

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Mark Thomas  ---
Please provide the simplest possible example (which is probably going to be a
WAR file) - including source - that demonstrates this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org