Re: [DISCUSS] Remove org.apache.catalina.servlet4preview from 8.5.x

[Mark Thomas]

On 27/11/2019 17:07, Rémy Maucherat wrote:
> On Wed, Nov 27, 2019 at 6:06 PM Mark Thomas  > wrote:
> 
> Hi all,
> 
> The Servlet 4 preview API in 8.5.x has been deprecated for over a year.
> It was also inconsistent with the final Servlet 4.0 API until I fixed it
> in 8.5.49 although no-one complained about the inconsistency.
> 
> I'd like to propose removing the code completely.
> 
> I know this is an unusual thing to do in a point release - hence this
> discussion thread. My reasoning is:
> 
> - Anyone who wants Servlet 4 will have moved to 9.0.x already
> 
> - The servlet4preview has been deprecated for over a year
> 
> - We warned that it would be removed from 8.5.x at some point when we
>   deprecated it.
> 
> - If people were using it, they would have complained that the API was
>   wrong and no complaints were received. (At least I don't recall any.)
> 
> - It adds unnecessary complexity to the 8.5.x code.
> 
> - I like deleting code ;)
> 
> 
> :)
> 
> 
> Thoughts?
> 
> 
> +1, try it.

I think I'll aim to do this not for the next 8.5.x release but the one
after that.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [DISCUSS] Remove org.apache.catalina.servlet4preview from 8.5.x

[Rémy Maucherat]

On Wed, Nov 27, 2019 at 6:06 PM Mark Thomas  wrote:

> Hi all,
>
> The Servlet 4 preview API in 8.5.x has been deprecated for over a year.
> It was also inconsistent with the final Servlet 4.0 API until I fixed it
> in 8.5.49 although no-one complained about the inconsistency.
>
> I'd like to propose removing the code completely.
>
> I know this is an unusual thing to do in a point release - hence this
> discussion thread. My reasoning is:
>
> - Anyone who wants Servlet 4 will have moved to 9.0.x already
>
> - The servlet4preview has been deprecated for over a year
>
> - We warned that it would be removed from 8.5.x at some point when we
>   deprecated it.
>
> - If people were using it, they would have complained that the API was
>   wrong and no complaints were received. (At least I don't recall any.)
>
> - It adds unnecessary complexity to the 8.5.x code.
>
> - I like deleting code ;)
>

:)

>
> Thoughts?
>

+1, try it.

Rémy

>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[DISCUSS] Remove org.apache.catalina.servlet4preview from 8.5.x

[Mark Thomas]

Hi all,

The Servlet 4 preview API in 8.5.x has been deprecated for over a year.
It was also inconsistent with the final Servlet 4.0 API until I fixed it
in 8.5.49 although no-one complained about the inconsistency.

I'd like to propose removing the code completely.

I know this is an unusual thing to do in a point release - hence this
discussion thread. My reasoning is:

- Anyone who wants Servlet 4 will have moved to 9.0.x already

- The servlet4preview has been deprecated for over a year

- We warned that it would be removed from 8.5.x at some point when we
  deprecated it.

- If people were using it, they would have complained that the API was
  wrong and no complaints were received. (At least I don't recall any.)

- It adds unnecessary complexity to the 8.5.x code.

- I like deleting code ;)

Thoughts?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org