[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1291438441 Awesome, thanks much for the feedback! It's a much better PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1289917738 All done here @aooohan. Let me know if there's anything else you'd like changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1289903755 Great, I'll make those changes! > BTW, for the use of migrators, I believe that a task should correspond to a migrator, rather than one migrator being used repeatedly to handle multiple tasks. Oh, I totally agree. Just wanted to make sure I clarified the intent :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1288624526 The migrator was stateless in terms of the result, so I figured that was a goal, which is why I went with method returns. Would this method throw if execute() hasn't yet been called? What should happen if execute() is called more than once for a given instance of the migrator? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
