[GitHub] tomcat pull request #132: Fix cygpath error by adding cond check with JAVA_E...

2018-11-12 Thread markt-asf
Github user markt-asf closed the pull request at:

https://github.com/apache/tomcat/pull/132


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat pull request #132: Fix cygpath error by adding cond check with JAVA_E...

2018-11-10 Thread zemian
GitHub user zemian opened a pull request:

https://github.com/apache/tomcat/pull/132

Fix cygpath error by adding cond check with JAVA_ENDORSED_DIRS

The new `bin/tool-wrapper.sh` script gives the error `cygpath: can't 
convert empty path` when used in Cygwin shell. This is due to 
`JAVA_ENDORSED_DIRS` was converted even when it's empty.

This PR fixes the error by checking if `JAVA_ENDORSED_DIRS` is not empty 
first.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zemian/tomcat zemian-cygpath-error

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 7d71bb72e64ac5a9e167f2ad71eb44a7183e2d1a
Author: Zemian Deng 
Date:   2018-11-11T00:15:50Z

Fix cygpath error by adding cond check with JAVA_ENDORSED_DIRS




---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org