Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-21 Thread Mark Thomas
On 17/11/2019 19:01, Mark Thomas wrote: > The proposed 8.5.49 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.49 Unit tests pass for NIO, NIO2 and APR/Native (1.2.23) on Linux, Windows and MacOS. Mark

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-20 Thread Mark Thomas
On 20/11/2019 14:03, Konstantin Kolinko wrote: > вт, 19 нояб. 2019 г. в 19:58, Mark Thomas : >> >> On 19/11/2019 00:44, Konstantin Kolinko wrote: >>> вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : >>> >>> I think the single pollset change should not be backported to Tomcat 7. >>> I am OK with it

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-20 Thread Konstantin Kolinko
вт, 19 нояб. 2019 г. в 19:58, Mark Thomas : > > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : > > > > I think the single pollset change should not be backported to Tomcat 7. > > I am OK with it being backported to Tomcat 8.5. > > In favour of

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-19 Thread Mark Thomas
On 19/11/2019 19:29, Rémy Maucherat wrote: > On Tue, Nov 19, 2019 at 5:58 PM Mark Thomas > wrote: > > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > I think the single pollset change should not be backported to > Tomcat 7. > > I am OK with it being

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-19 Thread Rémy Maucherat
On Tue, Nov 19, 2019 at 5:58 PM Mark Thomas wrote: > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : > >> > >> On 18/11/2019 22:01, Rémy Maucherat wrote: > >>> On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas >>> > wrote: > >>

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-19 Thread Mark Thomas
On 19/11/2019 00:44, Konstantin Kolinko wrote: > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : >> >> On 18/11/2019 22:01, Rémy Maucherat wrote: >>> On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas >> > wrote: >> >>> Is porting the multipoller removal to 7.0 really doable ? >> >>

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Konstantin Kolinko
вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : > > On 18/11/2019 22:01, Rémy Maucherat wrote: > > On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas > > wrote: > > > Is porting the multipoller removal to 7.0 really doable ? > > I don't know. I haven't looked at the code yet. I do

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Konstantin Kolinko
вт, 19 нояб. 2019 г. в 00:22, Mark Thomas : > > On 17/11/2019 19:01, Mark Thomas wrote: > > We have a regression affecting 8.5.x (and 7.0.x). > > The fix [1] for an issue raised on the users list [2] was incorrect and > creating a different issue [3]. > > There are two questions to address. > > a)

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Mark Thomas
On 18/11/2019 22:01, Rémy Maucherat wrote: > On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas > wrote: > > On 17/11/2019 19:01, Mark Thomas wrote: > > We have a regression affecting 8.5.x (and 7.0.x). > > The fix [1] for an issue raised on the users list [2]

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Rémy Maucherat
On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas wrote: > On 17/11/2019 19:01, Mark Thomas wrote: > > We have a regression affecting 8.5.x (and 7.0.x). > > The fix [1] for an issue raised on the users list [2] was incorrect and > creating a different issue [3]. > > There are two questions to

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Igal Sapir
On 11/18/2019 1:22 PM, Mark Thomas wrote: On 17/11/2019 19:01, Mark Thomas wrote: We have a regression affecting 8.5.x (and 7.0.x). The fix [1] for an issue raised on the users list [2] was incorrect and creating a different issue [3]. There are two questions to address. a) Do we cancel the

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Mark Thomas
On 17/11/2019 19:01, Mark Thomas wrote: We have a regression affecting 8.5.x (and 7.0.x). The fix [1] for an issue raised on the users list [2] was incorrect and creating a different issue [3]. There are two questions to address. a) Do we cancel the 8.5.49 release for this and roll a 8.5.50

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Coty Sutherland
On Sun, Nov 17, 2019 at 2:01 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.49 release is now available for voting. > > The major changes compared to the 8.5.47 release are: > > - Improvements to Async error handling > > - Stricter processing of HTTP headers when looking for specific

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Igal Sapir
On 11/17/2019 11:01 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.5.49 release is now available for voting. The proposed 8.5.49 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.49 Unit tests passed on Windows 10 and Ubuntu 18.04 Igal

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Rémy Maucherat
On Sun, Nov 17, 2019 at 8:01 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.49 release is now available for voting. > > The major changes compared to the 8.5.47 release are: > > - Improvements to Async error handling > > - Stricter processing of HTTP headers when looking for specific

[VOTE] Release Apache Tomcat 8.5.49

2019-11-17 Thread Mark Thomas
The proposed Apache Tomcat 8.5.49 release is now available for voting. The major changes compared to the 8.5.47 release are: - Improvements to Async error handling - Stricter processing of HTTP headers when looking for specific token values - Fix various issues that could lead to