Re: [VOTE] Release Apache Tomcat 8.5.81

2022-06-10 Thread Mark Thomas

On 08/06/2022 23:01, Christopher Schultz wrote:

The proposed 8.5.81 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.81 (stable)


Unit tests pass on Linux, Windows and MacOS

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.81

2022-06-09 Thread Christopher Schultz

All,

On 6/9/22 08:18, Christopher Schultz wrote:

All,

On 6/8/22 18:01, Christopher Schultz wrote:

The proposed Apache Tomcat 8.5.81 release is now available for voting.

The notable change compared to 8.5.80 (not released) is:

  - Fix regression that broke or unexpectedly modified some TLS
    configurations when running on a Java 8 JDK.

The notable changes compared to 8.5.79 are:

- Ensure that changes made to a request by the RemoteIPValve persist
   after the request is put into asynchronous mode.

- Correct a regression in the support added for encrypted PKCS#1
   formatted private keys in the previous release that broke support
   for unencrypted PKCS#1 formatted private keys.

- Increase the default buffer size for cluster messages from 43800
   to 65536 bytes. This is expected to improve performance for large
   messages when running on Linux based systems.

- When using TLS with non-blocking writes and the NIO connector,
   ensure that flushing the buffers attempts to empty all of the
   output buffers.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.81/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1380
The tag is:
https://github.com/apache/tomcat/tree/8.5.81/
2f283f89f49be662efa45af2c6a876d897159ddf

The proposed 8.5.81 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.81 (stable)


Works with a vanilla servlet-based application in a development 
environment (httpd-via-AJP).


Note: some unit tests fail, but it has been determined that Java 
1.8.0_292 does not have a fix required to be able to handle certain 
types of key encodings.


I will re-test with 1.8.0_333 which I believe has the necessary fixes.

Also note that osslsigncode has objected to the Windows Digital 
Signature on the .exe file. I believe this is a problem with a missing 
trust store that I've been unable to debug so far. Looking at the file 
and the signature, everything appears to be in order.


Details:

* Environment
*  Java (build): openjdk version "1.8.0_292" OpenJDK Runtime 
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit 
Server VM (build 25.292-b10, mixed mode)
*  Java (test): openjdk version "1.8.0_292" OpenJDK Runtime 
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit 
Server VM (build 25.292-b10, mixed mode)

*  OS:   Linux 5.10.0-14-amd64 x86_64
*  cc:   cc (Debian 10.2.1-6) 10.2.1 20210110
*  make: GNU Make 4.3
*  OpenSSL:  OpenSSL 1.1.1 11 Sep 2018
*  APR:  1.7.0
*
* Valid SHA-512 signature for apache-tomcat-8.5.81.zip
* Valid GPG signature for apache-tomcat-8.5.81.zip
* Valid SHA-512 signature for apache-tomcat-8.5.81.tar.gz
* Valid GPG signature for apache-tomcat-8.5.81.tar.gz
* Valid SHA-512 signature for apache-tomcat-8.5.81.exe
* Valid GPG signature for apache-tomcat-8.5.81.exe
* !! Invalid Windows Digital Signature for apache-tomcat-8.5.81.exe
* Valid SHA512 signature for apache-tomcat-8.5.81-src.zip
* Valid GPG signature for apache-tomcat-8.5.81-src.zip
* Valid SHA512 signature for apache-tomcat-8.5.81-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.81-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.tomcat.util.net.jsse.TestPEMFile.APR.txt
* org.apache.tomcat.util.net.jsse.TestPEMFile.NIO.txt
* org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt


Yes, the unit tests all pass when using 1.8.0_333.

Details:

* Environment
*  Java (build): java version "1.8.0_333" Java(TM) SE Runtime 
Environment (build 1.8.0_333-b02) Java HotSpot(TM) 64-Bit Server VM 
(build 25.333-b02, mixed mode)
*  Java (test): java version "1.8.0_333" Java(TM) SE Runtime 
Environment (build 1.8.0_333-b02) Java HotSpot(TM) 64-Bit Server VM 
(build 25.333-b02, mixed mode)

*  OS:   Linux 5.10.0-14-amd64 x86_64
*  cc:   cc (Debian 10.2.1-6) 10.2.1 20210110
*  make: GNU Make 4.3
*  OpenSSL:  OpenSSL 1.1.1 11 Sep 2018
*  APR:  1.7.0
*
* Valid SHA-512 signature for apache-tomcat-8.5.81.zip
* Valid GPG signature for apache-tomcat-8.5.81.zip
* Valid SHA-512 signature for apache-tomcat-8.5.81.tar.gz
* Valid GPG signature for apache-tomcat-8.5.81.tar.gz
* Valid SHA-512 signature for apache-tomcat-8.5.81.exe
* Valid GPG signature for apache-tomcat-8.5.81.exe
* !! Invalid Windows Digital Signature for apache-tomcat-8.5.81.exe
* Valid SHA512 signature for apache-tomcat-8.5.81-src.zip
* Valid GPG signature for apache-tomcat-8.5.81-src.zip
* Valid SHA512 signature for apache-tomcat-8.5.81-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.81-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and 

Re: [VOTE] Release Apache Tomcat 8.5.81

2022-06-09 Thread Christopher Schultz

All,

On 6/8/22 18:01, Christopher Schultz wrote:

The proposed Apache Tomcat 8.5.81 release is now available for voting.

The notable change compared to 8.5.80 (not released) is:

  - Fix regression that broke or unexpectedly modified some TLS
    configurations when running on a Java 8 JDK.

The notable changes compared to 8.5.79 are:

- Ensure that changes made to a request by the RemoteIPValve persist
   after the request is put into asynchronous mode.

- Correct a regression in the support added for encrypted PKCS#1
   formatted private keys in the previous release that broke support
   for unencrypted PKCS#1 formatted private keys.

- Increase the default buffer size for cluster messages from 43800
   to 65536 bytes. This is expected to improve performance for large
   messages when running on Linux based systems.

- When using TLS with non-blocking writes and the NIO connector,
   ensure that flushing the buffers attempts to empty all of the
   output buffers.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.81/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1380
The tag is:
https://github.com/apache/tomcat/tree/8.5.81/
2f283f89f49be662efa45af2c6a876d897159ddf

The proposed 8.5.81 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.81 (stable)


Works with a vanilla servlet-based application in a development 
environment (httpd-via-AJP).


Note: some unit tests fail, but it has been determined that Java 
1.8.0_292 does not have a fix required to be able to handle certain 
types of key encodings.


I will re-test with 1.8.0_333 which I believe has the necessary fixes.

Also note that osslsigncode has objected to the Windows Digital 
Signature on the .exe file. I believe this is a problem with a missing 
trust store that I've been unable to debug so far. Looking at the file 
and the signature, everything appears to be in order.


Details:

* Environment
*  Java (build): openjdk version "1.8.0_292" OpenJDK Runtime 
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit 
Server VM (build 25.292-b10, mixed mode)
*  Java (test): openjdk version "1.8.0_292" OpenJDK Runtime 
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit 
Server VM (build 25.292-b10, mixed mode)

*  OS:   Linux 5.10.0-14-amd64 x86_64
*  cc:   cc (Debian 10.2.1-6) 10.2.1 20210110
*  make: GNU Make 4.3
*  OpenSSL:  OpenSSL 1.1.1 11 Sep 2018
*  APR:  1.7.0
*
* Valid SHA-512 signature for apache-tomcat-8.5.81.zip
* Valid GPG signature for apache-tomcat-8.5.81.zip
* Valid SHA-512 signature for apache-tomcat-8.5.81.tar.gz
* Valid GPG signature for apache-tomcat-8.5.81.tar.gz
* Valid SHA-512 signature for apache-tomcat-8.5.81.exe
* Valid GPG signature for apache-tomcat-8.5.81.exe
* !! Invalid Windows Digital Signature for apache-tomcat-8.5.81.exe
* Valid SHA512 signature for apache-tomcat-8.5.81-src.zip
* Valid GPG signature for apache-tomcat-8.5.81-src.zip
* Valid SHA512 signature for apache-tomcat-8.5.81-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.81-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.tomcat.util.net.jsse.TestPEMFile.APR.txt
* org.apache.tomcat.util.net.jsse.TestPEMFile.NIO.txt
* org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.81

2022-06-09 Thread Rémy Maucherat
On Thu, Jun 9, 2022 at 12:03 AM Christopher Schultz
 wrote:
>
> The proposed Apache Tomcat 8.5.81 release is now available for voting.
>
> The notable change compared to 8.5.80 (not released) is:
>
>   - Fix regression that broke or unexpectedly modified some TLS
> configurations when running on a Java 8 JDK.
>
> The notable changes compared to 8.5.79 are:
>
> - Ensure that changes made to a request by the RemoteIPValve persist
>after the request is put into asynchronous mode.
>
> - Correct a regression in the support added for encrypted PKCS#1
>formatted private keys in the previous release that broke support
>for unencrypted PKCS#1 formatted private keys.
>
> - Increase the default buffer size for cluster messages from 43800
>to 65536 bytes. This is expected to improve performance for large
>messages when running on Linux based systems.
>
> - When using TLS with non-blocking writes and the NIO connector,
>ensure that flushing the buffers attempts to empty all of the
>output buffers.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.81/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1380
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.81/
> 2f283f89f49be662efa45af2c6a876d897159ddf
>
> The proposed 8.5.81 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.81 (stable)

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Apache Tomcat 8.5.81

2022-06-08 Thread Christopher Schultz

The proposed Apache Tomcat 8.5.81 release is now available for voting.

The notable change compared to 8.5.80 (not released) is:

 - Fix regression that broke or unexpectedly modified some TLS
   configurations when running on a Java 8 JDK.

The notable changes compared to 8.5.79 are:

- Ensure that changes made to a request by the RemoteIPValve persist
  after the request is put into asynchronous mode.

- Correct a regression in the support added for encrypted PKCS#1
  formatted private keys in the previous release that broke support
  for unencrypted PKCS#1 formatted private keys.

- Increase the default buffer size for cluster messages from 43800
  to 65536 bytes. This is expected to improve performance for large
  messages when running on Linux based systems.

- When using TLS with non-blocking writes and the NIO connector,
  ensure that flushing the buffers attempts to empty all of the
  output buffers.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.81/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1380
The tag is:
https://github.com/apache/tomcat/tree/8.5.81/
2f283f89f49be662efa45af2c6a876d897159ddf

The proposed 8.5.81 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.81 (stable)

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org