Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
Oh thank goodness! I was worried!

Sincerely,
- Ray

On Tue, Jun 23, 2020 at 5:19 PM Filip Hanik  wrote:

>
> On 6/23/20 1:58 PM, Raymond Auge wrote:
>
> Further review of your error seems to indicate you are not using the
> specified version of bnd. Have you overridden this in your build.properties
> file?
>
> The regex in bnd 5.1.1 release is
> `((\(|\[)\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?,\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?(\]|\)))|\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?`
>
>
> Thank you Ray, that was it!
>
> Filip
>
>
>
> - Ray
>
> On Tue, Jun 23, 2020 at 4:05 PM Raymond Auge 
> wrote:
>
>>
>>
>>
>> On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik  wrote:
>>>>
>>>>> cd res/maven
>>>>>
>>>> ant -f mvn-pub.xml generic-install
>>>>>
>>>>
>>>>
>> I also ran this in the HEAD 9.0.x branch before your change
>> (919183b438e1a2f0004082c69e34accc0c3e2f16) without error.
>>
>> - Ray
>>
>>
>>> I usually run
>>>>
>>>> ant clean deploy  embed
>>>>
>>>> Also I've added github actions build at least in my master fork that
>>>> you can see is building on ubuntu and windows here
>>>> https://github.com/rotty3000/tomcat/actions/runs/145316145
>>>>
>>>> I'll test the instructions you've given next.
>>>>
>>>> - ray
>>>>
>>>>
>>>>> Is that last command working for you?
>>>>>
>>>>> The error I'm getting is:
>>>>>
>>>>> package:
>>>>>   [jar] Building jar:
>>>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>>>>
>>>>> add-osgi:
>>>>>  [echo] add-osgi
>>>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>>>> true
>>>>>   [bnd] 1 ERRORS
>>>>>   [bnd]  Invalid value for Bundle-Version,
>>>>> ${version_cleanup;9.0.0-native-image-dev} does not match
>>>>> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>>>>>   [bnd]
>>>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd:
>>>>> bnd failed
>>>>>   [bnd] at
>>>>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>>>>>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>>>>>   [bnd] at
>>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>>>
>>>>> Filip
>>>>>
>>>>>
>>>>> - Ray
>>>>>
>>>>> On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik  wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> *From:* Raymond Auge 
>>>>>> *Sent:* Tuesday, June 23, 2020 12:17 PM
>>>>>> *To:* Tomcat Developers List 
>>>>>> *Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling
>>>>>> error
>>>>>>
>>>>>>
>>>>>>
>>>>>> k, so travis config is borked.. I should add github actions.
>>>>>>
>>>>>>
>>>>>>
>>>>>> I don’t think Travis tests artifact generation
>>>>>>
>>>>>>
>>>>>>
>>>>>> - Ray
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge <
>>>>>> raymond.a...@liferay.com> wrote:
>>>>>>
>>>>>> 
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>>>  (@rotty3000)
>>>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>>>>  (@Liferay)
>>>>>
>>>>>
>>>>
>>>> --
>>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>>  (@rotty3000)
>>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>>>  (@Liferay)
>>>>
>>>
>>>
>>> --
>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>  (@rotty3000)
>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>>  (@Liferay)
>>>
>>
>>
>> --
>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>  (@rotty3000)
>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>  (@Liferay)
>>
>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>  (@Liferay)
>
>

-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik


On 6/23/20 1:58 PM, Raymond Auge wrote:
Further review of your error seems to indicate you are not using the 
specified version of bnd. Have you overridden this in your 
build.properties file?


The regex in bnd 5.1.1 release is 
`((\(|\[)\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?,\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?(\]|\)))|\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?`



Thank you Ray, that was it!

Filip




- Ray

On Tue, Jun 23, 2020 at 4:05 PM Raymond Auge <mailto:raymond.a...@liferay.com>> wrote:





On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik
mailto:fi...@hanik.com>> wrote:

cd res/maven

ant -f mvn-pub.xml generic-install



I also ran this in the HEAD 9.0.x branch before your change
(919183b438e1a2f0004082c69e34accc0c3e2f16) without error.

- Ray

I usually run

ant clean deploy  embed

Also I've added github actions build at least in my master
fork that you can see is building on ubuntu and windows
here
https://github.com/rotty3000/tomcat/actions/runs/145316145

I'll test the instructions you've given next.

- ray

Is that last command working for you?

The error I'm getting is:

package:
  [jar] Building jar:

/development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar

add-osgi:
 [echo] add-osgi

/development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
true
  [bnd] 1 ERRORS
  [bnd]  Invalid value for Bundle-Version,
${version_cleanup;9.0.0-native-image-dev} does not
match
[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
  [bnd]

/development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd:
bnd failed
  [bnd] at

aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
  [bnd] at
aQute.bnd.ant.BndTask.execute(BndTask.java:119)
  [bnd] at

org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)

Filip



- Ray

On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik
mailto:fha...@vmware.com>> wrote:

*From:* Raymond Auge mailto:raymond.a...@liferay.com>>
*Sent:* Tuesday, June 23, 2020 12:17 PM
*To:* Tomcat Developers List
mailto:dev@tomcat.apache.org>>
            *Subject:* Re: [tomcat] branch 9.0.x updated:
    Fixes OSGI bundling error

k, so travis config is borked.. I should add
github actions.

*//*

I don’t think Travis tests artifact generation

- Ray

On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge
mailto:raymond.a...@liferay.com>> wrote:





-- 
*Raymond Augé*

<http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)

Senior Software Architect *Liferay, Inc.*
<http://www.liferay.com> (@Liferay)




-- 
*Raymond Augé*

<http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)

Senior Software Architect *Liferay, Inc.*
<http://www.liferay.com> (@Liferay)



-- 
*Raymond Augé*

<http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)
Senior Software Architect *Liferay, Inc.*
<http://www.liferay.com> (@Liferay)



-- 
*Raymond Augé*

<http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)
Senior Software Architect *Liferay, Inc.*
<http://www.liferay.com> (@Liferay)



--
*Raymond Augé* 
<http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)
Senior Software Architect *Liferay, Inc.* 
<http://www.liferay.com> (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
Further review of your error seems to indicate you are not using the
specified version of bnd. Have you overridden this in your build.properties
file?

The regex in bnd 5.1.1 release is
`((\(|\[)\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?,\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?(\]|\)))|\d{1,9}(\.\d{1,9}(\.\d{1,9}(\.[-\w]+)?)?)?`

- Ray

On Tue, Jun 23, 2020 at 4:05 PM Raymond Auge 
wrote:

>
>
>
> On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik  wrote:
>>>
>>>> cd res/maven
>>>>
>>> ant -f mvn-pub.xml generic-install
>>>>
>>>
>>>
> I also ran this in the HEAD 9.0.x branch before your change
> (919183b438e1a2f0004082c69e34accc0c3e2f16) without error.
>
> - Ray
>
>
>> I usually run
>>>
>>> ant clean deploy  embed
>>>
>>> Also I've added github actions build at least in my master fork that you
>>> can see is building on ubuntu and windows here
>>> https://github.com/rotty3000/tomcat/actions/runs/145316145
>>>
>>> I'll test the instructions you've given next.
>>>
>>> - ray
>>>
>>>
>>>> Is that last command working for you?
>>>>
>>>> The error I'm getting is:
>>>>
>>>> package:
>>>>   [jar] Building jar:
>>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>>>
>>>> add-osgi:
>>>>  [echo] add-osgi
>>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>>> true
>>>>   [bnd] 1 ERRORS
>>>>   [bnd]  Invalid value for Bundle-Version,
>>>> ${version_cleanup;9.0.0-native-image-dev} does not match
>>>> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>>>>   [bnd]
>>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd:
>>>> bnd failed
>>>>   [bnd] at
>>>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>>>>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>>>>   [bnd] at
>>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>>
>>>> Filip
>>>>
>>>>
>>>> - Ray
>>>>
>>>> On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik  wrote:
>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> *From:* Raymond Auge 
>>>>> *Sent:* Tuesday, June 23, 2020 12:17 PM
>>>>> *To:* Tomcat Developers List 
>>>>> *Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling
>>>>> error
>>>>>
>>>>>
>>>>>
>>>>> k, so travis config is borked.. I should add github actions.
>>>>>
>>>>>
>>>>>
>>>>> I don’t think Travis tests artifact generation
>>>>>
>>>>>
>>>>>
>>>>> - Ray
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
>>>>> wrote:
>>>>>
>>>>> 
>>>>>
>>>>
>>>>
>>>> --
>>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>>  (@rotty3000)
>>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>>>  (@Liferay)
>>>>
>>>>
>>>
>>> --
>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>  (@rotty3000)
>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>>  (@Liferay)
>>>
>>
>>
>> --
>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>  (@rotty3000)
>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>  (@Liferay)
>>
>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>  (@Liferay)
>


-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik  wrote:
>>
>>> cd res/maven
>>>
>> ant -f mvn-pub.xml generic-install
>>>
>>
>>
I also ran this in the HEAD 9.0.x branch before your change
(919183b438e1a2f0004082c69e34accc0c3e2f16) without error.

- Ray


> I usually run
>>
>> ant clean deploy  embed
>>
>> Also I've added github actions build at least in my master fork that you
>> can see is building on ubuntu and windows here
>> https://github.com/rotty3000/tomcat/actions/runs/145316145
>>
>> I'll test the instructions you've given next.
>>
>> - ray
>>
>>
>>> Is that last command working for you?
>>>
>>> The error I'm getting is:
>>>
>>> package:
>>>   [jar] Building jar:
>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>>
>>> add-osgi:
>>>  [echo] add-osgi
>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>> true
>>>   [bnd] 1 ERRORS
>>>   [bnd]  Invalid value for Bundle-Version,
>>> ${version_cleanup;9.0.0-native-image-dev} does not match
>>> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>>>   [bnd]
>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd:
>>> bnd failed
>>>   [bnd] at
>>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>>>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>>>       [bnd] at
>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>
>>> Filip
>>>
>>>
>>> - Ray
>>>
>>> On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik  wrote:
>>>
>>>>
>>>>
>>>>
>>>>
>>>> *From:* Raymond Auge 
>>>> *Sent:* Tuesday, June 23, 2020 12:17 PM
>>>> *To:* Tomcat Developers List 
>>>> *Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error
>>>>
>>>>
>>>>
>>>> k, so travis config is borked.. I should add github actions.
>>>>
>>>>
>>>>
>>>> I don’t think Travis tests artifact generation
>>>>
>>>>
>>>>
>>>> - Ray
>>>>
>>>>
>>>>
>>>> On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
>>>> wrote:
>>>>
>>>> 
>>>>
>>>
>>>
>>> --
>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>>  (@rotty3000)
>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>>  (@Liferay)
>>>
>>>
>>
>> --
>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>  (@rotty3000)
>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>  (@Liferay)
>>
>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>  (@Liferay)
>


-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:57 PM Raymond Auge 
wrote:

>
>
> On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik  wrote:
>
>>
>> On 6/23/20 12:38 PM, Raymond Auge wrote:
>>
>> `ant test` transitively invokes `deploy` target which builds the
>> artifacts.
>>
>> You'll want to run the following commands that are currently failing for
>> me
>>
>> ant clean
>> ant
>> ant test-compile
>> ant embed
>>
> FYI

ant (alone) is just ant deploy so to save yourself some time just invoke
all those in one go:

ant clean deploy test-compile embed

- Ray


>
>> cd res/maven
>> ant -f mvn-pub.xml generic-install
>>
>
> I usually run
>
> ant clean deploy  embed
>
> Also I've added github actions build at least in my master fork that you
> can see is building on ubuntu and windows here
> https://github.com/rotty3000/tomcat/actions/runs/145316145
>
> I'll test the instructions you've given next.
>
> - ray
>
>
>> Is that last command working for you?
>>
>> The error I'm getting is:
>>
>> package:
>>   [jar] Building jar:
>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>>
>> add-osgi:
>>  [echo] add-osgi
>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>> true
>>   [bnd] 1 ERRORS
>>   [bnd]  Invalid value for Bundle-Version,
>> ${version_cleanup;9.0.0-native-image-dev} does not match
>> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>>   [bnd]
>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd:
>> bnd failed
>>   [bnd] at
>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>>   [bnd]     at
>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>
>> Filip
>>
>>
>> - Ray
>>
>> On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik  wrote:
>>
>>>
>>>
>>>
>>>
>>> *From:* Raymond Auge 
>>> *Sent:* Tuesday, June 23, 2020 12:17 PM
>>> *To:* Tomcat Developers List 
>>> *Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error
>>>
>>>
>>>
>>> k, so travis config is borked.. I should add github actions.
>>>
>>>
>>>
>>> I don’t think Travis tests artifact generation
>>>
>>>
>>>
>>> - Ray
>>>
>>>
>>>
>>> On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
>>> wrote:
>>>
>>> 
>>>
>>
>>
>> --
>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>>  (@rotty3000)
>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>>  (@Liferay)
>>
>>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>  (@Liferay)
>


-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:45 PM Filip Hanik  wrote:

>
> On 6/23/20 12:38 PM, Raymond Auge wrote:
>
> `ant test` transitively invokes `deploy` target which builds the artifacts.
>
> You'll want to run the following commands that are currently failing for me
>
> ant clean
> ant
> ant test-compile
> ant embed
>
> cd res/maven
> ant -f mvn-pub.xml generic-install
>

I usually run

ant clean deploy embed

Also I've added github actions build at least in my master fork that you
can see is building on ubuntu and windows here
https://github.com/rotty3000/tomcat/actions/runs/145316145

I'll test the instructions you've given next.

- ray


> Is that last command working for you?
>
> The error I'm getting is:
>
> package:
>   [jar] Building jar:
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
>
> add-osgi:
>  [echo] add-osgi
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar
> true
>   [bnd] 1 ERRORS
>   [bnd]  Invalid value for Bundle-Version,
> ${version_cleanup;9.0.0-native-image-dev} does not match
> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>   [bnd]
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd:
> bnd failed
>   [bnd] at
> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>   [bnd] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>
> Filip
>
>
> - Ray
>
> On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik  wrote:
>
>>
>>
>>
>>
>> *From:* Raymond Auge 
>> *Sent:* Tuesday, June 23, 2020 12:17 PM
>> *To:* Tomcat Developers List 
>> *Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error
>>
>>
>>
>> k, so travis config is borked.. I should add github actions.
>>
>>
>>
>> I don’t think Travis tests artifact generation
>>
>>
>>
>> - Ray
>>
>>
>>
>> On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
>> wrote:
>>
>> 
>>
>
>
> --
> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
>  (@rotty3000)
> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
>  (@Liferay)
>
>

-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik


On 6/23/20 12:38 PM, Raymond Auge wrote:
`ant test` transitively invokes `deploy` target which builds the 
artifacts.


You'll want to run the following commands that are currently failing for me

ant clean
ant
ant test-compile
ant embed

cd res/maven
ant -f mvn-pub.xml generic-install

Is that last command working for you?

The error I'm getting is:

package:
  [jar] Building jar: 
/development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar


add-osgi:
 [echo] add-osgi 
/development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/output/build/lib/annotations-api.jar 
true

  [bnd] 1 ERRORS
  [bnd]  Invalid value for Bundle-Version, 
${version_cleanup;9.0.0-native-image-dev} does not match 
[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
  [bnd] 
/development/pivotal/cloudfoundry/spring-projects/graal/tomcat10/res/bnd/annotations-api.jar.tmp.bnd: 
bnd failed
  [bnd] at 
aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)

  [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
  [bnd] at 
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)


Filip



- Ray

On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik <mailto:fha...@vmware.com>> wrote:


*From:* Raymond Auge mailto:raymond.a...@liferay.com>>
*Sent:* Tuesday, June 23, 2020 12:17 PM
*To:* Tomcat Developers List mailto:dev@tomcat.apache.org>>
*Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling
error

k, so travis config is borked.. I should add github actions.

*//*

I don’t think Travis tests artifact generation

- Ray

On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge
mailto:raymond.a...@liferay.com>> wrote:





--
*Raymond Augé* 
<http://www.liferay.com/web/raymond.auge/profile> (@rotty3000)
Senior Software Architect *Liferay, Inc.* 
<http://www.liferay.com> (@Liferay)


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
`ant test` transitively invokes `deploy` target which builds the artifacts.

- Ray

On Tue, Jun 23, 2020 at 3:21 PM Filip Hanik  wrote:

>
>
>
>
> *From:* Raymond Auge 
> *Sent:* Tuesday, June 23, 2020 12:17 PM
> *To:* Tomcat Developers List 
> *Subject:* Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error
>
>
>
> k, so travis config is borked.. I should add github actions.
>
>
>
> I don’t think Travis tests artifact generation
>
>
>
> - Ray
>
>
>
> On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
> wrote:
>
> 
>


-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)


RE: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik


From: Raymond Auge 
Sent: Tuesday, June 23, 2020 12:17 PM
To: Tomcat Developers List 
Subject: Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

k, so travis config is borked.. I should add github actions.

I don’t think Travis tests artifact generation

- Ray

On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
mailto:raymond.a...@liferay.com>> wrote:



Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
k, so travis config is borked.. I should add github actions.

- Ray

On Tue, Jun 23, 2020 at 3:13 PM Raymond Auge 
wrote:

>
>
> On Tue, Jun 23, 2020 at 3:09 PM Raymond Auge 
> wrote:
>
>> Also, at the root of 9.0.x I hard coded the value of:
>>
>
> of course I meant HEAD (caed3194b48ccbbac0572417b0e60807683a8690)
>
> I'm not sure what you're missing. But it builds in CI does it not?
>
> - Ray
>
>
>>
>> Bundle-Version: ${version_cleanup;9.0.0-native-image-dev}
>>
>> and the result was no error and bundles have:
>>
>> Bundle-Version: 9.0.0.native-image-dev
>>
>> - Ray
>>
>> On Tue, Jun 23, 2020 at 3:02 PM Raymond Auge 
>> wrote:
>>
>>> See https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
>>>
>>> On Tue, Jun 23, 2020 at 2:57 PM Raymond Auge 
>>> wrote:
>>>
 This is not a good fix. This is the same problem we had before with
 incompatible version syntax in OSGi.

 - Ray

 On Tue, Jun 23, 2020 at 2:54 PM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> fhanik pushed a commit to branch 9.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/9.0.x by this push:
>  new caed319  Fixes OSGI bundling error
> caed319 is described below
>
> commit caed3194b48ccbbac0572417b0e60807683a8690
> Author: Filip Hanik 
> AuthorDate: Tue Jun 23 11:53:08 2020 -0700
>
> Fixes OSGI bundling error
>
> add-osgi:
>  [echo] add-osgi
>
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/output/build/lib/annotations-api.jar
> true
>   [bnd] 1 ERRORS
>   [bnd]  Invalid value for Bundle-Version,
> ${version_cleanup;9.0.0-native-image-dev} does not match
> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>   [bnd]
>
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/res/bnd/annotations-api.jar.tmp.bnd:
> bnd failed
>   [bnd] at
> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>   [bnd] at
>
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at
> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>   [bnd] at
> org.apache.tools.ant.Target.execute(Target.java:449)
>   [bnd] at
> org.apache.tools.ant.Target.performTasks(Target.java:470)
>   [bnd] at
>
> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
>   [bnd] at
>
> org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36)
>   [bnd] at
> org.apache.tools.ant.Project.executeTargets(Project.java:1254)
>   [bnd] at
> org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437)
>   [bnd] at
>
> org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106)
>   [bnd] at
>
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at
> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>   [bnd] at java.util.Vector.forEach(Vector.java:1249)
>   [bnd] at
>
> org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
>   [bnd] at
>
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at
> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at 

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
On Tue, Jun 23, 2020 at 3:09 PM Raymond Auge 
wrote:

> Also, at the root of 9.0.x I hard coded the value of:
>

of course I meant HEAD (caed3194b48ccbbac0572417b0e60807683a8690)

I'm not sure what you're missing. But it builds in CI does it not?

- Ray


>
> Bundle-Version: ${version_cleanup;9.0.0-native-image-dev}
>
> and the result was no error and bundles have:
>
> Bundle-Version: 9.0.0.native-image-dev
>
> - Ray
>
> On Tue, Jun 23, 2020 at 3:02 PM Raymond Auge 
> wrote:
>
>> See https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
>>
>> On Tue, Jun 23, 2020 at 2:57 PM Raymond Auge 
>> wrote:
>>
>>> This is not a good fix. This is the same problem we had before with
>>> incompatible version syntax in OSGi.
>>>
>>> - Ray
>>>
>>> On Tue, Jun 23, 2020 at 2:54 PM  wrote:
>>>
 This is an automated email from the ASF dual-hosted git repository.

 fhanik pushed a commit to branch 9.0.x
 in repository https://gitbox.apache.org/repos/asf/tomcat.git


 The following commit(s) were added to refs/heads/9.0.x by this push:
  new caed319  Fixes OSGI bundling error
 caed319 is described below

 commit caed3194b48ccbbac0572417b0e60807683a8690
 Author: Filip Hanik 
 AuthorDate: Tue Jun 23 11:53:08 2020 -0700

 Fixes OSGI bundling error

 add-osgi:
  [echo] add-osgi

 /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/output/build/lib/annotations-api.jar
 true
   [bnd] 1 ERRORS
   [bnd]  Invalid value for Bundle-Version,
 ${version_cleanup;9.0.0-native-image-dev} does not match
 [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
   [bnd]

 /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/res/bnd/annotations-api.jar.tmp.bnd:
 bnd failed
   [bnd] at
 aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
   [bnd] at
 org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
   [bnd] at
 sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
 Source)
   [bnd] at

 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
   [bnd] at

 org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
   [bnd] at
 org.apache.tools.ant.Target.execute(Target.java:449)
   [bnd] at
 org.apache.tools.ant.Target.performTasks(Target.java:470)
   [bnd] at
 org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
   [bnd] at

 org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36)
   [bnd] at
 org.apache.tools.ant.Project.executeTargets(Project.java:1254)
   [bnd] at
 org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437)
   [bnd] at

 org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106)
   [bnd] at
 org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
   [bnd] at
 sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
 Source)
   [bnd] at

 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
   [bnd] at

 org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
   [bnd] at java.util.Vector.forEach(Vector.java:1249)
   [bnd] at
 org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
   [bnd] at
 org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
   [bnd] at
 sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
 Source)
   [bnd] at

 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
   [bnd] at

 org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
   [bnd] at

 org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:391)
   [bnd] at
 org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
   [bnd] at
 

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
Also, at the root of 9.0.x I hard coded the value of:

Bundle-Version: ${version_cleanup;9.0.0-native-image-dev}

and the result was no error and bundles have:

Bundle-Version: 9.0.0.native-image-dev

- Ray

On Tue, Jun 23, 2020 at 3:02 PM Raymond Auge 
wrote:

> See https://bz.apache.org/bugzilla/show_bug.cgi?id=64498
>
> On Tue, Jun 23, 2020 at 2:57 PM Raymond Auge 
> wrote:
>
>> This is not a good fix. This is the same problem we had before with
>> incompatible version syntax in OSGi.
>>
>> - Ray
>>
>> On Tue, Jun 23, 2020 at 2:54 PM  wrote:
>>
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> fhanik pushed a commit to branch 9.0.x
>>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/9.0.x by this push:
>>>  new caed319  Fixes OSGI bundling error
>>> caed319 is described below
>>>
>>> commit caed3194b48ccbbac0572417b0e60807683a8690
>>> Author: Filip Hanik 
>>> AuthorDate: Tue Jun 23 11:53:08 2020 -0700
>>>
>>> Fixes OSGI bundling error
>>>
>>> add-osgi:
>>>  [echo] add-osgi
>>>
>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/output/build/lib/annotations-api.jar
>>> true
>>>   [bnd] 1 ERRORS
>>>   [bnd]  Invalid value for Bundle-Version,
>>> ${version_cleanup;9.0.0-native-image-dev} does not match
>>> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>>>   [bnd]
>>>
>>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/res/bnd/annotations-api.jar.tmp.bnd:
>>> bnd failed
>>>   [bnd] at
>>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>>>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>>>   [bnd] at
>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>   [bnd] at
>>> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>>> Source)
>>>   [bnd] at
>>>
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>>   [bnd] at
>>>
>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>>   [bnd] at
>>> org.apache.tools.ant.Target.execute(Target.java:449)
>>>   [bnd] at
>>> org.apache.tools.ant.Target.performTasks(Target.java:470)
>>>   [bnd] at
>>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
>>>   [bnd] at
>>>
>>> org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36)
>>>   [bnd] at
>>> org.apache.tools.ant.Project.executeTargets(Project.java:1254)
>>>   [bnd] at
>>> org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437)
>>>   [bnd] at
>>> org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106)
>>>   [bnd] at
>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>   [bnd] at
>>> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>>> Source)
>>>   [bnd] at
>>>
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>>   [bnd] at
>>>
>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>>   [bnd] at java.util.Vector.forEach(Vector.java:1249)
>>>   [bnd] at
>>> org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
>>>   [bnd] at
>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>   [bnd] at
>>> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>>> Source)
>>>   [bnd] at
>>>
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>>   [bnd] at
>>>
>>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>>   [bnd] at
>>>
>>> org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:391)
>>>   [bnd] at
>>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>>   [bnd] at
>>> sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>>> Source)
>>>   [bnd] at
>>>
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>>   [bnd] at
>>>
>>> 

RE: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Filip Hanik


From: Raymond Auge 
Sent: Tuesday, June 23, 2020 11:58 AM
To: Tomcat Developers List 
Subject: Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

This is not a good fix. This is the same problem we had before with 
incompatible version syntax in OSGi

- Ray


Hi Ray, I can’t even build the libraries with your commit. What am I missing?


Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
See https://bz.apache.org/bugzilla/show_bug.cgi?id=64498

On Tue, Jun 23, 2020 at 2:57 PM Raymond Auge 
wrote:

> This is not a good fix. This is the same problem we had before with
> incompatible version syntax in OSGi.
>
> - Ray
>
> On Tue, Jun 23, 2020 at 2:54 PM  wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> fhanik pushed a commit to branch 9.0.x
>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>
>>
>> The following commit(s) were added to refs/heads/9.0.x by this push:
>>  new caed319  Fixes OSGI bundling error
>> caed319 is described below
>>
>> commit caed3194b48ccbbac0572417b0e60807683a8690
>> Author: Filip Hanik 
>> AuthorDate: Tue Jun 23 11:53:08 2020 -0700
>>
>> Fixes OSGI bundling error
>>
>> add-osgi:
>>  [echo] add-osgi
>>
>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/output/build/lib/annotations-api.jar
>> true
>>   [bnd] 1 ERRORS
>>   [bnd]  Invalid value for Bundle-Version,
>> ${version_cleanup;9.0.0-native-image-dev} does not match
>> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>>   [bnd]
>>
>> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/res/bnd/annotations-api.jar.tmp.bnd:
>> bnd failed
>>   [bnd] at
>> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>>   [bnd] at
>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>> Source)
>>   [bnd] at
>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>   [bnd] at
>>
>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>   [bnd] at
>> org.apache.tools.ant.Target.execute(Target.java:449)
>>   [bnd] at
>> org.apache.tools.ant.Target.performTasks(Target.java:470)
>>   [bnd] at
>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
>>   [bnd] at
>>
>> org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36)
>>   [bnd] at
>> org.apache.tools.ant.Project.executeTargets(Project.java:1254)
>>   [bnd] at
>> org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437)
>>   [bnd] at
>> org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106)
>>   [bnd] at
>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>> Source)
>>   [bnd] at
>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>   [bnd] at
>>
>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>   [bnd] at java.util.Vector.forEach(Vector.java:1249)
>>   [bnd] at
>> org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
>>   [bnd] at
>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>> Source)
>>   [bnd] at
>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>   [bnd] at
>>
>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>   [bnd] at
>>
>> org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:391)
>>   [bnd] at
>> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
>> Source)
>>   [bnd] at
>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>>   [bnd] at
>>
>> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>>   [bnd] at
>> org.apache.tools.ant.Target.execute(Target.java:449)
>>   [bnd] at
>> org.apache.tools.ant.Target.performTasks(Target.java:470)
>>   [bnd] at
>> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
>> 

Re: [tomcat] branch 9.0.x updated: Fixes OSGI bundling error

2020-06-23 Thread Raymond Auge
This is not a good fix. This is the same problem we had before with
incompatible version syntax in OSGi.

- Ray

On Tue, Jun 23, 2020 at 2:54 PM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> fhanik pushed a commit to branch 9.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/9.0.x by this push:
>  new caed319  Fixes OSGI bundling error
> caed319 is described below
>
> commit caed3194b48ccbbac0572417b0e60807683a8690
> Author: Filip Hanik 
> AuthorDate: Tue Jun 23 11:53:08 2020 -0700
>
> Fixes OSGI bundling error
>
> add-osgi:
>  [echo] add-osgi
>
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/output/build/lib/annotations-api.jar
> true
>   [bnd] 1 ERRORS
>   [bnd]  Invalid value for Bundle-Version,
> ${version_cleanup;9.0.0-native-image-dev} does not match
> [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
>   [bnd]
>
> /development/pivotal/cloudfoundry/spring-projects/graal/tomcat/res/bnd/annotations-api.jar.tmp.bnd:
> bnd failed
>   [bnd] at
> aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:240)
>   [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:119)
>   [bnd] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>   [bnd] at org.apache.tools.ant.Target.execute(Target.java:449)
>   [bnd] at
> org.apache.tools.ant.Target.performTasks(Target.java:470)
>   [bnd] at
> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
>   [bnd] at
>
> org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36)
>   [bnd] at
> org.apache.tools.ant.Project.executeTargets(Project.java:1254)
>   [bnd] at
> org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437)
>   [bnd] at
> org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106)
>   [bnd] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>   [bnd] at java.util.Vector.forEach(Vector.java:1249)
>   [bnd] at
> org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:67)
>   [bnd] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>   [bnd] at
>
> org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:391)
>   [bnd] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
>   [bnd] at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown
> Source)
>   [bnd] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   [bnd] at java.lang.reflect.Method.invoke(Method.java:498)
>   [bnd] at
>
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
>   [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
>   [bnd] at org.apache.tools.ant.Target.execute(Target.java:449)
>   [bnd] at
> org.apache.tools.ant.Target.performTasks(Target.java:470)
>   [bnd] at
> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391)
>   [bnd] at
> org.apache.tools.ant.Project.executeTarget(Project.java:1364)
>   [bnd] at
>
> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
>   [bnd] at
>