[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #11 from Christopher Schultz  ---
(In reply to harald.dunkel from comment #10)
> This is pretty disappointing. CATALINA_PID is part of the interface to
> manage tomcat.
> 
> Anyway, logging to stdout and stderr is an anachronism, even for Java. The
> recommendation should be to set CATALINA_OUT to /dev/null and to use log4j
> or similar.

And where do logs go before log4j(, etc.) is brought-up?

Note that Tomcat doesn't log anything to stdout or stderr. It uses a proper
logger through and through, which can be configured to go elsewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #10 from harald.dun...@aixigo.de ---
This is pretty disappointing. CATALINA_PID is part of the interface to manage
tomcat.

Anyway, logging to stdout and stderr is an anachronism, even for Java. The
recommendation should be to set CATALINA_OUT to /dev/null and to use log4j or
similar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #9 from Mark Thomas  ---
The breakage for systemd users is of greater impact to the community than the
lack of ability to pipe to a process.

Therefore, there having been no further input I am proceeding with option 2 and
closing this as WONTFIX with the recommendation to use a named pipe if you need
this feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #9 from Mark Thomas  ---
Test comment post host migration. Apologies for the noise.

--- Comment #10 from Mark Thomas  ---
Test comment 2 post host migration. Apologies for the noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #8 from Mark Thomas  ---
The proposed patch causes problems for systemd users (and possibly others) that
do not explicitly use CATALINA_PID to determine the PID of the started Tomcat
process.

Options:

1. Apply this patch as intended (e.g. r1848046) and document that systemd users
need to explicitly use CATALINA_PID

2. Close as WONTFIX with the advice to use a named pipe in CATALINA_OUT if
users want to pipe output to a process.

3. Add CATALINA_PIPE and CATALINA_OUT_CMD and manage creating of named pipe and
creation of process to read from that pipe in catalina.sh

4. Something else?

Personally, I'm leaning towards 2 at the moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

Mark Thomas  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #7 from Mark Thomas  ---
The original fix has been reverted due to regressions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #6 from Konstantin Kolinko  ---
Note that a regression from this patch is being discussed in bug 63041.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Mark Thomas  ---
Thanks for the patch.

Sorry it took so long to apply it.

Fixed in:
- trunk for 9.0.14 onwards
- 8.5.x for 8.5.36 onwards
- 7.0.x for 7.0.93 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

Christopher Schultz  changed:

   What|Removed |Added

   Keywords||PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #4 from peterhansson...@yahoo.com ---
As a workaround: Use a copy-and-truncate strategy instead. This doesn't require
changes to catalina.sh script.

On Linux: Use logrotate utility with 'copytruncate' option.

On Solaris: Use logadm utility with '-c' option. (or on Solaris 11 and later
you can install logrotate by doing 'pkg install file/logrotate' if you really,
really want to use logrotate instead of logadm)



The proposed change basically allows for a pipe strategy. This strategy is
better than a copy-and-truncate strategy for the following reasons:

- The copy-and-truncate strategy requires extra disk space when the operation
is being executed.
- The copy-and-truncate strategy has a small time gap between the copy and the
truncate. During the gap messages may be lost.
- The copy-and-truncate strategy requires changes to setup outside of the
Tomcat configuration: it requires changes to logrotate/logadm tool and
potentially a new entry in cron table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

Michael Osipov <1983-01...@gmx.net> changed:

   What|Removed |Added

 CC||1983-01...@gmx.net

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=53930

--- Comment #3 from peterhansson...@yahoo.com ---
This is a very important addition. 
If you search the internet you'll find lots of recommendations on allowing
log-rotation and all of them tell you to modify your catalina.sh file. The
point here is that users really shouldn't modify catalina.sh as it breaks the
upgrade path. Hence the feature should be supported in the script itself as per
Casey's patch.

Since this RFE was launched the catalina.sh script has been modified to also
support NOHUP which means the Casey's patch no longer applies verbatim.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 53930] allow capture of catalina stdout/stderr to a command instead of just a file [PATCH]

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53930

Christopher Schultz ch...@christopherschultz.net changed:

   What|Removed |Added

Summary|allow capture of catalina   |allow capture of catalina
   |stdout/stderr to a command  |stdout/stderr to a command
   |instead of just a file  |instead of just a file
   ||[PATCH]

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org