Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-17 Thread Violeta Georgieva
Hi, 2015-07-16 12:57 GMT+03:00 Andrei Ivanov : > > Hi, > Maybe you can take a look at bug 58143 with this occasion :-) I'll check it. Regards, Violeta

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #26 from Violeta Georgieva --- The feature is backported to 7.0.x for 7.0.64 onwards. -- You are receiving this mail because: You are the assignee for the bug. -

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-16 Thread Andrei Ivanov
Hi, Maybe you can take a look at bug 58143 with this occasion :-)

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-15 Thread Mark Thomas
On 15 July 2015 21:52:45 CEST, Violeta Georgieva wrote: >2015-07-15 20:06 GMT+03:00 Mark Thomas : >> >> On 15 July 2015 16:28:59 CEST, Violeta Georgieva >wrote: >> >Hi, >> > >> >2013-09-27 2:16 GMT+03:00 : >> >> >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 >> >> >> >> --- Commen

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-15 Thread Violeta Georgieva
2015-07-15 20:06 GMT+03:00 Mark Thomas : > > On 15 July 2015 16:28:59 CEST, Violeta Georgieva wrote: > >Hi, > > > >2013-09-27 2:16 GMT+03:00 : > >> > >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > >> > >> --- Comment #25 from Nick Williams > >--- > >> *** At the very least, it shou

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-15 Thread Mark Thomas
On 15 July 2015 16:28:59 CEST, Violeta Georgieva wrote: >Hi, > >2013-09-27 2:16 GMT+03:00 : >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 >> >> --- Comment #25 from Nick Williams >--- >> *** At the very least, it should say "@since 8.0, 7.0.46." > >While I was looking at this fea

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2015-07-15 Thread Violeta Georgieva
Hi, 2013-09-27 2:16 GMT+03:00 : > > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > --- Comment #25 from Nick Williams --- > *** At the very least, it should say "@since 8.0, 7.0.46." While I was looking at this feature which was marked as available in 7.0.46, I did not find neither

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2014-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #26 from Jackie Rosen --- *** Bug 260998 has been marked as a duplicate of this bug. *** Seen from the domain http://volichat.com Page where seen: http://volichat.com/adult-chat-rooms Marked for reference. Resolved as fixed @bug

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #25 from Nick Williams --- *** At the very least, it should say "@since 8.0, 7.0.46." -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #24 from Nick Williams --- Excellent. Thanks! Two things: 1) InstrumentableClassLoader, as committed, says "@since 8.0, 7.0.44." At the time I submitted my most recent patch, 7.0.44 was "next." As you know, due to several recen

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #23 from Mark Thomas --- The patch has been applied with a few minor tweaks to fix the various warnings Eclipse threw up. It will be included in 8.0.0-RC4 onwards. I anticipate the next 8.0.0-RCx release around (maybe even befor

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #22 from Juergen Hoeller --- The patch looks fine to me. Would be great to merge it into Tomcat proper as soon as possible. Fortunately, since we're reflectively discovering those methods, we don't need to wait for Tomcat binar

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30825|0 |1 is obsolete|

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #20 from Mark Thomas --- (In reply to Nick Williams from comment #19) > (In reply to Jeremy Boynes from comment #18) > > 1) CopyOnWriteArrayList would simplify managing added transformers and is > > intended for this use-case. >

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #19 from Nick Williams --- (In reply to Jeremy Boynes from comment #18) > 1) CopyOnWriteArrayList would simplify managing added transformers and is > intended for this use-case. How have I never heard of this class before? Cert

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #18 from Jeremy Boynes --- 1) CopyOnWriteArrayList would simplify managing added transformers and is intended for this use-case. 2) I would not try to de-dupe the list at all. There's no contract around equals() for transformer

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-12 Thread Nick Williams
On Aug 29, 2013, at 4:28 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > --- Comment #16 from Mark Thomas --- > (In reply to Nick Williams from comment #15) >> Created attachment 30749 [details] >> Proposed implementation of this feature > > 1. Why

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30749|0 |1 is obsolete|

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #16 from Mark Thomas --- (In reply to Nick Williams from comment #15) > Created attachment 30749 [details] > Proposed implementation of this feature 1. Why loop over list rather than using contains() in addTransformer() ? 2. S

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Nick Williams
On Aug 28, 2013, at 9:07 AM, Mark Thomas wrote: > On 28/08/2013 13:36, Nick Williams wrote: >> >> On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: >> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 >>> >>> Nick Williams changed: >>> >>> What|Removed

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Mark Thomas
On 28/08/2013 13:36, Nick Williams wrote: > > On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: > >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 >> >> Nick Williams changed: >> >> What|Removed |Added >>

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Nick Williams
On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > Nick Williams changed: > > What|Removed |Added > > Attachment #

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30748|0 |1 is obsolete|

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30678|0 |1 is obsolete|

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #13 from Jeremy Boynes --- Created attachment 30678 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30678&action=edit Proposal for transformer registration API (In reply to Nick Williams from comment #11) > Okeydokey

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #12 from Nick Williams --- I noticed WebappClassLoader's toString() method includes a lot of information about the ClassLoader, such as the parent ClassLoader, context name, delegation setting, and repository. Should I also chan

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #11 from Nick Williams --- Okeydokey. addTransformer() and removeTransformer() is my preference and also what's easiest on the Spring folks (it will require no code change on their part to work), so that's the direction we'll go

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #10 from Mark Thomas --- (In reply to Nick Williams from comment #9) > Mark, what do you think? My primary concern has already been articulated in comment #1. > If you don't have a preference, I'll probably go > Rainer's rout

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #9 from Nick Williams --- I've received some guidance from the folks over at SpringSource (https://jira.springsource.org/browse/SPR-10788) and I'd like to get started on a patch for this now. However, I've yet to hear from Mark

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #8 from Nick Williams --- To address Jeremy's concerns/questions: 1) I don't see a security issue. JBoss, GlassFish, WebLogic, and WebSphere, for example, all "automatically enable this for all applications." You say, "Currentl

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Jeremy Boynes changed: What|Removed |Added Summary|Make|Facilitate weaving by