[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://bz.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #9 from Martin bestandig --- Dellet -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://bz.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #9 from isabelladom --- https://app.grammarly.com/ddocs/428003256;>click here https://www.google.com/ [url=https://www.google.com/]click to go[/url] www.google.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://bz.apache.org/bugzilla/show_bug.cgi?id=56546 ithan changed: What|Removed |Added CC|ithanr...@gmail.com | -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://bz.apache.org/bugzilla/show_bug.cgi?id=56546 ithan changed: What|Removed |Added CC|ahmedhosni...@gmail.com |ithanr...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 Ahmed Hosni ahmedhosni...@gmail.com changed: What|Removed |Added CC||ahmedhosni...@gmail.com --- Comment #8 from Ahmed Hosni ahmedhosni...@gmail.com --- Created attachment 32241 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32241action=edit Diff file fort to list all stack traces before clearing threads Fix bug 56546 list all stack traces before clearing threads, using two loops one for each purposem as Konstantin Kolinko suggested -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #5 from Mark Thomas ma...@apache.org --- Is there anything more to do here? If not, I'll resolve this as fixed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Mark Thomas from comment #5) I am OK to treat this as enhancement, though Remy raised this as a serious issue. In any case it is not a stopper for tagging 8.0.next. On my TODO is to pursue idea from Comment 2 (print all traces at once). I do no have time today though. Implementing that needs some refactoring. My idea is to split threads loop into two loops, where the first one populates some informational structure and the second performs stopping (if enabled). I think the current code has a minor issue: It attempts to shut down executor for each encountered thread. Thus I think it does it N times if there are N running threads for the same Executor. This feature is off by default, though. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 Remy Maucherat r...@apache.org changed: What|Removed |Added Priority|P2 |P1 Severity|normal |enhancement --- Comment #7 from Remy Maucherat r...@apache.org --- It is not actually a serious issue, it is cosmetic but fairly irriating ... So enhancement is fine, but I am bumping up the priority. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #4 from Mark Thomas ma...@apache.org --- org.apache.tomcat.websocket.TestWsWebSocketContainer no longer generates this message. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #3 from Mark Thomas ma...@apache.org --- org.apache.catalina.connector.TestMaxConnections no longer generates this message -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added OS||All --- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com --- Possible ways to improve this: A. Reduce the log level for stack trace message from log.error() to log.info(). In the current code there are two log.error() messages at once, which looks like overkill. log.error(sm.getString(webappClassLoader.warnThread, getContextName(), threadName)); log.error(sm.getString(webappClassLoader.stackTrace, threadName, getStackTrace(thread))); B. Make this an opt-in feature. A new property on Context? Or two properties, to distinct handling of request threads vs. non-request threads. C. Merge similar logs into a single message? (E.g. if there are many request threads that are stuck in the same place). I think A. is a good and easy way to go. Any additional ideas, concerns? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56546] Improve thread trace logging in WebappClassLoader.clearReferencesThreads()
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com --- I applied A. in r1596090. D. Running org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak, I think it will be more readable, if all the stack traces are printed at once, as 20-May-2014 hh:mm:ss.sss INFO [threadname] org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads Stack traces of threads for web application [/foo]: Thread name: stacktrace Thread name: stacktrace Threads name: stacktrace -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
