[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #7 from Mark Thomas --- Has the ability to disable JMX made this enhancement request obsolete? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #6 from Konstantin Kolinko --- (In reply to Phillip Webb from comment #4) > That's a really interesting metric and quite a significant amount if we're > talking about using embedded Tomcat in a serverless environment where runs > are very short lived. 1. I guess that in your use case of short-lived Tomcats (or whatever those "serverless" environment is) you do not need JMX support at all. (And thus no need to really parse these files). 2. The topic of JMX was also mentioned in thread "Becoming graalvm friendly?" on dev#. https://tomcat.markmail.org/thread/kayfacujrpt2diht -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #5 from Phillip Webb --- I've got an experimental branch[1] that replaces the XML files with registrar classes. So far the results aren't particularly inspiring and I'm not seeing a big improvement in performance. I think the main reason is that the lambda based approach that I adopted has quite a bit of overhead itself. I hacked together a small bit of code to migrate the XML[2], so it might be worth having another go if we can come up with an approach that doesn't use lambdas. So far, I've not been able to think of an API without them that would be quite as nice. [1] https://github.com/philwebb/tomcat/tree/bz-63237 [2] https://gist.github.com/philwebb/79d3dc5446f0c4a050115b059181 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #4 from Phillip Webb --- > MBeanUtils.createRegistry takes 83ms on my computer, which is not exactly the > end of the world That's a really interesting metric and quite a significant amount if we're talking about using embedded Tomcat in a serverless environment where runs are very short lived. > The solution proposed ... is a bit annoying to say the least compared to the > descriptors OK. I probably should have just stated the problem and not suggested a solution. I'm not too keen on generating code either. Let me rephrase. Would a (potentially hand crafted) code based alternative to `mbeans-descriptors.xml` be something you'd consider worthwhile? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #3 from Remy Maucherat --- Profilers often exaggerate the impact of some operations, so this has to be taken with an amount of caution. XML parsing is expensive for sure, but the descriptors are not too huge and MBeanUtils.createRegistry takes 83ms on my computer, which is not exactly the end of the world. The solution proposed [generating mbeans code :( ] is a bit annoying to say the least compared to the descriptors. On the plus side, I'm pretty sure regular mbeans perform better at runtime than model mbeans, this is not so innocent when cloud monitoring goes crazy and uses 100s of metrics. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #2 from Phillip Webb --- @Remy > I have not tried to measure the time and resource costs of this parsing The only evidence I have currently are profiling results that appear to indicate the SAX parser taking a chunk of time during startup. I imagine for most standalone Tomcat users, this isn't really an issue. For users of embedded Tomcat, these little optimizations can really help. Anecdotally, I have implemented similar performance tweaks previously by replacing logback XML parsing with programmatic configuration [1]. [1] https://github.com/spring-projects/spring-boot/issues/1796 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 Remy Maucherat changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Remy Maucherat --- I have not tried to measure the time and resource costs of this parsing. Obviously changing it to something compiled would not be exclusively beneficial, so there needs to be clear gains for the embedded use case. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 Andy Wilkinson changed: What|Removed |Added CC||awilkin...@pivotal.io -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 Tommy Ludwig changed: What|Removed |Added CC||tommy.ludwig.c...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
