[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 --- Comment #5 from Eugène Adell --- Thanks for looking Chris, GlobalRequestProcessor : The counters are no different from those already existing, and authentication denials could not logically go higher than errorCount which is an int (on version 9.0 at least) I can change this, but this would not be consistent. Realm : The counters are of the same magnitude than requestCount which is also a vanilla int. As requested, I am switching to the Atomic version as I see in the LockOutRealm some use of Atomics, this makes more sense here. I'm posting a new patch for it, for version 9.0.36 as the descriptors file is a bit different than 1 year ago. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 Eugène Adell changed: What|Removed |Added Attachment #36619|0 |1 is obsolete|| --- Comment #4 from Eugène Adell --- Created attachment 37334 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37334&action=edit adds authentications counters at the Realm level, version 2 Convert int to AtomicInteger for my 2 counters, update descriptors to use 9.0.36 instead of 9.0.20 which was different -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 --- Comment #3 from Christopher Schultz --- The patch isn't high-load-safe because the counters are vanilla ints and you use ++ for increment. I think you'd at least need to use AtomicInt. You might want to consider AtomicLong... those counters might get pretty high. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 --- Comment #2 from Eugène Adell --- Created attachment 36619 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36619&action=edit adds authentications counters at the Realm level this is for DataSourceRealm, other realms should probably be modified the same way -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 --- Comment #1 from Eugène Adell --- Created attachment 36618 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36618&action=edit adds authorizationDeniedCount at the GlobalRequestProcessor level denied authorization counter, checks 403 return codes -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 Eugène Adell changed: What|Removed |Added CC||eugene.ad...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
