[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 --- Comment #11 from Gustavo Stachera --- (In reply to Joshua Lipstone from comment #8) > Can you please either undo this or change it so that the Jars are only > scanned if they match the inclusion filter. > As of 9.0.30, if you wanted to set the logic so that it only scans a short > list of jars, you could do: > jarsToSkip=* > jarsToScan=jar1.jar,jar2.jar > As of 9.0.31, this now causes cascading startup failures. I've implemented a workaround using de wildcard "?" in the beginning, followed by "*" and it works: tomcat.util.scan.StandardJarScanFilter.jarsToSkip=?* -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 --- Comment #10 from quaff --- (In reply to Joshua Lipstone from comment #8) > Can you please either undo this or change it so that the Jars are only > scanned if they match the inclusion filter. > As of 9.0.30, if you wanted to set the logic so that it only scans a short > list of jars, you could do: > jarsToSkip=* > jarsToScan=jar1.jar,jar2.jar > As of 9.0.31, this now causes cascading startup failures. I have encounter the same problem, Tomcat breaks back compatibility. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #9 from Remy Maucherat --- This is an enhancement that got implemented, so don't reopen this BZ. If you have an issue, you need to open a new BZ. If you are unsure about it, you can also ask on the users list. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 Joshua Lipstone changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #8 from Joshua Lipstone --- Can you please either undo this or change it so that the Jars are only scanned if they match the inclusion filter. As of 9.0.30, if you wanted to set the logic so that it only scans a short list of jars, you could do: jarsToSkip=* jarsToScan=jar1.jar,jar2.jar As of 9.0.31, this now causes cascading startup failures. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #7 from Mark Thomas --- Fixed (by isapir) in: - master for 9.0.31 onwards - 8.5.x for 8.5.51 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 Christopher Schultz changed: What|Removed |Added Keywords||Beginner -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #6 from Mark Thomas --- Marking as an enhancement -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 --- Comment #5 from Igal Sapir --- (In reply to Chuck Caldarale from comment #4) > Could the standard jar scanner recognize the "*.jar" pattern and simply > short-circuit all the directory scanning? I can see benefit in that solution for users who use Tomcat regularly (as opposed to Embedded) so I actually like that idea. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 --- Comment #4 from Chuck Caldarale --- Could the standard jar scanner recognize the "*.jar" pattern and simply short-circuit all the directory scanning? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691 --- Comment #3 from Mark Thomas --- It is a balance. I'm on the fence as to whether this is worth adding or not. If you think it adds value then I'm not going to object. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691
--- Comment #2 from Igal Sapir ---
(In reply to Mark Thomas from comment #1)
> Why not just do
>
> System.setProperty("tomcat.util.scan.StandardJarScanFilter.jarsToSkip","*.
> jar") ?
IIRC then that still reads the directories and then filters them out.
Currently I am using the following:
context.setJarScanner(
new JarScanner() {
@Override
public void scan(JarScanType scanType, ServletContext context,
JarScannerCallback callback) {}
@Override
public JarScanFilter getJarScanFilter() { return null; }
@Override
public void setJarScanFilter(JarScanFilter jarScanFilter) {}
}
);
It might be negligible compared to the System property that you cited but then
again the addition is very minor as well.
If you still think that it's not useful then that's fine and we can just close
this ticket as rejected.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63691] Add a no-op JarScanner
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691
Mark Thomas changed:
What|Removed |Added
OS||All
--- Comment #1 from Mark Thomas ---
Why not just do
System.setProperty("tomcat.util.scan.StandardJarScanFilter.jarsToSkip","*.jar")
?
Untested but you get the idea. Still one line of code for end users and no need
to add an entire new class to Tomcat.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
