[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-08-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

--- Comment #7 from Mark Thomas  ---
The directives I added needed to be consistent with the directives already in
place to avoid the errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-08-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

--- Comment #6 from Michael Osipov  ---
(In reply to Mark Thomas from comment #5)
> It was another inconsistent directive.

Does your fix apply to every version of LibreSSL? While working on other
LibreSSL related issues I used this pattern:
https://github.com/apache/tomcat-native/commit/51f949dc6e0b6e4e27972b8ba2d0a2626fc3c1c5#diff-d5ecebaa2939a925164d1e10b8ab0f35R1265

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-08-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Mark Thomas  ---
It was another inconsistent directive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-08-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

--- Comment #4 from Michael Osipov  ---
(In reply to Mark Thomas from comment #3)
> The fix looks to be fairly simple and I have this committed locally. The
> various #if preprocessor directives are not consistent.
> 
> #if OPENSSL_VERSION_NUMBER < 0x1010L
> 
> vs
> 
> #if OPENSSL_VERSION_NUMBER < 0x1010L || defined(LIBRESSL_VERSION_NUMBER)
> 
> Making them consistent fixes the compilation issue. However, I am not
> currently able to confirm the fix because LibreSSL portable on Linux appears
> to enter a tight loop (never exits, 100% CPU on one thread) when
> SSL_CTX_use_PrivateKey is called.
> 
> I've tested 2.9.1, 2.9.2, 3.1.4 and 3.2.0 and the behaviour is the same.
> 
> I want to investigate the "tight loop" further before I push the commit that
> fixes this issue.

Can this be reproduced with the tests?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-08-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

--- Comment #3 from Mark Thomas  ---
The fix looks to be fairly simple and I have this committed locally. The
various #if preprocessor directives are not consistent.

#if OPENSSL_VERSION_NUMBER < 0x1010L

vs

#if OPENSSL_VERSION_NUMBER < 0x1010L || defined(LIBRESSL_VERSION_NUMBER)

Making them consistent fixes the compilation issue. However, I am not currently
able to confirm the fix because LibreSSL portable on Linux appears to enter a
tight loop (never exits, 100% CPU on one thread) when SSL_CTX_use_PrivateKey is
called.

I've tested 2.9.1, 2.9.2, 3.1.4 and 3.2.0 and the behaviour is the same.

I want to investigate the "tight loop" further before I push the commit that
fixes this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-05-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

--- Comment #2 from Michael Osipov  ---
(In reply to Christopher Schultz from comment #1)
> I think a solution is desired, but there is no need to revert.
> 
> Support for LibreSSL is a goal, not a requirement.

I agree, but if it worked before we shouldn't break it w/o any further
announcement. Are you skilled enough to work on a working solution?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64429] Commit b8649e81458194d70667952d9e26df82a79c773f in 1.1.24 breaks compilation with LibreSSL

2020-05-13 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64429

--- Comment #1 from Christopher Schultz  ---
I think a solution is desired, but there is no need to revert.

Support for LibreSSL is a goal, not a requirement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org