[Bug 64528] Regression in 8.5.56, no statistics in GlobalRequestProcessor MBean anymore

2020-06-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64528

--- Comment #5 from Mark Thomas  ---
Correct HTTP/2 traffic isn't included in the the GlobalRequestProcessor metrics
either. I'll add a note to Bug 63362.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64528] Regression in 8.5.56, no statistics in GlobalRequestProcessor MBean anymore

2020-06-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64528

--- Comment #4 from Markus Schlegel  ---
Given that it is related to the http/2 protocol upgrade, I think it indeed is
related to Bug 63362.
Nevertheless, since Tomcat Performance optimisation literature all over the net
refers to GlobalRequestProcessor as a source of metrics, I would very welcome
if that MBean would also work for upgraded http/2 connections.
Also it is still unclear for me which code change caused this problem to appear
in 8.5.56.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64528] Regression in 8.5.56, no statistics in GlobalRequestProcessor MBean anymore

2020-06-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64528

--- Comment #3 from Markus Schlegel  ---
If I disable the http/2 upgrade, it works again:

boolean ENABLE_HTTP2 = false;
if (ENABLE_HTTP2) {
Http2Protocol http2Protocol = new Http2Protocol();
sslConnector.addUpgradeProtocol(http2Protocol);
}

We had the ENABLE_HTTP2=true in our code before, such that our customers could
easily enable http/2 by simply adding the native library. However, most of the
time this was not the case. Therefore, http/2 was never really used in our app.
I have disabled it now by default and GlobalRequestProcessor is working again
now.
Please note, that using GlobalRequestProcessor for performance metrics is being
recommended in many documentations about Tomcat. People and tools might rely on
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64528] Regression in 8.5.56, no statistics in GlobalRequestProcessor MBean anymore

2020-06-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64528

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #2 from Mark Thomas  ---
And I can't reproduce it from the 8.5.56 tag with either a standard Tomcat
instance nor with the embedded JARs.

This looks like configuration error at this point. Please use the users mailing
list for further assistance.

http://tomcat.apache.org/lists.html#tomcat-users

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64528] Regression in 8.5.56, no statistics in GlobalRequestProcessor MBean anymore

2020-06-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64528

Mark Thomas  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mark Thomas  ---
OK. I can't reproduce this with current 8.5.x and a standard Tomcat build.

Switching to the 8.5.56 tag...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org