[GitHub] [tomcat] ChristopherSchultz commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-06-18 Thread GitBox
ChristopherSchultz commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-503220181 Ah, okay. I was only looking at the diff and it wasn't clear that code was in two different

[GitHub] [tomcat] ChristopherSchultz commented on issue #170: Connections validated without explicit validation query leave a transaction open

2019-06-18 Thread GitBox
ChristopherSchultz commented on issue #170: Connections validated without explicit validation query leave a transaction open URL: https://github.com/apache/tomcat/pull/170#issuecomment-503207215 I'm curious why you do not call `silentlyRollbackTransactionIfNeeded` in the `finally` clause