[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473776997 Thanks for the fix. I have no objections to the current code. I'll merge this into master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473180351 Personally, the primary factor in starting PoolCleaner should be timeBetweenEvictionRunsMillis. Same as removeAbandoned / testWhileIdle / minEvictableIdleTimeMillis. If we want to reconnect to an idle connection, We should set both maxAge and timeBetweenEvictionRunsMillis. (JMX)ConnectionPool provides the feature to restart PoolCleaner when attributes related to PoolCleaner are changed. If maxAge is changed, you should restart PoolCleaner. see:org.apache.tomcat.jdbc.pool.jmx.ConnectionPool This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473176479 > I fixed the missing calls to PooledConnection#validate(int). Thanks. > Looking at the code it seems that the timestamp should only be updated when user-initiated (like borrow or return) operations are executed on the PooledConnection, not when (possibly internal) operations are executed on the underlying JDBC Connection - right ? That's right. There is no need to call PooledConnection#setTimestamp(long) when reconnecting an idle connection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-472779046 If testOnConnect is true or initSQL is set, we need validate the connection( with VALIDATE_INIT) when reconnecting. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
