[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-18 Thread GitBox
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-694934337 Thank you @rmaucher @martin-g to get this moving fast 👍 . Will this be backported to version 9 ? This is an a

[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-08 Thread GitBox
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-689023592 @rmaucher I actually tested the optimization with the flag in a large application having 1000's of Jar in the classpath and the server startup gains are significant and the stats a

[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-08 Thread GitBox
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-688967898 > I still don't really like some items, like the explicit flag (but I don't see yet how to do it) or some of the "optimizations". > By default the utility thread count is 2, so n

[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-04 Thread GitBox
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-687380392 Thanks @rmaucher for your comment. I have made the necessary changes as suggested. It would be great if you could verify that change. I have also updated the PR description since t