[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-12 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1244022378 @markt-asf Thanks for reviewing and merging. Could this please also be included in 9.0.x? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-08 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1241479251 I've included that change too. Please let me know if there's anything else that should be done. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-07 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1239848521 Are you referring to the call to `inputBuffer.setSwallowInput(true);` in `Http11Processor.ack`? That does appear to be unnecessary now. -- This is an automated message from the Apache Git

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-06 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1238525462 @markt-asf That does work and is a much simpler solution! It also doesn't break TestSwallowAbortedUploads (which I now understand why). I will update my PR with that change. What is

[GitHub] [tomcat] malaysf commented on pull request #550: Http11Processor's keep alive state and input buffer's swallow state must be synchronized

2022-09-06 Thread GitBox
malaysf commented on PR #550: URL: https://github.com/apache/tomcat/pull/550#issuecomment-1238435761 The TestSwallowAbortedUploads test fails so I need to look into that. We ran into this issue in production and were able to reproduce with curl or postman requests to an API that