markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-572506706
No. This was not back-ported to 7.0.x (which has rather different Cookie
support).
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-493889783
Back-ported to 8.5.x
This is an automated message from the Apache Git
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-493880726
Thanks for the PR. It has been applied to master. I'll close this PR once I
have completed back-porting it.
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-492644191
Thanks for the updates. I have a few comments on the updated PR:
- You can reduce the code duplication by using CookieProcessorBase
-
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491890888
We have no latitude to change any part of a spec API. Being able to set a
default for this is better than not being able to set anything at
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491875787
Sorry, any new configuration option needs to be added to the docs as well.
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491869493
The configuration should be on the CookieProcessor, not the Context. We also
need to look at https://scotthelme.co.uk/tough-cookies/ but that
