[GitHub] [tomcat] markt-asf commented on issue #279: Optimize concurrency

2020-04-22 Thread GitBox


markt-asf commented on issue #279:
URL: https://github.com/apache/tomcat/pull/279#issuecomment-617654855


   Your analysis is not correct.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on issue #279: Optimize concurrency

2020-04-21 Thread GitBox


markt-asf commented on issue #279:
URL: https://github.com/apache/tomcat/pull/279#issuecomment-617338009


   What is the basis for this change?
   While the thread is in `wait()`, `notify()` should only be called if one of 
the conditions in the surrounding `if(...)` is no longer true. I'd expect the 
change in this PR to make performance marginally worse, not better.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org