[GitHub] [tomcat] markt-asf commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672826428 After looking at b26ad77 I have reverted the addition of `useWeakComparisonWithIfMatch` and switched If-Match to strong comparison. I've also fixed the regression you

[GitHub] [tomcat] markt-asf commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672805585 Let me go an look at `b26ad77` in more detail. If the switch to weak comparison was introduced there then the case for fixing that and dropping `useWeakComparisonWithIfMatch`

[GitHub] [tomcat] markt-asf commented on pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

markt-asf commented on pull request #337: URL: https://github.com/apache/tomcat/pull/337#issuecomment-672771845 In reviewing this PR I've noticed another issue. The ETag obtained from the resource is unconditionally made strong before the comparison but that conversion should depend on