[GitHub] [tomcat] martin-g commented on a change in pull request #316: Use lowercase HTML tags and attributes. Add quotes around attributes.

[GitBox]

martin-g commented on a change in pull request #316:
URL: https://github.com/apache/tomcat/pull/316#discussion_r450023003



##
File path: webapps/ROOT/index.jsp
##
@@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/");
 
 
 
-
+

Review comment:
   I know, but it does not do any harm either.
   This change makes the diff bigger and harder to back-port to the other 
branches.
   I prefer the XHTML style because it is easier to spot errors in the IDE/text 
editor without copying to W3C validator in the web.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] martin-g commented on a change in pull request #316: Use lowercase HTML tags and attributes. Add quotes around attributes.

[GitBox]

martin-g commented on a change in pull request #316:
URL: https://github.com/apache/tomcat/pull/316#discussion_r450018806



##
File path: webapps/ROOT/index.jsp
##
@@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/");
 
 
 
-
+

Review comment:
   Why did you remove the auto-closing ? It doesn't do any harm. I, 
personally, prefer the style it was before.

##
File path: webapps/examples/jsp/cal/cal2.jsp
##
@@ -15,31 +15,30 @@
   limitations under the License.
 --%>
 <%@page contentType="text/html; charset=UTF-8" %>
-
-
-Calendar: A JSP APPLICATION
-
+
+
+Calendar: A JSP APPLICATION
+
 
-
-
+
 
 
 <%
 String time = request.getParameter ("time");
 %>
 
- Please add the following event:
-  Date <%= table.getDate() %>
- Time <%= util.HTMLFilter.filter(time) %> 
-
-
-
- 
- 
-  Description of the event  
- 
-
-
-
-
+ Please add the following event:
+  Date <%= table.getDate() %>

Review comment:
   indentation

##
File path: webapps/examples/jsp/cal/cal1.jsp
##
@@ -32,63 +31,60 @@
 %>
 
 
-
-
-
-  prev 
- Calendar:<%= table.getDate() %>
-  next 
-
-
+
+
+
+  prev 
+ Calendar:<%= table.getDate() %>
+  next 

Review comment:
   no indentation

##
File path: webapps/examples/jsp/cal/cal1.jsp
##
@@ -15,13 +15,12 @@
   limitations under the License.
 --%>
 <%@page contentType="text/html; charset=UTF-8" %>
-
-
-Calendar: A JSP APPLICATION
-
+
+
+Calendar: A JSP APPLICATION

Review comment:
   There is no indentation here.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org