[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653508943 OK. I've reverted the DBCP classes! And made some more changes from `.append(String)` to `.append(char)` This i

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653443649 I've reverted the changes to the generated classes. What about the DBCP2 classes ? Maybe they should be changed upstream and then copied over here ? --

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653439627 Thanks, @pzygielo ! Also these seem to be the generated classes! This is an automated message from the Apac

[GitHub] [tomcat] martin-g commented on pull request #312: Use StringBuilder instead of StringBuffer

martin-g commented on pull request #312: URL: https://github.com/apache/tomcat/pull/312#issuecomment-653404420 @rmaucher Could you please comment on the changed lines ? I am not sure which code is generated and which `append(char)` might be wrong. Thanks! ---