[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-23 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-750490202 > > > It can 100% work with APR, except I personally don't want to add features to that component at this point. If you personally don't want to, @minfrin happily

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-23 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-750148235 I see no reason why this cannot work which Java UDS and APR UDS. This is an automated message from the Apache

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-743337472 @minfrin Could you kindly add a test case for this? I would like to finalize this and checkout @martin-g's comments.

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-03 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-738291588 @minfrin Do you want to peform anymore changes or do want to me run verifcation on it? Do you think a test would be possible to start up and shut down a UDS?

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-02 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-737353972 > > > > OK, my slight counter proposal is not use rw-rw-rw- as default, but rw-rw because this would reflect the default umask of 027, i.e, not to create anything

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-01 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-736761640 > > > > > To be in any way useful the socket must be writable, and to do that it either needs to default to being writable, or needs to explicitly set as writable with

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-01 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-736684033 > The typical umask is 0027, meaning full access for tomcat itself, read access for members of the tomcat group (so that logfiles can be read but not changed), and no access for

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-11-30 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735887225 > > > > > > That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-11-30 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735864234 > > > > That's correct, it was supposed to be dropped already in 10.0 [it will happen in 10.1]. Instead, it got some defaults changes so that using it requires more

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-11-29 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-735453352 So you have shared machine where everyone can snoop on localhost? Since the socket files will be owned by a Tomcat system user you want to add HTTPd to that group to make it