[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-697260660 I tried it, with some changes. Will see the feedback about an actual performance benefit. I measured the cost of building the filter, not too big overall so there's likely something. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696927281 There's no cache here: the AbstractArchiveResourceSet already has a "JarFile archive" field, so it adds a new JarContents field with the same data and both get created and cleared at the same time. Looking back at the other #340 there were problems with the loader/classloader modifications which IMO look like a big hack and have a JAR cache. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628 I made the change to use the Context instead of the Host, no issue there. However, I'm not ok with the proposed changes as is. The problem for me is that I don't understand the weird code added to AbstractArchiveResourceSet. I am ok with adding the creation of that JarContents filter in openJarFile() [even with the sync ...], basically, but not elsewhere, and without the strange custom refresh mechanism on lookup. Then, since it is *likely* quite harmless, it could be enabled by default (and maybe the flag can be removed altogether ...). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-694943835 I am rather skeptical on this PR overall. As with your other PR, please remove all the changes to the Host, the flag should be on the Context. Things are then much simpler without any unnecessary API changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
