[GitHub] [tomcat] rmaucher commented on pull request #414: don't log undesired warnings for webapp classloader configuration

2021-03-22 Thread GitBox
rmaucher commented on pull request #414: URL: https://github.com/apache/tomcat/pull/414#issuecomment-804012002 I added the simple reflection free version, so the properties now need WebappCLBase and we'll see what happens. I didn't merge the test since it's quite obvious when there's no

[GitHub] [tomcat] rmaucher commented on pull request #414: don't log undesired warnings for webapp classloader configuration

2021-03-18 Thread GitBox
rmaucher commented on pull request #414: URL: https://github.com/apache/tomcat/pull/414#issuecomment-801922794 @rmannibucau That wasn't the case before that commit, but it's possible after it. Personally, I would prefer dropping the reflection. Let's see if Mark wants to comment on that.

[GitHub] [tomcat] rmaucher commented on pull request #414: don't log undesired warnings for webapp classloader configuration

2021-03-18 Thread GitBox
rmaucher commented on pull request #414: URL: https://github.com/apache/tomcat/pull/414#issuecomment-801817917 This was introduced by https://github.com/apache/tomcat/commit/c38e9ccabc0d20e1f88b389ab531dcbf632b0ed8 and I understand the WebappLoader changes part of it. In