rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-650272578
Also note that since this is handling push/pr on _master_ (to be renamed
branch) there is no point applying this to other branches.
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-650271782
Is anyone up for merging this? If something is missing please let me know :)
I wasn't sure if this warranted a changelog.
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-649530867
@rmaucher I have made the requested changes:
- only trunk
- use nio
- excluded tests slower than 5 seconds
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-649013143
FYI the latest iteration of this runs on Java 8 - 15-ea + windows in 11
minutes https://github.com/rotty3000/tomcat/actions/runs/146537422
The arbitrary reduction was made
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648872489
FYI, tomcat seems to build and test (nio) fine on Java 8, 11, 14 & 15-ea!
:+1:
This is an automated message
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648856220
I do not disagree that adding a third could be confusing. What I like about
actions in addition to the points you've made is:
- runs on forks as well (which means I can
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648393296
Also we can add to the matrix as we go.
This is an automated message from the Apache Git Service.
To respond to
rotty3000 commented on pull request #307:
URL: https://github.com/apache/tomcat/pull/307#issuecomment-648392839
This could be applied to each of the key branches.
This is an automated message from the Apache Git Service.
To
