[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10 URL: https://github.com/apache/tomcat/pull/150#issuecomment-475233025 Nice, thx you a lot @markt-asf This is an

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10 URL: https://github.com/apache/tomcat/pull/150#issuecomment-475179366 Hi I have update the code, and squash commit Tell me if it's ok for you thx

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10 URL: https://github.com/apache/tomcat/pull/150#issuecomment-474878836 Ok I have add 11 and 12, I wait for your commit, and I will update this with just 12 if necessary thx

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10 URL: https://github.com/apache/tomcat/pull/150#issuecomment-474872724 Ok sorry I didn't understand the first comment So I will update the PR like you said

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10 URL: https://github.com/apache/tomcat/pull/150#issuecomment-474831606 Thx for your anwser So I will wait for ECJ right ? Or maybe I can try to add options to Java 11 in ECJ ?