tcollignon opened a new pull request #150: Add compiler source and target support for all Java versions over 10 URL: https://github.com/apache/tomcat/pull/150 Hi, I maintain the maven plugin to compile JSP : https://github.com/leonardehrenfried/jspc-maven-plugin We have receive an issue when someone trying to compile JSP with Java 11 (to obtain target jsp class in Java 11 bytecode) see https://github.com/leonardehrenfried/jspc-maven-plugin/issues/39 I have look at the JDTCompiler source code and it appear that it handle only Java 10. So I propose this modifications : - If compiler source or target is set, and value is not known by ECJ constant, we even set this directly and not fallback to Java 1.8. Java move faster now, and probably ECJ will not move as faster. - If compiler source or target is not set, we fallback to Java 1.8 as previous WDYT ? Thanks you all
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
