[GitHub] tomcat issue #75: added javadoc comments and a method that takes default val...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/75
  
Actually, I see that I can not add `@Override` since it's not part of the 
`javax.servlet.Filter` interface.




---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #75: added javadoc comments and a method that takes default val...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/75
  
OK, the reason that I added this method is that I saw `init()` and I did 
not realize that it was part of the spec since it is not marked with 
`@Override` and I've never seen it before (looks like it's new in Servlet 4.0)

Should I re-submit the JavaDoc enhancements and add `@Override` to `init()`?


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #75: added javadoc comments and a method that takes default val...

[markt-asf]

Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/75
  
-1
The public API of specification defined classes may not be changed.
This method would be worth adding to o.a.catalina.filters.FilterBase if any 
of Tomcat's internal filter implementations could make use of it (i.e. if it 
resulted in removing more code than it added)


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org