[GitHub] tomcat issue #77: Removed findbugs bad practice warnings by making classes f...

2018-06-04 Thread markt-asf 
Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/77
  
These have been resolved since this PR was opened.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #77: Removed findbugs bad practice warnings by making classes f...

2017-10-13 Thread isapir 
Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/77
  
I actually started with using super.clone() but upon further research opted 
for marking the classes as `final`.  All the "best practices" advocates say to 
avoid using the faulty clone() method as described in Joshua Bloch's book 
_Effective Java_, and also described in articles online like 
http://www.artima.com/intv/bloch13.html

I will refactor these to use `super.clone()`.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #77: Removed findbugs bad practice warnings by making classes f...

2017-10-13 Thread markt-asf 
Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/77
  
Making those classes final will cause problems if users have extended any 
of them. While that seems unlikely, experience suggests it has probably been 
done somewhere.  Is there any reason super.clone() can't be used instead for 
these?


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org