[GitHub] tomcat issue #83: Bug 61668 - Possible NullPointerException in AbstractHttp1...

2017-11-08 Thread markt-asf 
Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/83
  
Thanks for the proposed patch. I opted for a more general solution in 
StringUtils since fixing that problem there should - in theory - prevent it 
appearing anywhere else StringUtils is used.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #83: Bug 61668 - Possible NullPointerException in AbstractHttp1...

2017-11-03 Thread mithunsasidharan 
Github user mithunsasidharan commented on the issue:

https://github.com/apache/tomcat/pull/83
  
@markt-asf : Can I just call `getSSLProtocol()` from within 
`getSslEnabledProtocols()` ?

```
public String getSslEnabledProtocols() {
registerDefaultSSLHostConfig();
getSSLProtocol()
}
```


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #83: Bug 61668 - Possible NullPointerException in AbstractHttp1...

2017-11-03 Thread markt-asf 
Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/83
  
The duplicated code is a sign that this could be handled elsewhere with 
less code (i.e. in StringUtils)


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org