[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation
Github user rmaucher commented on the issue: https://github.com/apache/tomcat/pull/84 Abstraction is ok, more importantly limiting the number of impls will make it much much easier to maintain. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation
Github user maxime-beck commented on the issue: https://github.com/apache/tomcat/pull/84 Apparently Microsoft recently came up with a new container management service **[1]** based on Kubernetes for Azure. This means that all container management providers that we're aiming to support now potentially work with Kubernetes. It makes us rethink our data model and especially our necessity for abstraction. Because this now needs a higher level of investigation and analysis, I'll close this pull request for now. ___ **[1]** https://azure.microsoft.com/en-us/blog/introducing-azure-container-service-aks-managed-kubernetes-and-azure-container-registry-geo-replication/ --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation
Github user jfclere commented on the issue: https://github.com/apache/tomcat/pull/84 See also in https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/src/main/java/org/jgroups/protocols/kubernetes/stream/StreamProvider.java it seems we are reusing their internal interface, what doesn't look quite good, AKA it looks like an implementation detail of the Kubernetes logic. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/84 This needs a wider discussion on the dev list first. However I do have some initial high level comments: - The choice of package is unexpected - Headers need to be standard ASF headers - Author details need to be removed - At least one file appears to have been written by someone other than the person submitting the pull request. That is a huge red flag as it is not clear that the person submitted the pull request has the necessary rights to do so. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
