[GitHub] tomcat pull request #48: Fix http parser

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #48: Fix http parser

[katya-stoycheva]

GitHub user katya-stoycheva opened a pull request:

https://github.com/apache/tomcat/pull/48

Fix http parser

Fix IPv6/IPv4 parsing for host header:
- chars other than : should not be allowed in IPv6 address after ]
- ::: should not present in IPv6 address
- IPv4 part of IPv6 address was not correctly parsed (1 symbol of IPv4 part 
was ignored)
- tests added to cover IPv4/6 parsing 
- parsed test class fixed not to throw NPE when an exception is expected 
but not thrown 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/katya-stoycheva/tomcat fix-http-parser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit 9d1787b8c7cac6e1448f5446b6e766a8efa82ec5
Author: Todorova, Katya 
Date:   2017-03-30T13:25:08Z

Check no additional symbols after ] in IPv6 hosts

commit f14d497d9e36dfc4e3c8a904e5608341f44e7f15
Author: Katya Todorova 
Date:   2017-03-30T13:48:46Z

Check ::: is not presented in IPv6 host

commit a3e64260605d0e7eb967638c3621e639d39fb33e
Author: Katya Todorova 
Date:   2017-03-30T13:59:33Z

Fix parser read position when reading IPv4 part of IPv6 host

commit 775e3ad85f1c12708250c9f16930bbe6e6b3cfe9
Author: Katya Todorova 
Date:   2017-03-30T14:26:05Z

Add more test cases to increase code coverage

commit da5a06c67beb9cbb2b72b04ff991b82623654c82
Author: Katya Todorova 
Date:   2017-03-30T14:26:54Z

Fix NPE in test class when an exception is expected but not thrown




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org