[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-07-11 Thread katya-stoycheva
Github user katya-stoycheva commented on a diff in the pull request: https://github.com/apache/tomcat/pull/69#discussion_r126873704 --- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java --- @@ -0,0 +1,59 @@ +package org.apache.juli; + +import static org.junit.A

[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-07-11 Thread katya-stoycheva
Github user katya-stoycheva commented on a diff in the pull request: https://github.com/apache/tomcat/pull/69#discussion_r126873614 --- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java --- @@ -0,0 +1,59 @@ +package org.apache.juli; --- End diff -- Added

[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-07-11 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/69#discussion_r126773883 --- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java --- @@ -0,0 +1,59 @@ +package org.apache.juli; --- End diff -- Please add co

[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-07-11 Thread violetagg
Github user violetagg commented on a diff in the pull request: https://github.com/apache/tomcat/pull/69#discussion_r126779410 --- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java --- @@ -0,0 +1,59 @@ +package org.apache.juli; + +import static org.junit.Assert.

[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...

2017-07-11 Thread katya-stoycheva
GitHub user katya-stoycheva opened a pull request: https://github.com/apache/tomcat/pull/69 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61232 Checks for one char separator only, not specifically for "." You can merge this pull request into a Git repository by running: $