Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
On 20/09/2022 11:39, Felix Schumacher wrote: Well, my second mail included a +1, but I will re-send a new +1 to make it more clear. Thanks. I see that now but it wasn't clear when I first looked. Mark Felix Am 19.09.22 um 15:07 schrieb Mark Thomas: Ping. We need one more PMC vote for this release. While Felix did indicate support for the release, there wasn't an explicit +1 and I'm opting to err on the side of caution. Mark On 15/09/2022 10:06, Mark Thomas wrote: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
Am 15.09.22 um 11:06 schrieb Mark Thomas: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [x] +1: Acceptable. Go ahead and release. Thanks for RM Felix Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org OpenPGP_0xEA6C3728EA91C4AF.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
Well, my second mail included a +1, but I will re-send a new +1 to make it more clear. Felix Am 19.09.22 um 15:07 schrieb Mark Thomas: Ping. We need one more PMC vote for this release. While Felix did indicate support for the release, there wasn't an explicit +1 and I'm opting to err on the side of caution. Mark On 15/09/2022 10:06, Mark Thomas wrote: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org OpenPGP_0xEA6C3728EA91C4AF.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
Ping. We need one more PMC vote for this release. While Felix did indicate support for the release, there wasn't an explicit +1 and I'm opting to err on the side of caution. Mark On 15/09/2022 10:06, Mark Thomas wrote: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
On 15/09/2022 10:06, Mark Thomas wrote: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [X] +1: Acceptable. Go ahead and release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
Am 15.09.22 um 16:32 schrieb Mark Thomas: On 15/09/2022 14:36, Felix Schumacher wrote: Am 15.09.22 um 11:06 schrieb Mark Thomas: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [x] +1: Acceptable. Go ahead and release. When I try to build the sources from the tar.gz maven complains about missing checkstyle files: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (validate) on project jakartaee-migration: Failed during checkstyle execution: Unable to find configuration file at location: res/checkstyle/checkstyle.xml: Could not find resource 'res/checkstyle/checkstyle.xml'. -> [Help 1] When I copy the files from git into the source folder mvn verify works as expected. I'll get that fixed. Do we want 1.0.5 for this? I would be OK without a fix, but wasn't sure about it generally. Felix Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org OpenPGP_0xEA6C3728EA91C4AF.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
On 15/09/2022 14:36, Felix Schumacher wrote: Am 15.09.22 um 11:06 schrieb Mark Thomas: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. When I try to build the sources from the tar.gz maven complains about missing checkstyle files: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (validate) on project jakartaee-migration: Failed during checkstyle execution: Unable to find configuration file at location: res/checkstyle/checkstyle.xml: Could not find resource 'res/checkstyle/checkstyle.xml'. -> [Help 1] When I copy the files from git into the source folder mvn verify works as expected. I'll get that fixed. Do we want 1.0.5 for this? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
Am 15.09.22 um 11:06 schrieb Mark Thomas: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. When I try to build the sources from the tar.gz maven complains about missing checkstyle files: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (validate) on project jakartaee-migration: Failed during checkstyle execution: Unable to find configuration file at location: res/checkstyle/checkstyle.xml: Could not find resource 'res/checkstyle/checkstyle.xml'. -> [Help 1] When I copy the files from git into the source folder mvn verify works as expected. Felix Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org OpenPGP_0xEA6C3728EA91C4AF.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
On Thu, Sep 15, 2022 at 11:06 AM Mark Thomas wrote: > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now > available for voting. > > The significant changes since 1.0.3 are: > > - Issue #26 - Re-fix > - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) > - Add checkstyle > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1392/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 > a74aad315b8af81de0fa1837acc2adb278f5cb5a > > The proposed 1.0.4 release is: > > [ ] -1: Broken. Do not release because... > [X] +1: Acceptable. Go ahead and release. Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
> 2022年9月15日 17:06，Mark Thomas 写道： > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now > available for voting. > > The significant changes since 1.0.3 are: > > - Issue #26 - Re-fix > - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) > - Add checkstyle > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1392/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 > a74aad315b8af81de0fa1837acc2adb278f5cb5a > > The proposed 1.0.4 release is: > > [ ] -1: Broken. Do not release because... > [ X] +1: Acceptable. Go ahead and release. Unit tests pass. Sample application that has migrated which runs properly on Tomcat 10.0.23 with some SORTED jars. Han > > Thanks, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.4
The proposed Apache Tomcat migration tool for Jakarta EE 1.0.4 is now available for voting. The significant changes since 1.0.3 are: - Issue #26 - Re-fix - PR #28 - Add Jakarta EE -. Java EE profile (with warnings) - Add checkstyle It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1392/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.4 a74aad315b8af81de0fa1837acc2adb278f5cb5a The proposed 1.0.4 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
