Re: [VOTE] Release Apache Tomcat 7.0.2
Thanks Mark! It's probably from a very long time ago, in which case there could be years worth of code that depends on these slashes being there. -- Jason On Fri, Sep 3, 2010 at 6:21 AM, Mark Thomas wrote: > On 05/08/2010 22:09, Jason Brittain wrote: > > One thing I noticed while testing 7.0.2 is that the WebModule MBean > > ObjectNames differ slightly from those of Tomcat 6. Example: > > > > Tomcat 7.0.2, ObjectName for the context "/": > > > Catalina:j2eeType=WebModule,name=localhost/,J2EEApplication=none,J2EEServer=none > > > > Tomcat 6.0.x, ObjectName for the context "/": > > > Catalina:j2eeType=WebModule,name=//localhost/,J2EEApplication=none,J2EEServer=none > > I don't see any reason for the // in the Tomcat 6 name either but I have > added them back for Tomcat 7 to keep things consistent. > > Mark >
Re: [VOTE] Release Apache Tomcat 7.0.2
On 05/08/2010 22:09, Jason Brittain wrote: > One thing I noticed while testing 7.0.2 is that the WebModule MBean > ObjectNames differ slightly from those of Tomcat 6. Example: > > Tomcat 7.0.2, ObjectName for the context "/": > Catalina:j2eeType=WebModule,name=localhost/,J2EEApplication=none,J2EEServer=none > > Tomcat 6.0.x, ObjectName for the context "/": > Catalina:j2eeType=WebModule,name=//localhost/,J2EEApplication=none,J2EEServer=none I don't see any reason for the // in the Tomcat 6 name either but I have added them back for Tomcat 7 to keep things consistent. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT] [VOTE] Release Apache Tomcat 7.0.2
On 10/08/2010 16:45, Mark Thomas wrote: > stable: none > beta: jimjag > Jason Brittain (non-binding) > markt > Martin Duboc (non-binding) > mturk > alpha: none > broken: none > > The result of the 7.0.2 release vote is beta. > > Thanks to everyone who helped with this release (voting, testing, etc) I've copied the files to dist. I'll give it ~24 hours to sync to the mirrors and then update the website (inc 7.0.2 docs) and then once those changes have sync'd (~1hr) announce the release. Mark > > Mark > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[RESULT] [VOTE] Release Apache Tomcat 7.0.2
stable: none beta: jimjag Jason Brittain (non-binding) markt Martin Duboc (non-binding) mturk alpha: none broken: none The result of the 7.0.2 release vote is beta. Thanks to everyone who helped with this release (voting, testing, etc) Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.2
Hopefully better late than never:
+1
On Aug 5, 2010, at 5:09 PM, Jason Brittain wrote:
> Hi all!
>
> [X] Beta - go ahead and release as 7.0.2 Beta
>>
>
> It seems very close to stable, to me.
>
> One thing I noticed while testing 7.0.2 is that the WebModule MBean
> ObjectNames differ slightly from those of Tomcat 6. Example:
>
> Tomcat 7.0.2, ObjectName for the context "/":
> Catalina:j2eeType=WebModule,name=localhost/,J2EEApplication=none,J2EEServer=none
>
> Tomcat 6.0.x, ObjectName for the context "/":
> Catalina:j2eeType=WebModule,name=//localhost/,J2EEApplication=none,J2EEServer=none
>
> The diff is the two slashes in front of the hostname. I'm not sure why the
> two slashes were there in the first place (I don't see it anywhere in JSR
> 77), nor if they served a purpose. Here's the code in Tomcat 6's
> StandardContext (easy to find!) that built the string:
>
>String name= "//" + ((hostName==null)? "DEFAULT" : hostName) +
>(("".equals(pathName))?"/":pathName );
>
> In Tomcat 7 it's in StandardWrapper (a little harder to find):
>
>private String getWebModuleKeyProperties() {
>
>StringBuilder keyProperties = new StringBuilder(",WebModule=");
>String hostName = getParent().getParent().getName();
>if (hostName == null) {
>keyProperties.append("DEFAULT");
>} else {
>keyProperties.append(hostName);
>}
>...
>
> I guess my question is: even if the slashes didn't serve any purpose, do we
> want Tomcat 7's values to be consistent with those of Tomcat 6 for JMX API
> compatibility reasons?
>
> This was just one small inconsistency I noticed, versus Tomcat 6. I have
> not checked other object name values nor attribute values versus those of
> Tomcat 6.
>
> Thanks.
> --
> Jason
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.2
Hi all!
[X] Beta - go ahead and release as 7.0.2 Beta
>
It seems very close to stable, to me.
One thing I noticed while testing 7.0.2 is that the WebModule MBean
ObjectNames differ slightly from those of Tomcat 6. Example:
Tomcat 7.0.2, ObjectName for the context "/":
Catalina:j2eeType=WebModule,name=localhost/,J2EEApplication=none,J2EEServer=none
Tomcat 6.0.x, ObjectName for the context "/":
Catalina:j2eeType=WebModule,name=//localhost/,J2EEApplication=none,J2EEServer=none
The diff is the two slashes in front of the hostname. I'm not sure why the
two slashes were there in the first place (I don't see it anywhere in JSR
77), nor if they served a purpose. Here's the code in Tomcat 6's
StandardContext (easy to find!) that built the string:
String name= "//" + ((hostName==null)? "DEFAULT" : hostName) +
(("".equals(pathName))?"/":pathName );
In Tomcat 7 it's in StandardWrapper (a little harder to find):
private String getWebModuleKeyProperties() {
StringBuilder keyProperties = new StringBuilder(",WebModule=");
String hostName = getParent().getParent().getName();
if (hostName == null) {
keyProperties.append("DEFAULT");
} else {
keyProperties.append(hostName);
}
...
I guess my question is: even if the slashes didn't serve any purpose, do we
want Tomcat 7's values to be consistent with those of Tomcat 6 for JMX API
compatibility reasons?
This was just one small inconsistency I noticed, versus Tomcat 6. I have
not checked other object name values nor attribute values versus those of
Tomcat 6.
Thanks.
--
Jason
Re: [VOTE] Release Apache Tomcat 7.0.2
On 04/08/2010 01:46, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.2 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.2/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_2/ > > I have included a stable option below although my personal inclination > at this point is to vote beta. > > And now for the important bit: > > The proposed 7.0.2 release is: > > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 7.0.2 Alpha > [X] Beta - go ahead and release as 7.0.2 Beta > [ ] Stable - go ahead and release as 7.0.2 Stable > > This vote will run for 72 hours. Servlet TCK passes with BIO, NIO (apart from SSL re-neg) & APR JSP TCK passes with APR EL TCK passes All with a security manager There are still appear to be some issues around Async, so beta for now. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.2
Looks fine on my side. [X] Beta - go ahead and release as 7.0.2 Beta Martin
Re: [VOTE] Release Apache Tomcat 7.0.2
Testing on win32 and entering username/password during install creates a designated user, but that's not usable cause old (pre Tommcat7) roles are used. In case both manager and host-manager should be enabled by those roles the manager-gui and admin-gui roles should be used instead old ones. > The proposed 7.0.2 release is: > [X] Beta - go ahead and release as 7.0.2 Beta Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 7.0.2
The proposed Apache Tomcat 7.0.2 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.2/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_2/ I have included a stable option below although my personal inclination at this point is to vote beta. And now for the important bit: The proposed 7.0.2 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 7.0.2 Alpha [ ] Beta - go ahead and release as 7.0.2 Beta [ ] Stable - go ahead and release as 7.0.2 Stable This vote will run for 72 hours. Cheers, - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
