Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-09 Thread Violeta Georgieva
2017-01-09 13:55 GMT+02:00 Mark Thomas :
>
> On 06/01/2017 15:58, Rémy Maucherat wrote:
> > 2017-01-06 16:52 GMT+01:00 Violeta Georgieva :
> >
> >> With r1775598 changes, the declaration of the scripting variable now
is in
> >> try/finally block and it is not visible outside this block.
> >>
> >> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/a
> >> pache/jasper/compiler/Generator.java?view=markup=1775598#l2713
> >>
> > This is independent of the previous issue, so you can either remove the
> > try/finally for simple tags, or fix it if you have a test on hand,
>
> I'm thinking that these couple of Jasper issues plus the APR/native
> issue I stumbled across make it worth cancelling the current 8.5.x and
> 9.0.x releases and re-rolling.

+1

>
> Thoughts?
>
> Assuming these is general agreement, I'll probably re-tag later this
> afternoon.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-09 Thread Mark Thomas
On 06/01/2017 15:58, Rémy Maucherat wrote:
> 2017-01-06 16:52 GMT+01:00 Violeta Georgieva :
> 
>> With r1775598 changes, the declaration of the scripting variable now is in
>> try/finally block and it is not visible outside this block.
>>
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/a
>> pache/jasper/compiler/Generator.java?view=markup=1775598#l2713
>>
> This is independent of the previous issue, so you can either remove the
> try/finally for simple tags, or fix it if you have a test on hand,

I'm thinking that these couple of Jasper issues plus the APR/native
issue I stumbled across make it worth cancelling the current 8.5.x and
9.0.x releases and re-rolling.

Thoughts?

Assuming these is general agreement, I'll probably re-tag later this
afternoon.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 16:52 GMT+01:00 Violeta Georgieva :

> With r1775598 changes, the declaration of the scripting variable now is in
> try/finally block and it is not visible outside this block.
>
> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/a
> pache/jasper/compiler/Generator.java?view=markup=1775598#l2713
>
> This is independent of the previous issue, so you can either remove the
try/finally for simple tags, or fix it if you have a test on hand,

Rémy


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
2017-01-06 16:57 GMT+02:00 Violeta Georgieva :
>
>
>
> 2017-01-06 15:44 GMT+02:00 Violeta Georgieva :
> >
> >
> >
> > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat :
> > >
> > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva :
> > >
> > > > I'm observing the exception below:
> > > >
> > >
> > > Maybe but I fail to see the actual problem in the generated code, and
it's
> > > not normal anyway that it makes a difference when the change is to
replace
> > >  with  .
> > > However, I should have used tagHandlerVar rather than
> > > n.getTagHandlerPoolName() for the boolean variable, for sure.
> >
> > Thanks with that change I do not see the exception anymore.
>
> Hm I see other issues now :(
>
> An error occurred at line: 8 in the jsp file: 
>  cannot be resolved to a variable
>
> I'll try to extract a simple test case ...

With r1775598 changes, the declaration of the scripting variable now is in
try/finally block and it is not visible outside this block.

http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/jasper/compiler/Generator.java?view=markup=1775598#l2713


>
> >
> > > Rémy
> > >
> > > >
> > > > [junit] An error occurred at line: 20 in the jsp file:
> > > > /bug48nnn/bug48616.jsp
> > > > [junit] Duplicate local variable
> > > > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> > > > [junit] 17: <%@ taglib prefix="bugs" uri="
http://tomcat.apache.org/
> > > > bugs"
> > > > %>
> > > > [junit] 18: 
> > > > [junit] 19: 
> > > > [junit] 20:   
> > > > [junit] 21: 
> > > > [junit]
> > > > [junit]
> > > > [junit] Stacktrace:] with root cause
> > > > [junit]  org.apache.jasper.JasperException: Unable to compile
class
> > > > for
> > > > JSP:
> > > > [junit]
> > > > [junit] An error occurred at line: 20 in the jsp file:
> > > > /bug48nnn/bug48616.jsp
> > > > [junit] Duplicate local variable
> > > > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> > > > [junit] 17: <%@ taglib prefix="bugs" uri="
http://tomcat.apache.org/
> > > > bugs"
> > > > %>
> > > > [junit] 18: 
> > > > [junit] 19: 
> > > > [junit] 20:   
> > > > [junit] 21: 
> > > > [junit]
> > > > [junit]
> > > > [junit] Stacktrace:
> > > > [junit] at
> > > > org.apache.jasper.compiler.DefaultErrorHandler.javacError(
> > > > DefaultErrorHandler.java:103)
> > > > [junit] at
> > > > org.apache.jasper.compiler.ErrorDispatcher.javacError(
> > > > ErrorDispatcher.java:212)
> > > > [junit] at
> > > >
org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
> > > > [junit] at
> > > > org.apache.jasper.compiler.Compiler.compile(Compiler.java:377)
> > > > [junit] at
> > > > org.apache.jasper.compiler.Compiler.compile(Compiler.java:349)
> > > >
> > > >
> > > > I succeeded to modify one of our tests in order to reproduce the
issue.
> > > >
> > > >
> > > > test.entry=org.apache.jasper.compiler.TestScriptingVariabler
> > > >
> > > >
> > > > Index: bug48616.jsp
> > > > ===
> > > > --- bug48616.jsp (revision 1777593)
> > > > +++ bug48616.jsp (working copy)
> > > > @@ -17,5 +17,5 @@
> > > >  <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs; %>
> > > >  
> > > >  
> > > > -  
> > > > +  
> > > >  
> > > > \ No newline at end of file
> > > >
> > > >
> > > >
> > > > >
-
> > > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > > > > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > > > >
> > > >


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
2017-01-06 15:44 GMT+02:00 Violeta Georgieva :
>
>
>
> 2017-01-06 15:24 GMT+02:00 Rémy Maucherat :
> >
> > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva :
> >
> > > I'm observing the exception below:
> > >
> >
> > Maybe but I fail to see the actual problem in the generated code, and
it's
> > not normal anyway that it makes a difference when the change is to
replace
> >  with  .
> > However, I should have used tagHandlerVar rather than
> > n.getTagHandlerPoolName() for the boolean variable, for sure.
>
> Thanks with that change I do not see the exception anymore.

Hm I see other issues now :(

An error occurred at line: 8 in the jsp file: 
 cannot be resolved to a variable

I'll try to extract a simple test case ...

>
> > Rémy
> >
> > >
> > > [junit] An error occurred at line: 20 in the jsp file:
> > > /bug48nnn/bug48616.jsp
> > > [junit] Duplicate local variable
> > > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> > > [junit] 17: <%@ taglib prefix="bugs" uri="
http://tomcat.apache.org/
> > > bugs"
> > > %>
> > > [junit] 18: 
> > > [junit] 19: 
> > > [junit] 20:   
> > > [junit] 21: 
> > > [junit]
> > > [junit]
> > > [junit] Stacktrace:] with root cause
> > > [junit]  org.apache.jasper.JasperException: Unable to compile
class
> > > for
> > > JSP:
> > > [junit]
> > > [junit] An error occurred at line: 20 in the jsp file:
> > > /bug48nnn/bug48616.jsp
> > > [junit] Duplicate local variable
> > > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> > > [junit] 17: <%@ taglib prefix="bugs" uri="
http://tomcat.apache.org/
> > > bugs"
> > > %>
> > > [junit] 18: 
> > > [junit] 19: 
> > > [junit] 20:   
> > > [junit] 21: 
> > > [junit]
> > > [junit]
> > > [junit] Stacktrace:
> > > [junit] at
> > > org.apache.jasper.compiler.DefaultErrorHandler.javacError(
> > > DefaultErrorHandler.java:103)
> > > [junit] at
> > > org.apache.jasper.compiler.ErrorDispatcher.javacError(
> > > ErrorDispatcher.java:212)
> > > [junit] at
> > >
org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
> > > [junit] at
> > > org.apache.jasper.compiler.Compiler.compile(Compiler.java:377)
> > > [junit] at
> > > org.apache.jasper.compiler.Compiler.compile(Compiler.java:349)
> > >
> > >
> > > I succeeded to modify one of our tests in order to reproduce the
issue.
> > >
> > >
> > > test.entry=org.apache.jasper.compiler.TestScriptingVariabler
> > >
> > >
> > > Index: bug48616.jsp
> > > ===
> > > --- bug48616.jsp (revision 1777593)
> > > +++ bug48616.jsp (working copy)
> > > @@ -17,5 +17,5 @@
> > >  <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs; %>
> > >  
> > >  
> > > -  
> > > +  
> > >  
> > > \ No newline at end of file
> > >
> > >
> > >
> > > >
-
> > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > > > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > > >
> > >


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 14:44 GMT+01:00 Violeta Georgieva :

> 2017-01-06 15:24 GMT+02:00 Rémy Maucherat :
> >
> > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva :
> >
> > > I'm observing the exception below:
> > >
> >
> > Maybe but I fail to see the actual problem in the generated code, and
> it's
> > not normal anyway that it makes a difference when the change is to
> replace
> >  with  .
> > However, I should have used tagHandlerVar rather than
> > n.getTagHandlerPoolName() for the boolean variable, for sure.
>
> Thanks with that change I do not see the exception anymore.
>
> Yes, it's much more logical with this more unique variable name (it's the
tag instance that gets reused, not the tag pool) and the compiler is no
longer complaining, but I still don't understand the error.

Rémy


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
2017-01-06 15:24 GMT+02:00 Rémy Maucherat :
>
> 2017-01-06 13:58 GMT+01:00 Violeta Georgieva :
>
> > I'm observing the exception below:
> >
>
> Maybe but I fail to see the actual problem in the generated code, and it's
> not normal anyway that it makes a difference when the change is to replace
>  with  .
> However, I should have used tagHandlerVar rather than
> n.getTagHandlerPoolName() for the boolean variable, for sure.

Thanks with that change I do not see the exception anymore.

> Rémy
>
> >
> > [junit] An error occurred at line: 20 in the jsp file:
> > /bug48nnn/bug48616.jsp
> > [junit] Duplicate local variable
> > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> > [junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/
> > bugs"
> > %>
> > [junit] 18: 
> > [junit] 19: 
> > [junit] 20:   
> > [junit] 21: 
> > [junit]
> > [junit]
> > [junit] Stacktrace:] with root cause
> > [junit]  org.apache.jasper.JasperException: Unable to compile class
> > for
> > JSP:
> > [junit]
> > [junit] An error occurred at line: 20 in the jsp file:
> > /bug48nnn/bug48616.jsp
> > [junit] Duplicate local variable
> > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> > [junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/
> > bugs"
> > %>
> > [junit] 18: 
> > [junit] 19: 
> > [junit] 20:   
> > [junit] 21: 
> > [junit]
> > [junit]
> > [junit] Stacktrace:
> > [junit] at
> > org.apache.jasper.compiler.DefaultErrorHandler.javacError(
> > DefaultErrorHandler.java:103)
> > [junit] at
> > org.apache.jasper.compiler.ErrorDispatcher.javacError(
> > ErrorDispatcher.java:212)
> > [junit] at
> >
org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
> > [junit] at
> > org.apache.jasper.compiler.Compiler.compile(Compiler.java:377)
> > [junit] at
> > org.apache.jasper.compiler.Compiler.compile(Compiler.java:349)
> >
> >
> > I succeeded to modify one of our tests in order to reproduce the issue.
> >
> >
> > test.entry=org.apache.jasper.compiler.TestScriptingVariabler
> >
> >
> > Index: bug48616.jsp
> > ===
> > --- bug48616.jsp (revision 1777593)
> > +++ bug48616.jsp (working copy)
> > @@ -17,5 +17,5 @@
> >  <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs; %>
> >  
> >  
> > -  
> > +  
> >  
> > \ No newline at end of file
> >
> >
> >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > >
> >


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 13:58 GMT+01:00 Violeta Georgieva :

> I'm observing the exception below:
>

Maybe but I fail to see the actual problem in the generated code, and it's
not normal anyway that it makes a difference when the change is to replace
 with  .
However, I should have used tagHandlerVar rather than
n.getTagHandlerPoolName() for the boolean variable, for sure.

Rémy

>
> [junit] An error occurred at line: 20 in the jsp file:
> /bug48nnn/bug48616.jsp
> [junit] Duplicate local variable
> _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> [junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/
> bugs"
> %>
> [junit] 18: 
> [junit] 19: 
> [junit] 20:   
> [junit] 21: 
> [junit]
> [junit]
> [junit] Stacktrace:] with root cause
> [junit]  org.apache.jasper.JasperException: Unable to compile class
> for
> JSP:
> [junit]
> [junit] An error occurred at line: 20 in the jsp file:
> /bug48nnn/bug48616.jsp
> [junit] Duplicate local variable
> _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> [junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/
> bugs"
> %>
> [junit] 18: 
> [junit] 19: 
> [junit] 20:   
> [junit] 21: 
> [junit]
> [junit]
> [junit] Stacktrace:
> [junit] at
> org.apache.jasper.compiler.DefaultErrorHandler.javacError(
> DefaultErrorHandler.java:103)
> [junit] at
> org.apache.jasper.compiler.ErrorDispatcher.javacError(
> ErrorDispatcher.java:212)
> [junit] at
> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
> [junit] at
> org.apache.jasper.compiler.Compiler.compile(Compiler.java:377)
> [junit] at
> org.apache.jasper.compiler.Compiler.compile(Compiler.java:349)
>
>
> I succeeded to modify one of our tests in order to reproduce the issue.
>
>
> test.entry=org.apache.jasper.compiler.TestScriptingVariabler
>
>
> Index: bug48616.jsp
> ===
> --- bug48616.jsp (revision 1777593)
> +++ bug48616.jsp (working copy)
> @@ -17,5 +17,5 @@
>  <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs; %>
>  
>  
> -  
> +  
>  
> \ No newline at end of file
>
>
>
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Mark Thomas
On 06/01/2017 12:58, Violeta Georgieva wrote:
> Hi,
> 
> 2017-01-06 1:38 GMT+02:00 Mark Thomas :
>>
>> The proposed Apache Tomcat 8.5.10 release is now available for voting.
>>
>> The major changes compared to the 8.5.9 release are:
>>
>> - HTTP/2 fixes and improvements
>>
>> - Simpler JSP file encoding detector that delegates XML prolog
>>   encoding detection to the JRE rather than using a custom XML
>>   parser.
>>
>> - Improve the logic that selects an address to use to unlock the
>>   Acceptor to take account of platforms what do not listen on all
>>   local addresses when configured with an address of 0.0.0.0 or ::
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/
>>
>> The proposed 8.5.10 release is:
>> [ ] Broken - do not release
>> [ ] Stable - go ahead and release as 8.5.10
> 
> I'm observing the exception below:

Is this new in 8.5.10 or does 8.5.9 have the same issue?

Mark


> 
> [junit] An error occurred at line: 20 in the jsp file:
> /bug48nnn/bug48616.jsp
> [junit] Duplicate local variable
> _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> [junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs;
> %>
> [junit] 18: 
> [junit] 19: 
> [junit] 20:   
> [junit] 21: 
> [junit]
> [junit]
> [junit] Stacktrace:] with root cause
> [junit]  org.apache.jasper.JasperException: Unable to compile class for
> JSP:
> [junit]
> [junit] An error occurred at line: 20 in the jsp file:
> /bug48nnn/bug48616.jsp
> [junit] Duplicate local variable
> _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
> [junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs;
> %>
> [junit] 18: 
> [junit] 19: 
> [junit] 20:   
> [junit] 21: 
> [junit]
> [junit]
> [junit] Stacktrace:
> [junit] at
> org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:103)
> [junit] at
> org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:212)
> [junit] at
> org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
> [junit] at
> org.apache.jasper.compiler.Compiler.compile(Compiler.java:377)
> [junit] at
> org.apache.jasper.compiler.Compiler.compile(Compiler.java:349)
> 
> 
> I succeeded to modify one of our tests in order to reproduce the issue.
> 
> 
> test.entry=org.apache.jasper.compiler.TestScriptingVariabler
> 
> 
> Index: bug48616.jsp
> ===
> --- bug48616.jsp (revision 1777593)
> +++ bug48616.jsp (working copy)
> @@ -17,5 +17,5 @@
>  <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs; %>
>  
>  
> -  
> +  
>  
> \ No newline at end of file
> 
> 
> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Violeta Georgieva
Hi,

2017-01-06 1:38 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.5.10 release is now available for voting.
>
> The major changes compared to the 8.5.9 release are:
>
> - HTTP/2 fixes and improvements
>
> - Simpler JSP file encoding detector that delegates XML prolog
>   encoding detection to the JRE rather than using a custom XML
>   parser.
>
> - Improve the logic that selects an address to use to unlock the
>   Acceptor to take account of platforms what do not listen on all
>   local addresses when configured with an address of 0.0.0.0 or ::
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/
>
> The proposed 8.5.10 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.10

I'm observing the exception below:

[junit] An error occurred at line: 20 in the jsp file:
/bug48nnn/bug48616.jsp
[junit] Duplicate local variable
_005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
[junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs;
%>
[junit] 18: 
[junit] 19: 
[junit] 20:   
[junit] 21: 
[junit]
[junit]
[junit] Stacktrace:] with root cause
[junit]  org.apache.jasper.JasperException: Unable to compile class for
JSP:
[junit]
[junit] An error occurred at line: 20 in the jsp file:
/bug48nnn/bug48616.jsp
[junit] Duplicate local variable
_005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused
[junit] 17: <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs;
%>
[junit] 18: 
[junit] 19: 
[junit] 20:   
[junit] 21: 
[junit]
[junit]
[junit] Stacktrace:
[junit] at
org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:103)
[junit] at
org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:212)
[junit] at
org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457)
[junit] at
org.apache.jasper.compiler.Compiler.compile(Compiler.java:377)
[junit] at
org.apache.jasper.compiler.Compiler.compile(Compiler.java:349)


I succeeded to modify one of our tests in order to reproduce the issue.


test.entry=org.apache.jasper.compiler.TestScriptingVariabler


Index: bug48616.jsp
===
--- bug48616.jsp (revision 1777593)
+++ bug48616.jsp (working copy)
@@ -17,5 +17,5 @@
 <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs; %>
 
 
-  
+  
 
\ No newline at end of file



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 8.5.10

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Jan 6, 2017 at 12:38 AM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.10 release is now available for voting.
>
> The major changes compared to the 8.5.9 release are:
>
> - HTTP/2 fixes and improvements
>
> - Simpler JSP file encoding detector that delegates XML prolog
>   encoding detection to the JRE rather than using a custom XML
>   parser.
>
> - Improve the logic that selects an address to use to unlock the
>   Acceptor to take account of platforms what do not listen on all
>   local addresses when configured with an address of 0.0.0.0 or ::
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/
>
> The proposed 8.5.10 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.10
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Rémy Maucherat
2017-01-06 0:38 GMT+01:00 Mark Thomas :

> The proposed Apache Tomcat 8.5.10 release is now available for voting.
>
> The major changes compared to the 8.5.9 release are:
>
> - HTTP/2 fixes and improvements
>
> - Simpler JSP file encoding detector that delegates XML prolog
>   encoding detection to the JRE rather than using a custom XML
>   parser.
>
> - Improve the logic that selects an address to use to unlock the
>   Acceptor to take account of platforms what do not listen on all
>   local addresses when configured with an address of 0.0.0.0 or ::
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/
>
> The proposed 8.5.10 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.10
>
> Rémy


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Huxing Zhang
Hi,

The proposed 8.5.10 release is:
[ ] Broken - do not release
[ X ] Stable - go ahead and release as 8.5.10

All test cases passed.
Test web application works fine.
--
From:Mark Thomas <ma...@apache.org>
Time:2017 Jan 6 (Fri) 07:39
To:dev@tomcat.apache.org <dev@tomcat.apache.org>
Subject:[VOTE] Release Apache Tomcat 8.5.10


The proposed Apache Tomcat 8.5.10 release is now available for voting.

The major changes compared to the 8.5.9 release are:

- HTTP/2 fixes and improvements

- Simpler JSP file encoding detector that delegates XML prolog
  encoding detection to the JRE rather than using a custom XML
  parser.

- Improve the logic that selects an address to use to unlock the
  Acceptor to take account of platforms what do not listen on all
  local addresses when configured with an address of 0.0.0.0 or ::

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/

The proposed 8.5.10 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.10

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 8.5.10

2017-01-05 Thread Mark Thomas
The proposed Apache Tomcat 8.5.10 release is now available for voting.

The major changes compared to the 8.5.9 release are:

- HTTP/2 fixes and improvements

- Simpler JSP file encoding detector that delegates XML prolog
  encoding detection to the JRE rather than using a custom XML
  parser.

- Improve the logic that selects an address to use to unlock the
  Acceptor to take account of platforms what do not listen on all
  local addresses when configured with an address of 0.0.0.0 or ::

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/

The proposed 8.5.10 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.10

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org