[RESULT][VOTE] Release Apache Tomcat 9.0.2

2017-11-30 Thread Mark Thomas
The following votes were cast:

+1 (beta): markt, remm, huxing, violetagg, cutherl

No other votes were cast.

The vote therefore passes.

Thank you to everyone who contributed to this release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-29 Thread Coty Sutherland
On Sat, Nov 25, 2017 at 4:36 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 9.0.2 release is now available for voting.
>
> The major changes compared to the 9.0.1 release are:
>
> - Java 9 is fully supported
>
> - Fixed numerous JASPIC issues with patches from Lazar
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.16 to pick up the latest Windows binaries built with
>   APR 1.6.3 and OpenSSL 1.0.2m
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1160/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/
>
> The proposed 9.0.2 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.2
> [x] Beta   - go ahead and release as 9.0.2

+1

> [ ] Stable - go ahead and release as 9.0.2
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-28 Thread Violeta Georgieva
2017-11-25 23:36 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 9.0.2 release is now available for voting.
>
> The major changes compared to the 9.0.1 release are:
>
> - Java 9 is fully supported
>
> - Fixed numerous JASPIC issues with patches from Lazar
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.16 to pick up the latest Windows binaries built with
>   APR 1.6.3 and OpenSSL 1.0.2m
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1160/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/
>
> The proposed 9.0.2 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.2
> [X] Beta   - go ahead and release as 9.0.2
> [ ] Stable - go ahead and release as 9.0.2

+1

Regards,
Violeta


Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-28 Thread Huxing Zhang
Hi, 

The proposed 9.0.2 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 9.0.2
[ X ] Beta   - go ahead and release as 9.0.2
[ ] Stable - go ahead and release as 9.0.2

Unit test passed on JDK8, but failed on JDK9:

Testsuite: org.apache.tomcat.util.scan.TestStandardJarScanner
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.397 sec

Testcase: testWebappClassPath took 0.276 sec
FAILED
Unexpected class loader type: jdk.internal.loader.ClassLoaders$AppClassLoader
junit.framework.AssertionFailedError: Unexpected class loader type: 
jdk.internal.loader.ClassLoaders$AppClassLoader
at 
org.apache.tomcat.util.scan.TestStandardJarScanner.testWebappClassPath(TestStandardJarScanner.java:74)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Testcase: skipsInvalidClasspathURLNoFilePartNoFileScheme took 0.068 sec

This is because jdk.internal.loader.ClassLoaders$AppClassLoader is no longer a 
sub class or URLClassLoader from JDK9, I can't find a easy way to work it 
around except for using reflection.

Examples runs fine under both JDK8 and JDK9.

Our test web application runs fine on JDK8, but failed on JDK9 (it is not a 
tomcat issue.)

--
Mark Thomas 
2017 Nov 26 (Sun) 05:36
Tomcat Developers List 
[VOTE] Release Apache Tomcat 9.0.2


The proposed Apache Tomcat 9.0.2 release is now available for voting.

The major changes compared to the 9.0.1 release are:

- Java 9 is fully supported

- Fixed numerous JASPIC issues with patches from Lazar

- Update the packaged version of the Tomcat Native Library to
  1.2.16 to pick up the latest Windows binaries built with
  APR 1.6.3 and OpenSSL 1.0.2m

Along with lots of other bug fixes and improvements.


For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1160/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/

The proposed 9.0.2 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 9.0.2
[ ] Beta   - go ahead and release as 9.0.2
[ ] Stable - go ahead and release as 9.0.2

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-27 Thread Mark Thomas
On 27/11/17 10:40, Rémy Maucherat wrote:
> On Sat, Nov 25, 2017 at 10:36 PM, Mark Thomas  wrote:
> 
>> - Fixed numerous JASPIC issues with patches from Lazar
>>
> 
> I would have mentioned all the HTTP/2 fixes instead personally :)

Good point. I'll add a bullet point to the release announcement for
those. Something like:

- Fixed a number of HTTP/2 issues

?

Mark

> 
> 
>>
>> Along with lots of other bug fixes and improvements.
>>
>>
>> For full details, see the changelog:
>> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1160/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/
>>
>> The proposed 9.0.2 release is:
>> [ ] Broken - do not release
>> [ ] Alpha  - go ahead and release as 9.0.2
>> [X] Beta   - go ahead and release as 9.0.2
>> [ ] Stable - go ahead and release as 9.0.2
>>
> 
> I think important features got stressed tested and fixed this time (push,
> in particular), so it might be good enough for stable.
> 
> Rémy
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-27 Thread Rémy Maucherat
On Sat, Nov 25, 2017 at 10:36 PM, Mark Thomas  wrote:

> - Fixed numerous JASPIC issues with patches from Lazar
>

I would have mentioned all the HTTP/2 fixes instead personally :)


>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1160/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/
>
> The proposed 9.0.2 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.2
> [X] Beta   - go ahead and release as 9.0.2
> [ ] Stable - go ahead and release as 9.0.2
>

I think important features got stressed tested and fixed this time (push,
in particular), so it might be good enough for stable.

Rémy


Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-27 Thread Mark Thomas
On 25/11/17 21:36, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.2 release is now available for voting.
> 
> The major changes compared to the 9.0.1 release are:
> 
> - Java 9 is fully supported
> 
> - Fixed numerous JASPIC issues with patches from Lazar
> 
> - Update the packaged version of the Tomcat Native Library to
>   1.2.16 to pick up the latest Windows binaries built with
>   APR 1.6.3 and OpenSSL 1.0.2m
> 
> Along with lots of other bug fixes and improvements.
> 
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1160/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/
> 
> The proposed 9.0.2 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.2
> [X] Beta   - go ahead and release as 9.0.2
> [ ] Stable - go ahead and release as 9.0.2

Unit tests pass for NIO, NIO2 and APR/native with Tomcat Native 1.2.16
on Windows, OSX and Linux.

I think we are fairly close to a stable release but I'd like to see what
issues emerge over at least one more release cycle before voting stable.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-27 Thread Romain Manni-Bucau
2017-11-27 9:15 GMT+01:00 Konstantin Kolinko :
> 2017-11-27 10:55 GMT+03:00 Romain Manni-Bucau :
>> Hi guys,
>>
>> I have 2 questions:
>>
>> 1. (simple ;)) is the repo released? central is not yet synch-ed
>
> It is a VOTE thread, not a RELEASE one.
>
> Nothing should be on Central.

oops, not sure why I read announce yesterday, forget it

>
>> 2. "java 9 fully supported": I didn't see the classloader update to
>> support multi-jar release
>
> Yes. Issue 61601.
>
>> or module-info respect (visibility+SPI),
>
> I do not understand what you mean here.
>
> There are no such feature requests in Bugzilla, nor in changelog,
> meaning nobody needs this feature.

Well this is a bit fast as answer ;) since java 9 brings new features
then fully supported would naturally mean Tomcat embraces these
features as well otherwise you can code a "standard" java 9 app and
have it not working in Tomcat. There is no issue
not supporting it yet - even Spring doesn't - but the "fully" made me
wondering if I missed a key commit.

Thanks for the clarification.

>
>> is it intended or is it "support" as "can run" only?
>>
>> Romain Manni-Bucau
>> @rmannibucau |  Blog | Old Blog | Github | LinkedIn
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.2

2017-11-27 Thread Konstantin Kolinko
2017-11-27 10:55 GMT+03:00 Romain Manni-Bucau :
> Hi guys,
>
> I have 2 questions:
>
> 1. (simple ;)) is the repo released? central is not yet synch-ed

It is a VOTE thread, not a RELEASE one.

Nothing should be on Central.

> 2. "java 9 fully supported": I didn't see the classloader update to
> support multi-jar release

Yes. Issue 61601.

> or module-info respect (visibility+SPI),

I do not understand what you mean here.

There are no such feature requests in Bugzilla, nor in changelog,
meaning nobody needs this feature.

> is it intended or is it "support" as "can run" only?
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Fwd: [VOTE] Release Apache Tomcat 9.0.2

2017-11-26 Thread Romain Manni-Bucau
Hi guys,

I have 2 questions:

1. (simple ;)) is the repo released? central is not yet synch-ed
2. "java 9 fully supported": I didn't see the classloader update to
support multi-jar release or module-info respect (visibility+SPI), is
it intended or is it "support" as "can run" only?

Romain Manni-Bucau
@rmannibucau |  Blog | Old Blog | Github | LinkedIn



-- Forwarded message --
From: Mark Thomas 
Date: 2017-11-25 22:36 GMT+01:00
Subject: [VOTE] Release Apache Tomcat 9.0.2
To: Tomcat Developers List 


The proposed Apache Tomcat 9.0.2 release is now available for voting.

The major changes compared to the 9.0.1 release are:

- Java 9 is fully supported

- Fixed numerous JASPIC issues with patches from Lazar

- Update the packaged version of the Tomcat Native Library to
  1.2.16 to pick up the latest Windows binaries built with
  APR 1.6.3 and OpenSSL 1.0.2m

Along with lots of other bug fixes and improvements.


For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1160/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/

The proposed 9.0.2 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 9.0.2
[ ] Beta   - go ahead and release as 9.0.2
[ ] Stable - go ahead and release as 9.0.2

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Apache Tomcat 9.0.2

2017-11-25 Thread Mark Thomas
The proposed Apache Tomcat 9.0.2 release is now available for voting.

The major changes compared to the 9.0.1 release are:

- Java 9 is fully supported

- Fixed numerous JASPIC issues with patches from Lazar

- Update the packaged version of the Tomcat Native Library to
  1.2.16 to pick up the latest Windows binaries built with
  APR 1.6.3 and OpenSSL 1.0.2m

Along with lots of other bug fixes and improvements.


For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1160/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/

The proposed 9.0.2 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 9.0.2
[ ] Beta   - go ahead and release as 9.0.2
[ ] Stable - go ahead and release as 9.0.2

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org