Re: [VOTE] Release Apache Tomcat 9.0.59

2022-02-25 Thread jean-frederic clere

On 25/02/2022 18:14, Rainer Jung wrote:

Hi Jean-Frederic,

Am 25.02.2022 um 17:27 schrieb jean-frederic clere:

On 21/02/2022 22:20, Rémy Maucherat wrote:

[X] Stable - go ahead and release as 9.0.59 (stable)


Tested on fedora fc35 with openjdk version "11.0.14.1"

My tests failed with openjdk version "1.8.0_322"
test-nio:
 [junit] Unrecognized option: 
--add-opens=java.base/java.lang=ALL-UNNAMED

 [junit] Error: Could not create the Java Virtual Machine.
The problem is to compile the tests with java11 and test with java8 I 
need to fix my tests :-(


we had this discussion in another thread. It should suffice to add the 
following lines to your own build.properties file:


opens.javalang=-Dnop
opens.javaio=-Dnop
opens.sunrmi=-Dnop
opens.javautil=-Dnop
opens.javautilconcurrent=-Dnop

You can add them before building or also just before running the test. 
They only apply to the unit test runs. The "nop" was chosen as any 
system property name that is likely not actually being used. It should 
remind one of a "no-operation".


Yes that helps
+++
BUILD SUCCESSFUL
Total time: 76 minutes 39 seconds

DONE: All OK
+++

So tested: with openjdk version "1.8.0_322" too.



Best regards,

Rainer




--
Cheers

Jean-Frederic


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.59

2022-02-25 Thread Rainer Jung

Hi Jean-Frederic,

Am 25.02.2022 um 17:27 schrieb jean-frederic clere:

On 21/02/2022 22:20, Rémy Maucherat wrote:

[X] Stable - go ahead and release as 9.0.59 (stable)


Tested on fedora fc35 with openjdk version "11.0.14.1"

My tests failed with openjdk version "1.8.0_322"
test-nio:
     [junit] Unrecognized option: 
--add-opens=java.base/java.lang=ALL-UNNAMED

     [junit] Error: Could not create the Java Virtual Machine.
The problem is to compile the tests with java11 and test with java8 I 
need to fix my tests :-(


we had this discussion in another thread. It should suffice to add the 
following lines to your own build.properties file:


opens.javalang=-Dnop
opens.javaio=-Dnop
opens.sunrmi=-Dnop
opens.javautil=-Dnop
opens.javautilconcurrent=-Dnop

You can add them before building or also just before running the test. 
They only apply to the unit test runs. The "nop" was chosen as any 
system property name that is likely not actually being used. It should 
remind one of a "no-operation".


Best regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.59

2022-02-25 Thread jean-frederic clere

On 21/02/2022 22:20, Rémy Maucherat wrote:

[X] Stable - go ahead and release as 9.0.59 (stable)


Tested on fedora fc35 with openjdk version "11.0.14.1"

My tests failed with openjdk version "1.8.0_322"
test-nio:
[junit] Unrecognized option: 
--add-opens=java.base/java.lang=ALL-UNNAMED

[junit] Error: Could not create the Java Virtual Machine.
The problem is to compile the tests with java11 and test with java8 I 
need to fix my tests :-(


--
Cheers

Jean-Frederic


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.59

2022-02-25 Thread Coty Sutherland
On Mon, Feb 21, 2022 at 4:21 PM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.59 release is now available for voting.
>
> The notable changes compared to 9.0.58 are:
>
> - Add support for additional user attributes to TomcatPrincipal and
>GenericPrincipal
>
> - Correct a regression in the fix for 65454 that meant that
>minSpareThreads and maxThreads settings were ignored when the
>Connector used an internal executor
>
> - Improve the detection of the Linux duplicate accept bug and reduce
>(hopefully avoid) instances of false positives.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.59/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1358
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.59
> 020f955044c1f9b512ee3da477eaa018da87e71a
>
> The proposed 9.0.59 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.59 (stable)
>

+1


> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.59

2022-02-25 Thread Mladen Turk



On 21/02/2022 22:20, Rémy Maucherat wrote:


The proposed 9.0.59 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 9.0.59 (stable)



Tested on Windows Server 2019/OpenJDK

Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.59

2022-02-22 Thread Rémy Maucherat
On Mon, Feb 21, 2022 at 10:20 PM Rémy Maucherat  wrote:
>
> The proposed Apache Tomcat 9.0.59 release is now available for voting.
>
> The notable changes compared to 9.0.58 are:
>
> - Add support for additional user attributes to TomcatPrincipal and
>GenericPrincipal
>
> - Correct a regression in the fix for 65454 that meant that
>minSpareThreads and maxThreads settings were ignored when the
>Connector used an internal executor
>
> - Improve the detection of the Linux duplicate accept bug and reduce
>(hopefully avoid) instances of false positives.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.59/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1358
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.59
> 020f955044c1f9b512ee3da477eaa018da87e71a
>
> The proposed 9.0.59 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.59 (stable)

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Apache Tomcat 9.0.59

2022-02-21 Thread Rémy Maucherat
The proposed Apache Tomcat 9.0.59 release is now available for voting.

The notable changes compared to 9.0.58 are:

- Add support for additional user attributes to TomcatPrincipal and
   GenericPrincipal

- Correct a regression in the fix for 65454 that meant that
   minSpareThreads and maxThreads settings were ignored when the
   Connector used an internal executor

- Improve the detection of the Linux duplicate accept bug and reduce
   (hopefully avoid) instances of false positives.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.59/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1358
The tag is:
https://github.com/apache/tomcat/tree/9.0.59
020f955044c1f9b512ee3da477eaa018da87e71a

The proposed 9.0.59 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 9.0.59 (stable)

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org