Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-09-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 8/21/20 14:22, Mark Thomas wrote:
> Version 1.2.25 includes the following changes compared to 1.2.24
>
> - Improvements to LibreSSL support
>
> - Improvements to HP_UX support
>
> Various other fixes and improvements. See the changelog for
> details.
>
> The proposed release artefacts can be found at [1], and the build
> was done using tag [2].
>
> The Apache Tomcat Native 1.2.25 release is [ ] Stable, go ahead and
> release [ ] Broken because of ...

Thanks for rm'ing.

All signatures match.
Compiles without issue (gcc 6.3.0, OpenSSL 1.1.0l (+Debian), APR 1.5.2).

I wasn't able to perform any actual testing; this is a +0 vote for
compile-test success only.

Looks like no unit-tests. "make check" fails immediately; looks like
it wasn't really expected to work :shrug:

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl9QSeoACgkQHPApP6U8
pFhenw//R3zSula9q4uPUw+AXm/untLbXme7nVkC0K9yrZVQusvRJaU2AafEhBC2
9RxgfsOnR71VbUWBCezYjfphDMIQBgtgccr2fRYX+GTEUN3vTsSxF1RASpiOuIIN
eZGtLUukpiP8UdOPrPHEPlfE1XI13YwJ7RhSuNvqgSAb2MAx+72ssBpigywTBs13
9Y1AZ7UjdvvfcN7TuE24fX4mh6ltfZc/gYL13X/UW5GijVilM5l4932eKAvOFBhn
mQuKx/nmdTuV6zNZ7RQcaV6Af2QL3eRn1uxjCQmPHzBl77TD5kSf/nXa7DTTJmrv
8+O50mT2uznF5Op1Eb3StHsW/dhMI2ZHDVk15xU6jcLmxEluBAFLMdAPhb6k9Hvz
Drt8C3SrpcQmdx3SFdtXxdznpaCOnyrUXv/YXhnoALOy6jmKz7ZnpFzOhc27DoIV
zLFoQ6SpDPy0R6emqkDsKgkF/gLbgnpDh6chyLoUU6L54BGX24cVoaTF52Ucwhfl
Nk4/KpiZopCiVKkIK4IJvJP92AIIRfRY1B8y8LEohZ6tm2VshHA9dT4mhnB1bsLc
N8ORq44eghgZz3TjgGT1UVXS+KP4W0hWeLw0rwBD1B+bBdN4A2Li392/yXcz3Ugb
8IiSWqHh0L3JuRdHSsxw1eY+LhAE6m23OxIMLJOu/eyS3I+I2Z8=
=AKkE
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-09-02 Thread Felix Schumacher


Am 21.08.20 um 20:22 schrieb Mark Thomas:
> Version 1.2.25 includes the following changes compared to 1.2.24
>
> - Improvements to LibreSSL support
>
> - Improvements to HP_UX support
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.25 release is
>  [x] Stable, go ahead and release
>  [ ] Broken because of ...

Unit tests ran OK with openssl 1.1.1g ( a few failures with libressl 3.1.4)

Felix

> Thanks,
>
> Mark
>
>
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.25
> [2]
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=a94590ec2a5e40b168a9494144125a52f41ed0b2
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-09-01 Thread Mark Thomas
All,

We only have 2 PMC +1 votes for this release.

Mark


On 21/08/2020 19:22, Mark Thomas wrote:
> Version 1.2.25 includes the following changes compared to 1.2.24
> 
> - Improvements to LibreSSL support
> 
> - Improvements to HP_UX support
> 
> Various other fixes and improvements. See the changelog for details.
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.25 release is
>  [ ] Stable, go ahead and release
>  [ ] Broken because of ...
> 
> Thanks,
> 
> Mark
> 
> 
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.25
> [2]
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=a94590ec2a5e40b168a9494144125a52f41ed0b2
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-25 Thread Martin Grigorov
On Fri, Aug 21, 2020 at 9:22 PM Mark Thomas  wrote:

> Version 1.2.25 includes the following changes compared to 1.2.24
>
> - Improvements to LibreSSL support
>
> - Improvements to HP_UX support
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.25 release is
>  [ X ] Stable, go ahead and release
>  [ ] Broken because of ...
>

Everything works fine in my daily builds on x86_64 and aarch64!

Just one minor issue/question:

$ ls -la /home/ubuntu/git/apache/tomcat-native-build/lib
total 3.4M
-rw-r--r-- 1 ubuntu ubuntu 2.2M Aug 25 02:30 libtcnative-1.a
-rwxr-xr-x 1 ubuntu ubuntu 1.1K Aug 25 02:30 libtcnative-1.la*
lrwxrwxrwx 1 ubuntu ubuntu   23 Aug 25 02:30 libtcnative-1.so ->
libtcnative-1.so.0.2.26*
lrwxrwxrwx 1 ubuntu ubuntu   23 Aug 25 02:30 libtcnative-1.so.0 ->
libtcnative-1.so.0.2.26*
-rwxr-xr-x 1 ubuntu ubuntu 1.3M Aug 25 02:30 libtcnative-1.so.0.2.26*

Why .so.0.2.26 ? Shouldn't it be 1.2.26 ?


> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.25
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=a94590ec2a5e40b168a9494144125a52f41ed0b2
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-24 Thread Michael Osipov

Am 2020-08-24 um 15:42 schrieb Mark Thomas:



On 24/08/2020 12:58, Michael Osipov wrote:

Am 2020-08-21 um 20:22 schrieb Mark Thomas:

Version 1.2.25 includes the following changes compared to 1.2.24

- Improvements to LibreSSL support

- Improvements to HP_UX support

Various other fixes and improvements. See the changelog for details.

The proposed release artefacts can be found at [1],
and the build was done using tag [2].


A bit late, but here are my findings. I am not sure whether they are in
Tomcat or libtcnative.

I see reliable failures in tests with LibreSSL 2.9.0 and 3.2.1 (master)
with libtcnative master and Tomcat master on FreeBSD 12-STABLE and
OpenJDK 1.8.0_265.


Is that any different with 1.2.24?


FWIW, I have tried now 2.9.x, 3.0.x, 3.1.x and 3.2.x (master). All of 
them crash (JVM crash) 
TEST-org.apache.tomcat.util.net.TestSSLHostConfigCompat.*.txt. It must 
be a general problem somewhere.



frame #10: 0x000a6e3df807 
libtcnative-1.so.0.2.24`Java_org_apache_tomcat_jni_SSLContext_setCertificateRaw(e=0x0008054421e0,
 o=, ctx=44874834080, javaCert=, 
javaKey=, idx=0) at sslcontext.c:1192:9
frame #11: 0x000805618587

as well as

Stack: [0x7fffdfefe000,0x7fffdfffe000],  sp=0x7fffdfffb7c0,  free 
space=1013k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libssl.so.48+0x42b59]  SSL_CTX_use_certificate+0x9
C  [libtcnative-1.so.0.2.24+0x24807]  
Java_org_apache_tomcat_jni_SSLContext_setCertificateRaw+0x1d7
j  org.apache.tomcat.jni.SSLContext.setCertificateRaw(J[B[BI)Z+0
j  
org.apache.tomcat.util.net.openssl.OpenSSLContext.addCertificate(Lorg/apache/tomcat/util/net/SSLHostConfigCertificate;)V+214
j  
org.apache.tomcat.util.net.AprEndpoint.createSSLContext(Lorg/apache/tomcat/util/net/SSLHostConfig;)V+146
j  org.apache.tomcat.util.net.AprEndpoint.bind()V+461
j  org.apache.tomcat.util.net.AbstractEndpoint.bindWithCleanup()V+1


M

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-24 Thread Michael Osipov

Am 2020-08-24 um 15:42 schrieb Mark Thomas:



On 24/08/2020 12:58, Michael Osipov wrote:

Am 2020-08-21 um 20:22 schrieb Mark Thomas:

Version 1.2.25 includes the following changes compared to 1.2.24

- Improvements to LibreSSL support

- Improvements to HP_UX support

Various other fixes and improvements. See the changelog for details.

The proposed release artefacts can be found at [1],
and the build was done using tag [2].


A bit late, but here are my findings. I am not sure whether they are in
Tomcat or libtcnative.

I see reliable failures in tests with LibreSSL 2.9.0 and 3.2.1 (master)
with libtcnative master and Tomcat master on FreeBSD 12-STABLE and
OpenJDK 1.8.0_265.


Is that any different with 1.2.24?


1.2.24 does not compile at all with LibreSSL unless you perform these 
steps: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246373#c0


I did that, compiled against 2.9.2 and 3.2.1 (master): Same behavior!

This isn't a blocker (critical) for you now?

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-24 Thread Mark Thomas



On 24/08/2020 12:58, Michael Osipov wrote:
> Am 2020-08-21 um 20:22 schrieb Mark Thomas:
>> Version 1.2.25 includes the following changes compared to 1.2.24
>>
>> - Improvements to LibreSSL support
>>
>> - Improvements to HP_UX support
>>
>> Various other fixes and improvements. See the changelog for details.
>>
>> The proposed release artefacts can be found at [1],
>> and the build was done using tag [2].
> 
> A bit late, but here are my findings. I am not sure whether they are in
> Tomcat or libtcnative.
> 
> I see reliable failures in tests with LibreSSL 2.9.0 and 3.2.1 (master)
> with libtcnative master and Tomcat master on FreeBSD 12-STABLE and
> OpenJDK 1.8.0_265.

Is that any different with 1.2.24?

Mark

> 
> Please see:
> http://home.apache.org/~michaelo/tomcat-master-tcnative-master-libressl-2.9.0/
> as well as
> http://home.apache.org/~michaelo/tomcat-master-tcnative-master-libressl-master/.
> 
> 
> Let me know if you need further information for analysis/fixing.
> 
> Michael
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-24 Thread Michael Osipov

Am 2020-08-21 um 20:22 schrieb Mark Thomas:

Version 1.2.25 includes the following changes compared to 1.2.24

- Improvements to LibreSSL support

- Improvements to HP_UX support

Various other fixes and improvements. See the changelog for details.

The proposed release artefacts can be found at [1],
and the build was done using tag [2].


A bit late, but here are my findings. I am not sure whether they are in 
Tomcat or libtcnative.


I see reliable failures in tests with LibreSSL 2.9.0 and 3.2.1 (master) 
with libtcnative master and Tomcat master on FreeBSD 12-STABLE and 
OpenJDK 1.8.0_265.


Please see: 
http://home.apache.org/~michaelo/tomcat-master-tcnative-master-libressl-2.9.0/ 
as well as 
http://home.apache.org/~michaelo/tomcat-master-tcnative-master-libressl-master/.


Let me know if you need further information for analysis/fixing.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.25

2020-08-21 Thread Mark Thomas
On 21/08/2020 19:22, Mark Thomas wrote:
> Version 1.2.25 includes the following changes compared to 1.2.24
> 
> - Improvements to LibreSSL support
> 
> - Improvements to HP_UX support
> 
> Various other fixes and improvements. See the changelog for details.
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.25 release is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

I've been running unit tests locally without any issues.

Mark


> 
> Thanks,
> 
> Mark
> 
> 
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.25
> [2]
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=a94590ec2a5e40b168a9494144125a52f41ed0b2
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Apache Tomcat Native 1.2.25

2020-08-21 Thread Mark Thomas
Version 1.2.25 includes the following changes compared to 1.2.24

- Improvements to LibreSSL support

- Improvements to HP_UX support

Various other fixes and improvements. See the changelog for details.

The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.25 release is
 [ ] Stable, go ahead and release
 [ ] Broken because of ...

Thanks,

Mark


[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.25
[2]
https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=a94590ec2a5e40b168a9494144125a52f41ed0b2

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org