Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-15 Thread Filip Hanik - Dev Lists
Sebb, thanks for the feedback. sebb wrote: Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool *v1.0.5-beta* which looks wrong. fixed. == The documentation for the

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-15 Thread sebb
On 15/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, thanks for the feedback. sebb wrote: Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Filip Hanik - Dev Lists
How about a little love here :) my vote [X] STABLE - I couldn't find any bugs Filip Filip Hanik - Dev Lists wrote: The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.3/ ballot [ ] BETA - I found some bugs but not critical [ ] BROKEN - I found some show stoppers

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
Sorry for somewhat slow reply, but just on formal grounds it is [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice http://www.apache.org/dev/release.html#distribute-other-artifacts So, a copy of a LICENSE and NOTICE files is required, at least along

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
2009/6/11 Konstantin Kolinko knst.koli...@gmail.com: Sorry for somewhat slow reply, but just on formal grounds it is  [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice http://www.apache.org/dev/release.html#distribute-other-artifacts So, a copy

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Filip Hanik - Dev Lists
Konstantin Kolinko wrote: 2009/6/11 Konstantin Kolinko knst.koli...@gmail.com: Sorry for somewhat slow reply, but just on formal grounds it is [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
2. changelog.html, jdbc-pool.html need images: tomcat.gif asf-logo.gif add.gif fix.gif update.gif these will be automatically linked up on the site, when the jdbc-pool gets uploaded to our website These apache-tomcat-jdbc-1.0.3.zip, *.tar.gz are distribution that will be downloadable,

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread sebb
Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool *v1.0.5-beta* which looks wrong. == The documentation for the Interceptors appears to be incorrect. For example: The code

[VOTE] Release JDBC Pool module v1.0.3

2009-06-08 Thread Filip Hanik - Dev Lists
The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.3/ ballot [ ] STABLE - I couldn't find any bugs [ ] BETA - I found some bugs but not critical [ ] BROKEN - I found some show stoppers /ballot Any comments ? Thanks, Filip