Re: [tomcat] 01/01: Tag 9.0.23
On 14/08/2019 18:48, Rainer Jung wrote: > Hi there, > > this commit introduced a BOM at the beginning of the changelog.xml file, > which leads to a checkstyle validation failure during building 9.0.23 > (when validation is actiive). > > The BOM isn't shown in the below mail, but one can see the leading ef bb > bf wit any binary editor. I first thought the failure was due to the > checkstyle update, but it is just the BOM. > > That's no functional problem, but people trying to build 9.0.23 with > validation on will fail and wonder. Not sure whether that warrants a > retag. I can see the BOM in the 8.5.44 file as well. I'll re-tag both of them. I think I edited the file with notepad rather than vi this time around which is probably how this happened. Apologies for the hassle. Mark > > Regards, > > Rainer > > Am 14.08.2019 um 13:10 schrieb ma...@apache.org: >> This is an automated email from the ASF dual-hosted git repository. >> >> markt pushed a commit to tag 9.0.23 >> in repository https://gitbox.apache.org/repos/asf/tomcat.git >> >> commit bd48c597e3cb280d73d9c9279babcaf75b6879c0 >> Author: Mark Thomas >> AuthorDate: Wed Aug 14 12:10:06 2019 +0100 >> >> Tag 9.0.23 >> --- >> build.properties.default | 2 +- >> webapps/docs/changelog.xml | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/build.properties.default b/build.properties.default >> index 14ef092..3146ccb 100644 >> --- a/build.properties.default >> +++ b/build.properties.default >> @@ -27,7 +27,7 @@ version.major=9 >> version.minor=0 >> version.build=23 >> version.patch=0 >> -version.suffix=-dev >> +version.suffix= >> # - Build control flags - >> # Note enabling validation uses Checkstyle which is LGPL licensed >> diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml >> index 0cbf970..15646db 100644 >> --- a/webapps/docs/changelog.xml >> +++ b/webapps/docs/changelog.xml >> @@ -1,4 +1,4 @@ >> - >> + >> >> - >> + >> >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] 01/01: Tag 9.0.23
Hi there, this commit introduced a BOM at the beginning of the changelog.xml file, which leads to a checkstyle validation failure during building 9.0.23 (when validation is actiive). The BOM isn't shown in the below mail, but one can see the leading ef bb bf wit any binary editor. I first thought the failure was due to the checkstyle update, but it is just the BOM. That's no functional problem, but people trying to build 9.0.23 with validation on will fail and wonder. Not sure whether that warrants a retag. I can see the BOM in the 8.5.44 file as well. Regards, Rainer Am 14.08.2019 um 13:10 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 9.0.23 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bd48c597e3cb280d73d9c9279babcaf75b6879c0 Author: Mark Thomas AuthorDate: Wed Aug 14 12:10:06 2019 +0100 Tag 9.0.23 --- build.properties.default | 2 +- webapps/docs/changelog.xml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 14ef092..3146ccb 100644 --- a/build.properties.default +++ b/build.properties.default @@ -27,7 +27,7 @@ version.major=9 version.minor=0 version.build=23 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 0cbf970..15646db 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -1,4 +1,4 @@ - + - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/01: Tag 9.0.23
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 9.0.23 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bd48c597e3cb280d73d9c9279babcaf75b6879c0 Author: Mark Thomas AuthorDate: Wed Aug 14 12:10:06 2019 +0100 Tag 9.0.23 --- build.properties.default | 2 +- webapps/docs/changelog.xml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 14ef092..3146ccb 100644 --- a/build.properties.default +++ b/build.properties.default @@ -27,7 +27,7 @@ version.major=9 version.minor=0 version.build=23 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 0cbf970..15646db 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -1,4 +1,4 @@ - + - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
