This is an automated email from the ASF dual-hosted git repository.

lihan pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new fcdc7e86be Fix the releaseIdleCounter is incorrect.
fcdc7e86be is described below

commit fcdc7e86bed9f59c046598fdd8fb295dc176810e
Author: lihan <li...@apache.org>
AuthorDate: Fri Aug 4 14:52:50 2023 +0800

    Fix the releaseIdleCounter is incorrect.
    
    Fix the releaseIdleCounter does not increment when testAllIdle releases 
them. Pull request #241 provided by Arun Chaitanya Miriappalli
---
 .../src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java    | 1 +
 webapps/docs/changelog.xml                                           | 5 +++++
 2 files changed, 6 insertions(+)

diff --git 
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
index e4f5873d04..6d059b32ca 100644
--- 
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
+++ 
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
@@ -1142,6 +1142,7 @@ public class ConnectionPool {
                         continue;
                     }
                     if (!con.validate(PooledConnection.VALIDATE_IDLE)) {
+                        releasedIdleCount.incrementAndGet();
                         idle.remove(con);
                         release(con);
                     }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 4c2d76803b..51d90d62cd 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -151,6 +151,11 @@
   </subsection>
   <subsection name="jdbc-pool">
     <changelog>
+      <fix>
+        Fix the <code>releaseIdleCounter</code> does not increment when 
testAllIdle
+        releases them. Pull request <pr>241</pr> provided by Arun Chaitanya 
Miriappalli
+        (lihan)
+      </fix>
       <fix>
         Fix the <code>ConnectionState</code> state will be inconsistent with 
actual
         state on the connection when an exception occurs while writing. Pull 
request


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to