[tomcat] branch 8.5.x updated: Fix typo. Better test coverage.

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new 04a5714  Fix typo. Better test coverage.
04a5714 is described below

commit 04a571475d74c547bf6268fd1a1211822bfb6880
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Apr 3 18:54:03 2020 +0100

    Fix typo. Better test coverage.
---
 test/org/apache/tomcat/util/res/TestStringManager.java | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/test/org/apache/tomcat/util/res/TestStringManager.java 
b/test/org/apache/tomcat/util/res/TestStringManager.java
index 7caeead..97959ab 100644
--- a/test/org/apache/tomcat/util/res/TestStringManager.java
+++ b/test/org/apache/tomcat/util/res/TestStringManager.java
@@ -53,9 +53,17 @@ public class TestStringManager {
     }
 
     @Test
-    public void testMissing() {
+    public void testMissingWithTccl() {
         
Thread.currentThread().setContextClassLoader(TestStringManager.class.getClassLoader());
-        StringManager sm = StringManager.getManager("org.does.no.exist");
+        StringManager sm = StringManager.getManager("org.does.not.exist");
+        Assert.assertNull(sm.getLocale());
+    }
+
+
+    @Test
+    public void testMissingNullTccl() {
+        Thread.currentThread().setContextClassLoader(null);
+        StringManager sm = StringManager.getManager("org.does.not.exist");
         Assert.assertNull(sm.getLocale());
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org